Skip to content

NLL says "borrowed content" instead of more precise "dereference of raw pointer" - #54825

Merged
bors merged 1 commit into
rust-lang:masterfrom
davidtwco:issue-52663-deref-raw-pointer
Oct 12, 2018
Merged

NLL says "borrowed content" instead of more precise "dereference of raw pointer"#54825
bors merged 1 commit into
rust-lang:masterfrom
davidtwco:issue-52663-deref-raw-pointer

Conversation

@davidtwco

Copy link
Copy Markdown
Member

Part of #52663.

Previously, move errors involving the dereference of a raw pointer would
say "borrowed content". This commit changes it to say "dereference of
raw pointer".

r? @nikomatsakis
cc @pnkfelix

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 4, 2018
@bors

This comment has been minimized.

@davidtwco
davidtwcoforce-pushed the issue-52663-deref-raw-pointer branch from 0561631 to 9d1b337CompareOctober 5, 2018 11:39
@memoryruinsmemoryruins added the A-NLL Area: Non-lexical lifetimes (NLL) label Oct 6, 2018
Comment threadsrc/librustc_mir/borrow_check/move_errors.rs Outdated
Previously, move errors involving the dereference of a raw pointer would
say "borrowed content". This commit changes it to say "dereference of
raw pointer".
@davidtwco
davidtwcoforce-pushed the issue-52663-deref-raw-pointer branch from 9d1b337 to fe8ace8CompareOctober 8, 2018 10:23
Comment threadsrc/test/ui/borrowck/borrowck-move-from-unsafe-ptr.nll.stderr Outdated
@pnkfelix

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Oct 11, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit fe8ace8 has been approved by pnkfelix

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 11, 2018
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Oct 11, 2018
…nter, r=pnkfelix
NLL says "borrowed content" instead of more precise "dereference of raw pointer"
Part of rust-lang#52663.
Previously, move errors involving the dereference of a raw pointer would
say "borrowed content". This commit changes it to say "dereference of
raw pointer".
r? @nikomatsakis
cc @pnkfelix
kennytm added a commit to kennytm/rust that referenced this pull request Oct 12, 2018
…nter, r=pnkfelix
NLL says "borrowed content" instead of more precise "dereference of raw pointer"
Part of rust-lang#52663.
Previously, move errors involving the dereference of a raw pointer would
say "borrowed content". This commit changes it to say "dereference of
raw pointer".
r? @nikomatsakis
cc @pnkfelix
@kennytmkennytm mentioned this pull request Oct 12, 2018
bors added a commit that referenced this pull request Oct 12, 2018
Rollup of 16 pull requests
Successful merges:
- #54755 (Documents reference equality by address (#54197))
- #54811 (During rustc bootstrap, make default for `optimize` independent of `debug`)
- #54825 (NLL says "borrowed content" instead of more precise "dereference of raw pointer")
- #54860 (Add doc comments about safest way to initialize a vector of zeros)
- #54869 (Fix mobile docs)
- #54891 (Fix tracking issue for Once::is_completed)
- #54913 (doc fix: it's auto traits that make for automatic implementations)
- #54920 (Fix handling of #[must_use] on unit and uninhabited types)
- #54932 (A handful of random string-related improvements)
- #54936 (impl Eq+Hash for TyLayout)
- #54950 (std: Synchronize global allocator on wasm32)
- #54956 ("(using ..." doesn't have the matching ")")
- #54958 (add a macro for static (compile-time) assertions)
- #54967 (Remove incorrect span for second label inner macro invocation)
- #54983 (Fix slice's benchmarks)
- #54989 (Fix spelling in the documentation to htmldocck.py)
Failed merges:
r? @ghost
@bors
bors merged commit fe8ace8 into rust-lang:masterOct 12, 2018
@davidtwco
davidtwco deleted the issue-52663-deref-raw-pointer branch October 12, 2018 18:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-NLLArea: Non-lexical lifetimes (NLL)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@davidtwco@bors@pnkfelix@nikomatsakis@memoryruins@rust-highfive