Skip to content

add a macro for static (compile-time) assertions - #54958

Merged
bors merged 1 commit into
rust-lang:masterfrom
RalfJung:static-assert
Oct 12, 2018
Merged

add a macro for static (compile-time) assertions#54958
bors merged 1 commit into
rust-lang:masterfrom
RalfJung:static-assert

Conversation

@RalfJung

Copy link
Copy Markdown
Member

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 10, 2018
@oli-obk

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Oct 10, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit a332387 has been approved by oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 10, 2018
@leonardo-m

Copy link
Copy Markdown

Is this macro usable from the Prelude too? Something similar is useful in user code too.

@oli-obk

Copy link
Copy Markdown
Contributor

No, this is not meant for users. Users will get first class support for assert! and friends.

@RalfJung

Copy link
Copy Markdown
MemberAuthor

@oli-obk you'd likely still want such a macro... I doubt assert!(foo); is going to work in item position?

Having to give the assertion a name though is rather ugly. Fine for internal use, not so for libstd.

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Oct 11, 2018
add a macro for static (compile-time) assertions
Cc @oli-obk
kennytm added a commit to kennytm/rust that referenced this pull request Oct 12, 2018
add a macro for static (compile-time) assertions
Cc @oli-obk
@kennytmkennytm mentioned this pull request Oct 12, 2018
bors added a commit that referenced this pull request Oct 12, 2018
Rollup of 16 pull requests
Successful merges:
- #54755 (Documents reference equality by address (#54197))
- #54811 (During rustc bootstrap, make default for `optimize` independent of `debug`)
- #54825 (NLL says "borrowed content" instead of more precise "dereference of raw pointer")
- #54860 (Add doc comments about safest way to initialize a vector of zeros)
- #54869 (Fix mobile docs)
- #54891 (Fix tracking issue for Once::is_completed)
- #54913 (doc fix: it's auto traits that make for automatic implementations)
- #54920 (Fix handling of #[must_use] on unit and uninhabited types)
- #54932 (A handful of random string-related improvements)
- #54936 (impl Eq+Hash for TyLayout)
- #54950 (std: Synchronize global allocator on wasm32)
- #54956 ("(using ..." doesn't have the matching ")")
- #54958 (add a macro for static (compile-time) assertions)
- #54967 (Remove incorrect span for second label inner macro invocation)
- #54983 (Fix slice's benchmarks)
- #54989 (Fix spelling in the documentation to htmldocck.py)
Failed merges:
r? @ghost
@bors
bors merged commit a332387 into rust-lang:masterOct 12, 2018
@RalfJung
RalfJung deleted the static-assert branch November 9, 2018 15:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@RalfJung@rust-highfive@oli-obk@bors@leonardo-m@matthewjasper