Skip to content

Add option to run all tests, again - #55053

Merged
bors merged 2 commits into
rust-lang:masterfrom
Emerentius:test_all_again
Oct 27, 2018
Merged

Add option to run all tests, again#55053
bors merged 2 commits into
rust-lang:masterfrom
Emerentius:test_all_again

Conversation

@Emerentius

@EmerentiusEmerentius commented Oct 13, 2018

Copy link
Copy Markdown
Contributor

This is a repeat of #53527, which had to be reverted to land #54116. It will break clippy until compiletest-rs can be updated and I believe we're closing on a new release date, so this may need to be delayed again until after 1.30 is out (?)

Closes#50363 again

@Emerentius
refactor filter_tests
68b5964
same behaviour, just shorter
@Emerentius
add option to libtest to run all tests
420541b
flag name is --include-ignored
requires -Zunstable-options for now
@rust-highfive

rust-highfive commented Oct 13, 2018

Copy link
Copy Markdown
Contributor

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 13, 2018
@kennytm

kennytm commented Oct 14, 2018

Copy link
Copy Markdown
Member

r? @eddyb

@rust-highfiverust-highfive assigned eddyb and unassigned kennytmOct 14, 2018
@TimNN

TimNN commented Oct 23, 2018

Copy link
Copy Markdown
Contributor

Ping from triage! Given that @eddyb is pretty busy right now, maybe

r? @alexcrichton

Or maybe cc @rust-lang/dev-tools? Not quite sure what the most appropriate team would be.

@alexcrichton

alexcrichton commented Oct 27, 2018

Copy link
Copy Markdown
Member

I'm not really privvy to many details here, but it looks like #53527 landed but was reverted in #54116 due to... I guess various forms of breakage? In any case 1.31 has branched and we should have plenty of runway to figure out breakage now. In light of that seeing how this is the same patch as before, I'll...

@bors: r+

@bors

bors commented Oct 27, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 420541b has been approved by alexcrichton

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2018
@bors

bors commented Oct 27, 2018

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 420541b with merge 42c11de...

bors added a commit that referenced this pull request Oct 27, 2018
@bors
Auto merge of#55053- Emerentius:test_all_again, r=alexcrichton
42c11de
Add option to run all tests, again
This is a repeat of #53527, which had to be reverted to land #54116. It will break clippy until `compiletest-rs` can be updated and I believe we're closing on a new release date, so this may need to be delayed again until after 1.30 is out (?)
Closes#50363 again
@bors

bors commented Oct 27, 2018

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 42c11de to master...

@bors
bors merged commit 420541b into rust-lang:masterOct 27, 2018
@rust-highfive

rust-highfive commented Oct 27, 2018

Copy link
Copy Markdown
Contributor

📣 Toolstate changed by #55053!

Tested on commit 42c11de.
Direct link to PR: #55053

💔 clippy-driver on windows: test-pass → test-fail (cc @Manishearth@llogiq@mcarton@oli-obk, @rust-lang/infra).
💔 clippy-driver on linux: test-pass → test-fail (cc @Manishearth@llogiq@mcarton@oli-obk, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Oct 27, 2018
@rust-highfive
📣 Toolstate changed byrust-lang/rust#55053!
d14a9ea
Tested on commit rust-lang/rust@42c11de.
Direct link to PR: <rust-lang/rust#55053>
💔 clippy-driver on windows: test-pass → test-fail (cc @Manishearth@llogiq@mcarton@oli-obk, @rust-lang/infra).
💔 clippy-driver on linux: test-pass → test-fail (cc @Manishearth@llogiq@mcarton@oli-obk, @rust-lang/infra).
phansch added a commit to phansch/compiletest-rs that referenced this pull request Oct 28, 2018
@phansch
Fix nightly build failure (Added RunIgnored)
2ebb521
The failure was caused by rust-lang/rust#55053
@phanschphansch mentioned this pull request Oct 28, 2018
Merged
@kennytmkennytm mentioned this pull request Oct 29, 2018
Merged
@phanschphansch mentioned this pull request Dec 13, 2018
Merged
@mati865mati865 mentioned this pull request Jan 17, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichtonalexcrichton

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Emerentius@rust-highfive@kennytm@TimNN@alexcrichton@bors@eddyb