[beta]: Prepare the 1.31.0 beta release by alexcrichton · Pull Request #55405 · rust-lang/rust

alexcrichton · 2018-10-27T06:27:20Z

Update to Cargo's branched 1.31.0 branch
Update the channel to beta

Rolled up beta-accepted PRs:

Remove cargo new --edition from release notes. #55362: Remove cargo new --edition from release notes.
Fix link to macros chapter #55325: Fix link to macros chapter
Remove redundant clone (2) #55358: Remove redundant clone (2)
Shrink Statement. #55346: Shrink Statement.
Handle bindings in substructure of patterns with type ascriptions #55274: Handle bindings in substructure of patterns with type ascriptions
Partial implementation of uniform paths 2.0 to land before beta #55297: Partial implementation of uniform paths 2.0 to land before beta
Fix ordering of nested modules in non-mod.rs mods #55192: Fix ordering of nested modules in non-mod.rs mods
path suggestions in Rust 2018 should point out the change in semantics #55185: path suggestions in Rust 2018 should point out the change in semantics
back out bogus Ok-wrapping suggestion on ? arm type mismatch #55423: back out bogus Ok-wrapping suggestion on ? arm type mismatch

Note that this does not update the bootstrap compiler due to #55404

rust-highfive · 2018-10-27T06:27:31Z

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2018-10-27T06:27:32Z

⚠️Warning⚠️

These commits modify submodules.

alexcrichton · 2018-10-27T06:27:41Z

r? @Mark-Simulacrum

alexcrichton · 2018-10-27T06:28:04Z

@Mark-Simulacrum you may also know best how to triage/tag #55404

Mark-Simulacrum · 2018-10-28T22:32:51Z

@bors r+ p=5

bors · 2018-10-28T22:32:52Z

📌 Commit c0230fe1fbec3f4e91635dc9eafb2a727a568bff has been approved by Mark-Simulacrum

emilyalbini · 2018-10-28T22:34:05Z

@bors r-

emilyalbini · 2018-10-28T22:43:10Z

Rolled up beta-accepted PRs inside this one.

@bors r=Mark-Simulacrum p=5

bors · 2018-10-28T22:43:11Z

📌 Commit 7d9a81406de8591a96091eb2246119a8ed1e50af has been approved by Mark-Simulacrum

bors · 2018-10-29T00:34:13Z

⌛ Testing commit 7d9a81406de8591a96091eb2246119a8ed1e50af with merge 8847a29102455ede37bc1d63c2b786a115af2a50...

bors · 2018-10-29T01:45:35Z

💔 Test failed - status-appveyor

Mark-Simulacrum · 2018-10-29T02:10:47Z

Cc @nrc - looks like we might need an RLS update.. though this might be because of the lack of bootstrap compiler update...

@aturon @steveklabnik This probably means we can't get RC2 out tomorrow - it'll take probably till Tuesday at the earliest

nrc · 2018-10-29T02:21:26Z

looks like we might need an RLS update

I'm not sure where rustc and the RLS are coming from. RLS is broken with current nightly (will try and fix today, but realistically tomorrow). However, I believe the RLS that should have been uplifted to beta worked with the rustc at that time.

Mark-Simulacrum · 2018-10-29T02:34:15Z

Yes - I'm not sure how this managed to break. I probably won't get a chance to take a look until tomorrow night unfortunately...

bors · 2018-10-29T15:48:26Z

⌛ Trying commit 7c81496 with merge 7ee121b8bbe37a8d2d8049cfa1243ecbcebbffc9...

Mark-Simulacrum · 2018-10-29T16:31:20Z

@petrochenkov FWIW I think there was a bit of miscommunication with beta promotion timeline.

bors · 2018-10-29T18:33:29Z

☀️ Test successful - status-travis
State: approved=pietroalbini try=True

bors · 2018-10-29T18:33:40Z

⌛ Testing commit 7c81496 with merge a8b53646eee16bd1cb56df53c5fb0ab2b475c37c...

bors · 2018-10-29T18:33:56Z

💔 Test failed - status-appveyor

rust-highfive · 2018-10-29T18:36:08Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

Resolving deltas: 100% (8545/8545), done.
travis_time:end:2ed97afa:start=1540838114757705533,finish=1540838121340675308,duration=6582969775
$ cd rust-lang/rust
$ git checkout -qf a8b53646eee16bd1cb56df53c5fb0ab2b475c37c
fatal: reference is not a tree: a8b53646eee16bd1cb56df53c5fb0ab2b475c37c
The command "git checkout -qf a8b53646eee16bd1cb56df53c5fb0ab2b475c37c" failed and exited with 128 during .
Your build has been stopped.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

emilyalbini · 2018-10-29T18:39:53Z

What is happening with bors today :/

emilyalbini · 2018-10-29T18:40:14Z

@bors r+ p=1000

bors · 2018-10-29T18:40:15Z

💡 This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
There's another pull request that is currently being tested, blocking this pull request: Update compiler-builtins submodule #55303

bors · 2018-10-29T18:40:16Z

📌 Commit 7c81496 has been approved by pietroalbini

bors · 2018-10-29T18:41:15Z

⌛ Testing commit 7c81496 with merge 2824a67...

[beta]: Prepare the 1.31.0 beta release * Update to Cargo's branched 1.31.0 branch * Update the channel to `beta` Rolled up beta-accepted PRs: * #55362: Remove `cargo new --edition` from release notes. * #55325: Fix link to macros chapter * #55358: Remove redundant clone (2) * #55346: Shrink `Statement`. * #55274: Handle bindings in substructure of patterns with type ascriptions * #55297: Partial implementation of uniform paths 2.0 to land before beta * #55192: Fix ordering of nested modules in non-mod.rs mods * #55185: path suggestions in Rust 2018 should point out the change in semantics * #55423: back out bogus `Ok`-wrapping suggestion on `?` arm type mismatch Note that **this does not update the bootstrap compiler** due to #55404

bors · 2018-10-29T21:25:05Z

☀️ Test successful - status-appveyor, status-travis
Approved by: pietroalbini
Pushing 2824a67 to beta...

petrochenkov · 2018-10-29T22:17:05Z

@Mark-Simulacrum
Wait a second, #54145 is not in beta, how is that even possible?
Beta was branched off Oct 25, 2018, 4 days ago?!
That's even before this comment #55297 (comment).

That's not a bit of miscommunication, that's a total failure of communication.
All that stuff was explicitly targeting beta and worked on with that assumption.

petrochenkov · 2018-10-29T22:21:16Z

I see now what's the source of the cherry-picking issues - #54145 was supposed to be on beta, and #55297 and #55185 were supposed to go on top of it, but as it turns out #54145 is not in fact on beta.

emilyalbini · 2018-10-29T22:25:33Z

@petrochenkov beta was branched off today with the last PR before #54145 landed, since that was the one breaking RLS. There are more details in #55405 (comment).

petrochenkov · 2018-10-29T22:33:33Z

@pietroalbini
Oh. I see.
If #54145 is indeed "un-betable", then this PR probably did the best it could.
I guess I'll have to continue work on #55297 directly on top of beta in this case.
Thanks for the clarification.

emilyalbini · 2018-10-29T22:43:08Z

@petrochenkov I think we can backport #54145 once RLS is fixed (along with the RLS fix), so I wouldn't worry about working on top of beta. @Mark-Simulacrum can confirm that though.

This follows up rust-lang#55405 with an update to the bootstrap compiler now that a new version of `chalk-engine` is published. Closesrust-lang#55404

rust-highfive assigned nikomatsakis Oct 27, 2018

alexcrichton changed the base branch from master to betaOctober 27, 2018 06:27

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 27, 2018

rust-highfive assigned Mark-Simulacrum and unassigned nikomatsakis Oct 27, 2018

alexcrichton changed the title ~~[beta]: Prepare the 1.31.0 stable release~~[beta]: Prepare the 1.31.0 beta releaseOct 27, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2018

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 28, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 28, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 29, 2018

kennytm added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Oct 29, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 29, 2018

emilyalbini closed this Oct 29, 2018

emilyalbini reopened this Oct 29, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2018

bors merged commit 7c81496 into rust-lang:betaOct 29, 2018

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Oct 31, 2018
[beta] Update the boostrap compiler
dadaf12
This follows up rust-lang#55405 with an update to the bootstrap compiler now that a new version of `chalk-engine` is published. Closesrust-lang#55404

alexcrichton mentioned this pull request Oct 31, 2018
[beta] Update the boostrap compiler #55550
Merged

Uh oh!

Uh oh!

Conversation

alexcrichton commented Oct 27, 2018• edited by emilyalbini Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Oct 27, 2018

Uh oh!

rust-highfive commented Oct 27, 2018

Uh oh!

alexcrichton commented Oct 27, 2018

Uh oh!

alexcrichton commented Oct 27, 2018

Uh oh!

Mark-Simulacrum commented Oct 28, 2018

Uh oh!

bors commented Oct 28, 2018

Uh oh!

emilyalbini commented Oct 28, 2018

Uh oh!

emilyalbini commented Oct 28, 2018

Uh oh!

bors commented Oct 28, 2018

Uh oh!

bors commented Oct 29, 2018

Uh oh!

bors commented Oct 29, 2018

Uh oh!

Mark-Simulacrum commented Oct 29, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nrc commented Oct 29, 2018

Uh oh!

Mark-Simulacrum commented Oct 29, 2018

Uh oh!

bors commented Oct 29, 2018

Uh oh!

Mark-Simulacrum commented Oct 29, 2018

Uh oh!

bors commented Oct 29, 2018

Uh oh!

bors commented Oct 29, 2018

Uh oh!

bors commented Oct 29, 2018

Uh oh!

rust-highfive commented Oct 29, 2018

Uh oh!

emilyalbini commented Oct 29, 2018

Uh oh!

emilyalbini commented Oct 29, 2018

Uh oh!

bors commented Oct 29, 2018

Uh oh!

bors commented Oct 29, 2018

Uh oh!

bors commented Oct 29, 2018

Uh oh!

bors commented Oct 29, 2018

Uh oh!

petrochenkov commented Oct 29, 2018

Uh oh!

petrochenkov commented Oct 29, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

emilyalbini commented Oct 29, 2018

Uh oh!

petrochenkov commented Oct 29, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

emilyalbini commented Oct 29, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

alexcrichton commented Oct 27, 2018•
edited by emilyalbini
Loading

Mark-Simulacrum commented Oct 29, 2018•
edited
Loading

petrochenkov commented Oct 29, 2018•
edited
Loading

petrochenkov commented Oct 29, 2018•
edited
Loading