Uh oh!
There was an error while loading. Please reload this page.
rustbuild: use configured linker to build bootstrap - #55378
Merged
Conversation
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
rust-highfive
commented
Oct 26, 2018
Contributor
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
petrochenkov
commented
Oct 26, 2018
Contributor
@bors r+ rollup Thanks! |
bors
commented
Oct 26, 2018
Collaborator
📌 Commit bc87c71 has been approved by |
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Oct 26, 2018
…enkov rustbuild: use configured linker to build boostrap Currently, bootstrap uses it to compile everything, but x.py wasn't using it yet to build bootstrap itself. This fixes the build for systems where the linker isn't called `cc`.
bors added a commit
that referenced
this pull request
Oct 26, 2018
Rollup of 21 pull requests Successful merges: - #54816 (Don't try to promote already promoted out temporaries) - #54824 (Cleanup rustdoc tests with `@!has` and `@!matches`) - #54921 (Add line numbers option to rustdoc) - #55167 (Add a "cheap" mode for `compute_missing_ctors`.) - #55258 (Fix Rustdoc ICE when checking blanket impls) - #55264 (Compile the libstd we distribute with -Ccodegen-unit=1) - #55271 (Unimplement ExactSizeIterator for MIR traversing iterators) - #55292 (Macro diagnostics tweaks) - #55298 (Point at macro definition when no rules expect token) - #55301 (List allowed tokens after macro fragments) - #55302 (Extend the impl_stable_hash_for! macro for miri.) - #55325 (Fix link to macros chapter) - #55343 (rustbuild: fix remap-debuginfo when building a release) - #55346 (Shrink `Statement`.) - #55358 (Remove redundant clone (2)) - #55370 (Update mailmap for estebank) - #55375 (Typo fixes in configure_cmake comments) - #55378 (rustbuild: use configured linker to build boostrap) - #55379 (validity: assert that unions are non-empty) - #55383 (Use `SmallVec` for the queue in `coerce_unsized`.) - #55391 (bootstrap: clean up a few clippy findings)
Keruspe
commented
Oct 29, 2018
ContributorAuthor
If the beta get based to an older commit, could this be nominated? |
Keruspe
commented
Nov 3, 2018
ContributorAuthor
@petrochenkov The beta has indeed finally been based on an older commit, can this be beta-nominated? |
petrochenkov
commented
Nov 3, 2018
Contributor
Ok, this is a tiny change, beta-nominating. |
pnkfelix
commented
Nov 8, 2018
Contributor
beta-accepting. (I assume that if this causes problems, we'll find out in very short order...) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, bootstrap uses it to compile everything, but x.py wasn't using it yet to build bootstrap itself.
This fixes the build for systems where the linker isn't called
cc.