Skip to content

path suggestions in Rust 2018 should point out the change in semantics - #55185

Merged
bors merged 1 commit into
rust-lang:masterfrom
davidtwco:issue-55130
Oct 28, 2018
Merged

path suggestions in Rust 2018 should point out the change in semantics #55185
bors merged 1 commit into
rust-lang:masterfrom
davidtwco:issue-55130

Conversation

@davidtwco

@davidtwcodavidtwco commented Oct 18, 2018

Copy link
Copy Markdown
Member

Fixes#55130.

This commit extends existing path suggestions to link to documentation
on the changed semantics of use in Rust 2018.

r? @nikomatsakis

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2018
davidtwco
davidtwco commented Oct 18, 2018
View reviewed changes
Comment threadsrc/librustc_resolve/error_reporting.rs Outdated
Comment threadsrc/librustc_resolve/resolve_imports.rs Outdated
@tmandrytmandry mentioned this pull request Oct 18, 2018
Closed
@bors

This comment has been minimized.

Sign in to view
@davidtwco
davidtwcoforce-pushed the issue-55130 branch 3 times, most recently from 2a5dc5e to d2baf92CompareOctober 22, 2018 19:59
@nikomatsakis

nikomatsakis commented Oct 23, 2018

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Oct 23, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit d2baf92 has been approved by nikomatsakis

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2018
emilyalbini added a commit to emilyalbini/rust that referenced this pull request Oct 23, 2018
@emilyalbini
Rollup merge ofrust-lang#55185- davidtwco:issue-55130, r=nikomatsakis
a083070
path suggestions in Rust 2018 should point out the change in semantics
Fixesrust-lang#55130.
This commit extends existing path suggestions to link to documentation
on the changed semantics of `use` in Rust 2018.
r? @nikomatsakis
@emilyalbiniemilyalbini mentioned this pull request Oct 23, 2018
Closed
@bors

This comment has been minimized.

Sign in to view
@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 25, 2018
@davidtwco

davidtwco commented Oct 25, 2018

Copy link
Copy Markdown
MemberAuthor

@bors r=nikomatsakis

@bors

bors commented Oct 25, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit ad0ac6aa1a290c59e4a189a5a0b002ed0d5d3c07 has been approved by nikomatsakis

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 25, 2018
@bors

This comment has been minimized.

Sign in to view
@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 26, 2018
@davidtwco

davidtwco commented Oct 26, 2018

Copy link
Copy Markdown
MemberAuthor

@bors r=nikomatsakis

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 26, 2018
@Mark-SimulacrumMark-Simulacrum added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 27, 2018
@Mark-Simulacrum

Mark-Simulacrum commented Oct 27, 2018

Copy link
Copy Markdown
Member

beta-nominating for RC2 inclusion; I think this would be nice to have though not critical

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Oct 27, 2018
@Mark-Simulacrum
Rollup merge ofrust-lang#55185- davidtwco:issue-55130, r=nikomatsakis
be00065
path suggestions in Rust 2018 should point out the change in semantics
Fixesrust-lang#55130.
This commit extends existing path suggestions to link to documentation
on the changed semantics of `use` in Rust 2018.
r? @nikomatsakis
@Mark-SimulacrumMark-Simulacrum mentioned this pull request Oct 27, 2018
Closed
@bors

This comment has been minimized.

Sign in to view
@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 28, 2018
@bors

This comment has been minimized.

Sign in to view
@davidtwco
Add note linking to Rust 2018 path semantics docs.
0d06b8c
This commit extends existing path suggestions to link to documentation
on the changed semantics of `use` in Rust 2018.
@davidtwco

davidtwco commented Oct 28, 2018

Copy link
Copy Markdown
MemberAuthor

@bors r=nikomatsakis

@bors

bors commented Oct 28, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 0d06b8c has been approved by nikomatsakis

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 28, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Oct 28, 2018
@kennytm
Rollup merge ofrust-lang#55185- davidtwco:issue-55130, r=nikomatsakis
aaa20c6
path suggestions in Rust 2018 should point out the change in semantics
Fixesrust-lang#55130.
This commit extends existing path suggestions to link to documentation
on the changed semantics of `use` in Rust 2018.
@kennytmkennytm mentioned this pull request Oct 28, 2018
Merged
bors added a commit that referenced this pull request Oct 28, 2018
@bors
Auto merge of#55433- kennytm:rollup, r=kennytm
d492c67
Rollup of 11 pull requests
Successful merges:
- #55148 (Implement FromStr for PathBuf)
- #55185 (path suggestions in Rust 2018 should point out the change in semantics)
- #55191 (Fix sub-variant doc display)
- #55199 (Impl items have generics)
- #55244 (Don't rerun MIR passes when inlining)
- #55252 (Add MaybeUninit::new)
- #55257 (Allow extern statics with an extern type)
- #55389 (Remove unnecessary mut in iterator.find_map documentation example, R…)
- #55406 (Update string.rs)
- #55412 (Fix an ICE in the min_const_fn analysis)
- #55421 (Add ManuallyDrop::take)
@bors
bors merged commit 0d06b8c into rust-lang:masterOct 28, 2018
@davidtwco
davidtwco deleted the issue-55130 branch October 28, 2018 19:03
@Mark-SimulacrumMark-Simulacrum added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 28, 2018
@alexcrichtonalexcrichton mentioned this pull request Oct 28, 2018
Merged
@emilyalbiniemilyalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 28, 2018
bors added a commit that referenced this pull request Oct 29, 2018
@bors
Auto merge of#55405- alexcrichton:beta-next, r=pietroalbini
2824a67
[beta]: Prepare the 1.31.0 beta release
* Update to Cargo's branched 1.31.0 branch
* Update the channel to `beta`
Rolled up beta-accepted PRs:
* #55362: Remove `cargo new --edition` from release notes.
* #55325: Fix link to macros chapter
* #55358: Remove redundant clone (2)
* #55346: Shrink `Statement`.
* #55274: Handle bindings in substructure of patterns with type ascriptions
* #55297: Partial implementation of uniform paths 2.0 to land before beta
* #55192: Fix ordering of nested modules in non-mod.rs mods
* #55185: path suggestions in Rust 2018 should point out the change in semantics
* #55423: back out bogus `Ok`-wrapping suggestion on `?` arm type mismatch
Note that **this does not update the bootstrap compiler** due to #55404
RalfJung
RalfJung reviewed Nov 1, 2018
View reviewed changes
Comment threadsrc/librustc_resolve/error_reporting.rs
Some(
"`use` statements changed in Rust 2018; read more at \
<https://doc.rust-lang.org/edition-guide/rust-2018/module-system/path-\
clarity.html>".to_string()

@RalfJungRalfJungNov 1, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am getting a 404 not found when visiting https://doc.rust-lang.org/edition-guide/rust-2018/module-system/path-clarity.html

@steveklabniksteveklabnikNov 1, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that URL isn't live yet, but will be as of the next release

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RalfJungRalfJungRalfJung left review comments
@nikomatsakisnikomatsakisnikomatsakis approved these changes
+2 more reviewers
@steveklabniksteveklabniksteveklabnik left review comments
@pnkfelixpnkfelixpnkfelix left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@nikomatsakisnikomatsakis

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@davidtwco@bors@nikomatsakis@Mark-Simulacrum@steveklabnik@pnkfelix@RalfJung@emilyalbini@rust-highfive