Uh oh!
There was an error while loading. Please reload this page.
Fix ICE in return_type_impl_trait - #55800
Merged
Merged
Conversation
rust-highfive
commented
Nov 8, 2018
Contributor
r? @oli-obk (rust_highfive has picked a reviewer for you, use r? to override) |
type_of_def_id() when called from return_type_impl_traitreturn_type_impl_traitestebank
commented
Nov 8, 2018
ContributorAuthor
Nominating for beta backport as it fixes a stable-to-stable regression ICE. |
estebank
commented
Nov 8, 2018
Uh oh!
There was an error while loading. Please reload this page.
oli-obk
commented
Nov 9, 2018
Contributor
@bors r+ |
bors
commented
Nov 9, 2018
Collaborator
📌 Commit a90240d has been approved by |
emilyalbini added a commit
to emilyalbini/rust
that referenced
this pull request
Nov 10, 2018
…r=oli-obk Fix ICE in `return_type_impl_trait` Fixrust-lang#55796.
bors added a commit
that referenced
this pull request
Nov 11, 2018
Rollup of 17 pull requests Successful merges: - #55630 (resolve: Filter away macro prelude in modules with `#[no_implicit_prelude]` on 2018 edition) - #55687 (Take supertraits into account when calculating associated types) - #55745 (Convert `outlives_components`' return value to a `SmallVec` outparam.) - #55764 (Fix Rc/Arc allocation layout) - #55792 (Prevent ICE in const-prop array oob check) - #55799 (Removed unneeded instance of `// revisions` from a lint test) - #55800 (Fix ICE in `return_type_impl_trait`) - #55801 (NLL: Update box insensitivity test) - #55802 (Don't inline virtual calls (take 2)) - #55816 (Use `SmallVec` to avoid allocations in `from_decimal_string`.) - #55819 (Typecheck patterns of all match arms first, so we get types for bindings) - #55822 (ICE with #![feature(nll)] and elided lifetimes) - #55828 (Add missing `rustc_promotable` attribute to unsigned `min_value` and `max_value`) - #55839 (Fix docstring spelling mistakes) - #55844 (Fix documentation typos.) - #55845 (Set BINARYEN_TRAP_MODE=clamp) - #55856 (rustdoc: refactor: move all static-file include!s into a single module)
nagisa
commented
Nov 15, 2018
Member
Has been approved for a backport. The fix does not look ideal, but we’ll have to live with it one way or another until the fix is improved. |
bors added a commit
that referenced
this pull request
Nov 15, 2018
[beta] Rollup backports Merged and approved: * #55947: xLTO: Don't pass --plugin-opt=thin to LLD. That's not supported anymore. * #55852: Rewrite `...` as `..=` as a `MachineApplicable` 2018 idiom lint * #55800: Fix ICE in `return_type_impl_trait` * #55630: resolve: Filter away macro prelude in modules with `#[no_implicit_prelude]` on 2018 edition r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#55796.