Uh oh!
There was an error while loading. Please reload this page.
xLTO: Don't pass --plugin-opt=thin to LLD. That's not supported anymore. - #55947
Merged
Conversation
rust-highfive
commented
Nov 14, 2018
Contributor
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
michaelwoerister
commented
Nov 14, 2018
MemberAuthor
Mark-Simulacrum
commented
Nov 14, 2018
Member
@bors r+ p=5 Does this need a beta backport as well? |
bors
commented
Nov 14, 2018
Collaborator
📌 Commit 4cfc979 has been approved by |
michaelwoerister
commented
Nov 14, 2018
MemberAuthor
re: beta, I'll have to look into that. If beta uses an LLVM version the LLD of which also doesn't accept the flag, then yes. |
michaelwoerister
commented
Nov 14, 2018
MemberAuthor
So it looks like the LLD version coming with beta doesn't accept the option either. Beta-nominating. |
bors
commented
Nov 14, 2018
Collaborator
bors added a commit
that referenced
this pull request
Nov 14, 2018
…lacrum xLTO: Don't pass --plugin-opt=thin to LLD. That's not supported anymore. It seems that `-plugin-opt=thin` is not needed anymore when invoking LLD for ThinLTO. Unfortunately, still passing the option makes LLD crash instead of giving a deprecation warning or something.
bors
commented
Nov 14, 2018
Collaborator
☀️ Test successful - status-appveyor, status-travis |
rust-highfive
commented
Nov 14, 2018
Contributor
rust-highfive added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Nov 14, 2018
Tested on commit rust-lang/rust@6f93e93. Direct link to PR: <rust-lang/rust#55947> 🎉 rls on linux: test-fail → test-pass (cc @nrc@Xanewok, @rust-lang/infra).
nagisa
commented
Nov 15, 2018
Member
Accepted for beta. The patch is low risk and since the feature(s) in question are unstable and have little usage out there make such backport even less dangerous (although that goes the other way as well against the backport). The T-compiler has voted overwhelmingly for a backport. |
bors added a commit
that referenced
this pull request
Nov 15, 2018
[beta] Rollup backports Merged and approved: * #55947: xLTO: Don't pass --plugin-opt=thin to LLD. That's not supported anymore. * #55852: Rewrite `...` as `..=` as a `MachineApplicable` 2018 idiom lint * #55800: Fix ICE in `return_type_impl_trait` * #55630: resolve: Filter away macro prelude in modules with `#[no_implicit_prelude]` on 2018 edition r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that
-plugin-opt=thinis not needed anymore when invoking LLD for ThinLTO. Unfortunately, still passing the option makes LLD crash instead of giving a deprecation warning or something.