Skip to content

global allocators: add a few comments - #55889

Merged
bors merged 1 commit into
rust-lang:masterfrom
RalfJung:global-alloc
Nov 14, 2018
Merged

global allocators: add a few comments#55889
bors merged 1 commit into
rust-lang:masterfrom
RalfJung:global-alloc

Conversation

@RalfJung

Copy link
Copy Markdown
Member

These comments answer some questions that came up when I tried to understand how the control flow works for the global allocator, Global and System.

r? @alexcrichton

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 12, 2018
@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+ rollup

@bors

bors commented Nov 12, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 075983c has been approved by alexcrichton

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2018
emilyalbini added a commit to emilyalbini/rust that referenced this pull request Nov 12, 2018
global allocators: add a few comments
These comments answer some questions that came up when I tried to understand how the control flow works for the global allocator, `Global` and `System`.
r? @alexcrichton
@kennytmkennytm mentioned this pull request Nov 13, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Nov 13, 2018
global allocators: add a few comments
These comments answer some questions that came up when I tried to understand how the control flow works for the global allocator, `Global` and `System`.
r? @alexcrichton
bors added a commit that referenced this pull request Nov 13, 2018
Rollup of 20 pull requests
Successful merges:
- #55136 (Remove short doc where it starts with a codeblock)
- #55711 (Format BtreeMap::range_mut example)
- #55722 (impl_stable_hash_for: support enums and tuple structs with generic parameters)
- #55754 (Avoid converting bytes to UTF-8 strings to print, just pass bytes to stdout/err)
- #55804 (rustdoc: don't inline `pub use some_crate` unless directly asked to)
- #55805 (Move `static_assert!` into librustc_data_structures)
- #55837 (Make PhantomData #[structural_match])
- #55840 (Fix TLS errors when downloading stage0)
- #55843 (add FromIterator<A> to Box<[A]>)
- #55858 (Small fixes on code blocks in rustdoc)
- #55863 (Fix a typo in std::panic)
- #55870 (Fix typos.)
- #55874 (string: Add documentation for `From` impls)
- #55879 (save-analysis: Don't panic for macro-generated use globs)
- #55882 (Reference count `crate_inherent_impls`s return value.)
- #55888 (miri: for uniformity, also move memory_deallocated to AllocationExtra)
- #55889 (global allocators: add a few comments)
- #55896 (Document optimizations enabled by FusedIterator)
- #55905 (Change `Lit::short_name` to `Lit::literal_name`.)
- #55908 (Fix their/there grammar nit)
@bors
bors merged commit 075983c into rust-lang:masterNov 14, 2018
@RalfJung
RalfJung deleted the global-alloc branch November 30, 2018 08:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@RalfJung@alexcrichton@bors@rust-highfive