Rollup of 20 pull requests

[kennytm]

Successful merges:

• Remove short doc where it starts with a codeblock #55136 (Remove short doc where it starts with a codeblock)
• Format BtreeMap::range_mut example #55711 (Format BtreeMap::range_mut example)
• impl_stable_hash_for: support enums and tuple structs with generic parameters #55722 (impl_stable_hash_for: support enums and tuple structs with generic parameters)
• Avoid converting bytes to UTF-8 strings to print, just pass bytes to stdout/err #55754 (Avoid converting bytes to UTF-8 strings to print, just pass bytes to stdout/err)
• rustdoc: don't inline pub use some_crate unless directly asked to #55804 (rustdoc: don't inline pub use some_crate unless directly asked to)
• Move static_assert! into librustc_data_structures #55805 (Move static_assert! into librustc_data_structures)
• Make PhantomData #[structural_match] #55837 (Make PhantomData #[structural_match])
• Fix TLS errors when downloading stage0 #55840 (Fix TLS errors when downloading stage0)
• add FromIterator<A> to Box<[A]> #55843 (add FromIterator to Box<[A]>)
• Small fixes on code blocks in rustdoc #55858 (Small fixes on code blocks in rustdoc)
• Fix a typo in std::panic #55863 (Fix a typo in std::panic)
• Fix typos. #55870 (Fix typos.)
• string: Add documentation for From impls #55874 (string: Add documentation for From impls)
• save-analysis: Don't panic for macro-generated use globs #55879 (save-analysis: Don't panic for macro-generated use globs)
• Reference count crate_inherent_implss return value. #55882 (Reference count crate_inherent_implss return value.)
• miri: for uniformity, also move memory_deallocated to AllocationExtra #55888 (miri: for uniformity, also move memory_deallocated to AllocationExtra)
• global allocators: add a few comments #55889 (global allocators: add a few comments)
• Document optimizations enabled by FusedIterator #55896 (Document optimizations enabled by FusedIterator)
• Change Lit::short_name to Lit::literal_name. #55905 (Change Lit::short_name to Lit::literal_name.)
• Fix their/there grammar nit #55908 (Fix their/there grammar nit)

[kennytm]

@bors r+ p=21

[bors]

⌛ Testing commit 7921572 with merge 92af91bb950f27ca841d7ec3bc67d3ca2fe6be68...

[bors]

💔 Test failed - status-travis

[rust-highfive]

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:00:07] Cloning into '/home/travis/build/rust-lang/rust/src/tools/rustfmt'...
[00:00:07] Cloning into '/home/travis/build/rust-lang/rust/src/tools/clippy'...
[00:00:07] Cloning into '/home/travis/build/rust-lang/rust/src/tools/cargo'...
[00:00:07] Cloning into '/home/travis/build/rust-lang/rust/src/tools/clang'...
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[kennytm]

@bors retry

[bors]

⌛ Testing commit 7921572 with merge 3cb42d725d089ed1e4a53f75e25532ea7a9d38b5...

[bors]

💥 Test timed out

[kennytm]

@bors retry ಠ_ಠ

[bors]

⌛ Testing commit 7921572 with merge f1d6183...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing f1d6183 to master...

[rust-highfive]

📣 Toolstate changed by #55912!

Tested on commit f1d6183.
Direct link to PR: #55912

💔 rls on windows: test-pass → test-fail (cc @nrc@Xanewok, @rust-lang/infra).

[nrc]

I can't see an error in the logs :-s

[kennytm]

@nrc You've got a spurious error in the RLS test.

Details

[02:11:56] ---- cmd_changing_workspace_lib_retains_bin_diagnostics stdout ----
[02:11:56] thread 'cmd_changing_workspace_lib_retains_bin_diagnostics' panicked at 'assertion failed: `(left == right)`
[02:11:56] left: `String("E0425")`,
[02:11:56] right: `"unused_variables"`', tools\rls\tests\tests.rs:408:5
[02:11:56] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[02:11:56] ---rls-stdout---
[02:11:56] Content-Length: 605
[02:11:56] [02:11:56] {"jsonrpc":"2.0","id":0,"result":{"capabilities":{"textDocumentSync":2,"hoverProvider":true,"completionProvider":{"resolveProvider":true,"triggerCharacters":[".",":"]},"definitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"workspaceSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{"resolveProvider":false},"documentFormattingProvider":true,"documentRangeFormattingProvider":false,"renameProvider":true,"executeCommandProvider":{"commands":["rls.applySuggestion-2560","rls.deglobImports-2560"]}}}}Content-Length: 92
[02:11:56] [02:11:56] {"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_1","title":"Building"}}Content-Length: 112
[02:11:56] [02:11:56] {"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_1","message":"library","title":"Building"}}Content-Length: 122
[02:11:56] [02:11:56] {"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_1","message":"library cfg(test)","title":"Building"}}Content-Length: 111
[02:11:56] [02:11:56] {"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_1","message":"binary","title":"Building"}}Content-Length: 121
[02:11:56] [02:11:56] {"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_1","message":"binary cfg(test)","title":"Building"}}Content-Length: 104
[02:11:56] [02:11:56] {"jsonrpc":"2.0","method":"window/progress","params":{"done":true,"id":"progress_1","title":"Building"}}Content-Length: 92
[02:11:56] [02:11:56] {"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_0","title":"Indexing"}}Content-Length: 733
[02:11:56] [02:11:56] {"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"diagnostics":[{"code":"unused_variables","message":"unused variable: `unused`\n\nnote: #[warn(unused_variables)] on by default\nhelp: consider using `_unused` instead: `_unused`","range":{"end":{"character":30,"line":2},"start":{"character":24,"line":2}},"severity":2,"source":"rustc"},{"code":"unused_variables","message":"unused variable: `test_val`\n\nhelp: consider using `_test_val` instead: `_test_val`","range":{"end":{"character":36,"line":9},"start":{"character":28,"line":9}},"severity":2,"source":"rustc"}],"uri":"file:///C:/projects/rust/build/x86_64-pc-windows-msvc/stage2-tools/x86_64-pc-windows-msvc/rlsit/t0/simple_workspace/library/src/lib.rs"}}Content-Length: 493
[02:11:56] [02:11:56] {"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"diagnostics":[{"code":"unused_variables","message":"unused variable: `val`\n\nnote: #[warn(unused_variables)] on by default\nhelp: consider using `_val` instead: `_val`","range":{"end":{"character":27,"line":4},"start":{"character":24,"line":4}},"severity":2,"source":"rustc"}],"uri":"file:///C:/projects/rust/build/x86_64-pc-windows-msvc/stage2-tools/x86_64-pc-windows-msvc/rlsit/t0/simple_workspace/binary/src/main.rs"}}Content-Length: 104
[02:11:56] [02:11:56] {"jsonrpc":"2.0","method":"window/progress","params":{"done":true,"id":"progress_0","title":"Indexing"}}Content-Length: 92
[02:11:56] [02:11:56] {"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_3","title":"Building"}}Content-Length: 112
[02:11:56] [02:11:56] {"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_3","message":"library","title":"Building"}}Content-Length: 121
[02:11:56] [02:11:56] {"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_3","message":"binary cfg(test)","title":"Building"}}Content-Length: 111
[02:11:56] [02:11:56] {"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_3","message":"binary","title":"Building"}}Content-Length: 122
[02:11:56] [02:11:56] {"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_3","message":"library cfg(test)","title":"Building"}}Content-Length: 104
[02:11:56] [02:11:56] {"jsonrpc":"2.0","method":"window/progress","params":{"done":true,"id":"progress_3","title":"Building"}}Content-Length: 92
[02:11:56] [02:11:56] {"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_2","title":"Indexing"}}Content-Length: 681
[02:11:56] [02:11:56] {"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"diagnostics":[{"code":"unused_variables","message":"unused variable: `unused`\n\nnote: #[warn(unused_variables)] on by default\nhelp: consider using `_unused` instead: `_unused`","range":{"end":{"character":30,"line":2},"start":{"character":24,"line":2}},"severity":2,"source":"rustc"},{"code":"E0308","message":"mismatched types\n\nexpected u32, found u64","range":{"end":{"character":62,"line":9},"start":{"character":44,"line":9}},"severity":1,"source":"rustc"}],"uri":"file:///C:/projects/rust/build/x86_64-pc-windows-msvc/stage2-tools/x86_64-pc-windows-msvc/rlsit/t0/simple_workspace/library/src/lib.rs"}}Content-Length: 409
[02:11:56] [02:11:56] {"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"diagnostics":[{"code":"E0308","message":"mismatched types\n\nexpected u32, found u64","range":{"end":{"character":55,"line":4},"start":{"character":35,"line":4}},"severity":1,"source":"rustc"}],"uri":"file:///C:/projects/rust/build/x86_64-pc-windows-msvc/stage2-tools/x86_64-pc-windows-msvc/rlsit/t0/simple_workspace/binary/src/main.rs"}}Content-Length: 104
[02:11:56] [02:11:56] {"jsonrpc":"2.0","method":"window/progress","params":{"done":true,"id":"progress_2","title":"Indexing"}}Content-Length: 92
[02:11:56] [02:11:56] {"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_5","title":"Building"}}Content-Length: 122
[02:11:56] [02:11:56] {"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_5","message":"library cfg(test)","title":"Building"}}Content-Length: 112
[02:11:56] [02:11:56] {"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_5","message":"library","title":"Building"}}Content-Length: 121
[02:11:56] [02:11:56] {"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_5","message":"binary cfg(test)","title":"Building"}}Content-Length: 111
[02:11:56] [02:11:56] {"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_5","message":"binary","title":"Building"}}Content-Length: 104
[02:11:56] [02:11:56] {"jsonrpc":"2.0","method":"window/progress","params":{"done":true,"id":"progress_5","title":"Building"}}Content-Length: 92
[02:11:56] [02:11:56] {"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_4","title":"Indexing"}}Content-Length: 733
[02:11:56] [02:11:56] {"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"diagnostics":[{"code":"unused_variables","message":"unused variable: `unused`\n\nnote: #[warn(unused_variables)] on by default\nhelp: consider using `_unused` instead: `_unused`","range":{"end":{"character":30,"line":2},"start":{"character":24,"line":2}},"severity":2,"source":"rustc"},{"code":"unused_variables","message":"unused variable: `test_val`\n\nhelp: consider using `_test_val` instead: `_test_val`","range":{"end":{"character":36,"line":9},"start":{"character":28,"line":9}},"severity":2,"source":"rustc"}],"uri":"file:///C:/projects/rust/build/x86_64-pc-windows-msvc/stage2-tools/x86_64-pc-windows-msvc/rlsit/t0/simple_workspace/library/src/lib.rs"}}Content-Length: 444
[02:11:56] [02:11:56] {"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"diagnostics":[{"code":"E0425","message":"cannot find function `fetch_u32` in module `library`\n\nnot found in `library`","range":{"end":{"character":53,"line":4},"start":{"character":44,"line":4}},"severity":1,"source":"rustc"}],"uri":"file:///C:/projects/rust/build/x86_64-pc-windows-msvc/stage2-tools/x86_64-pc-windows-msvc/rlsit/t0/simple_workspace/binary/src/main.rs"}}Content-Length: 104
[02:11:56] [02:11:56] {"jsonrpc":"2.0","method":"window/progress","params":{"done":true,"id":"progress_4","title":"Indexing"}}
[02:11:56] ---------------
[02:11:56] [02:11:56] [02:11:56] failures:
[02:11:56] cmd_changing_workspace_lib_retains_bin_diagnostics
[02:11:56] [02:11:56] test result: FAILED. 7 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out