Update RLS to set __CARGO_TEST_ROOT when running its tests.

[eddyb]

That is, update RLS to include rust-lang/rls#1138.

This fixes fallout from #53586.

r? @alexcrichton cc @Mark-Simulacrum@nrc@pietroalbini

[rust-highfive]

⚠️Warning⚠️

• These commits modify submodules.

[alexcrichton]

This is an internal environment variable used by cargo and not intended for other users, is there another way to fix this or perhaps something that can be officially supported by cargo?

The double underscore was supposed to indicate that...

[eddyb]

@alexcrichton I was told to use that variable in #53586 (comment) (and that PR already landed).

EDIT: I don't see how to do it short of a policy change in Cargo, to make "current package believes it's in a workspace when it's not" not an error (unless I misunderstood and it's just a warning?)

[alexcrichton]

@Mark-Simulacrum how come you suggested that? That should (like some others related to it) be an internal Cargo environment variable that isn't intended for use elsewhere.

[Mark-Simulacrum]

I did realize it was intended for Cargo-internal use but rustbuild is somewhat closely tied in anyway; I agree it's not too ideal of a state though. I mostly intended it as "this is one way" vs. "this is the right way" but perhaps I was misunderstood / that intent wasn't realized in "need to implement a more public option"

[eddyb]

I'm experimenting with __CARGO_TEST_ROOT-less solutions in #56194.

[eddyb]

@alexcrichton Given #56194 (comment), what options do we have?

[alexcrichton]

@Mark-Simulacrum oh that's what the double underscores were supposed to imply 😢

There just wasn't a way to fix this when rustbuild was originally written, hence the usage of src and not the root of the repository. I would not personally want to solve that problem by reaching into the internals of Cargo.

AFAIK Cargo isn't actually that tied to rustbuild in the sense that rustbuild is only relying on public APIs of Cargo and other official ways to use it. There's been some bugs here and there over time but that's just because rustbuild exercises so much functionality.

@eddyb I don't know of solutions off the top of my head, which is why I never tried to move Cargo.toml out of src.

[eddyb]

Given that #56194 worked, including unbreaking RLS' tests, I'll close this and revert rust-lang/rls#1138.