Try to make top-level Cargo.toml work without __CARGO_TEST_ROOT. by eddyb · Pull Request #56194 · rust-lang/rust

eddyb · 2018-11-24T07:33:42Z

The last failures I noticed before adding the __CARGO_TEST_ROOT hack were in src/test/run-make/thumb-none-{cortex-m,qemu}, and had to do with the fact that the top-level Cargo.toml uses nightly Cargo features.

If that's the only problem, this PR should work, and we can figure out how to unbreak RLS.

rust-highfive · 2018-11-24T07:33:45Z

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

eddyb · 2018-11-24T07:35:56Z

r? @alexcrichton

As this is a simpler attempt at #53586, and because we need to fix RLS ASAP:
@bors r=alexcrichton p=1

bors · 2018-11-24T07:35:56Z

📌 Commit 894fd10 has been approved by alexcrichton

bors · 2018-11-24T08:48:18Z

⌛ Testing commit 894fd10 with merge f2b833d...

Try to make top-level Cargo.toml work without __CARGO_TEST_ROOT. The last failures I noticed before adding the `__CARGO_TEST_ROOT` hack were in `src/test/run-make/thumb-none-{cortex-m,qemu}`, and had to do with the fact that the top-level `Cargo.toml` uses nightly Cargo features. If that's the only problem, this PR should work, and we can figure out how to unbreak RLS.

bors · 2018-11-24T09:42:11Z

💔 Test failed - status-travis

rust-highfive · 2018-11-24T09:42:13Z

The job dist-various-1 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:49:48] status: exit code: 2
[00:49:48] command: "make"
[00:49:48] stdout:
[00:49:48] ------------------------------------------
[00:49:48] bash script.sh
[00:49:48] AWS_ACCESS_KEY_ID=[secure]
[00:49:48] AWS_SECRET_ACCESS_KEY=[secure]
[00:49:48] BOOTSTRAP_PARENT_ID=1059
[00:49:48] BOOTSTRAP_PYTHON=/usr/bin/python2.7
[00:49:48] BUILD_DIR=/checkout/obj/build
[00:49:48] CARGO=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo
[00:49:48] CARGO_HOME=/cargo
[00:49:48] CC_armebv7r_none_eabi=arm-none-eabi-gcc
[00:49:48] CC_armebv7r_none_eabi=arm-none-eabi-gcc
[00:49:48] CC_mips_unknown_linux_musl=mips-openwrt-linux-gcc
[00:49:48] CC_mipsel_unknown_linux_musl=mipsel-openwrt-linux-gcc
[00:49:48] CC_sparc64_unknown_linux_gnu=sparc64-linux-gnu-gcc
[00:49:48] CC_x86_64_unknown_redox=x86_64-unknown-redox-gcc
[00:49:48] CI_JOB_NAME=dist-various-1
[00:49:48] DEPLOY=1
[00:49:48] HERE=/checkout/src/test/run-make/thumb-none-qemu
[00:49:48] HOME=/home/user
[00:49:48] HOSTNAME=d3c327f7e28e
[00:49:48] HOST_RPATH_DIR=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib
[00:49:48] LD_LIBRARY_PATH=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib
[00:49:48] LD_LIB_PATH_ENVVAR=LD_LIBRARY_PATH
[00:49:48] LLVM_COMPONENTS=
[00:49:48] LLVM_CXXFLAGS=
[00:49:48] MAKEFLAGS=
[00:49:48] MAKELEVEL=1
[00:49:48] MFLAGS=
[00:49:48] PWD=/checkout/src/test/run-make/thumb-none-qemu
[00:49:48] PYTHON=/usr/bin/python2.7
[00:49:48] PYTHON=/usr/bin/python2.7
[00:49:48] RUN_MAKE_TARGETS=thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf
[00:49:48] RUSTC=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc
[00:49:48] RUST_CONFIGURE_ARGS=--musl-root-armv5te=/musl-armv5te --musl-root-arm=/musl-arm --musl-root-armhf=/musl-armhf --musl-root-armv7=/musl-armv7 --musl-root-aarch64=/musl-aarch64 --musl-root-mips=/musl-mips --musl-root-mipsel=/musl-mipsel --enable-emscripten --disable-docs --set build.print-step-timings --enable-verbose-tests --enable-sccache --disable-manage-submodules --enable-locked-deps --enable-cargo-native-static --set rust.codegen-units-std=1 --disable-dist-src --release-channel=nightly --enable-llvm-static-stdcpp --set rust.remap-debuginfo --enable-missing-tools
[00:49:48] RUST_RELEASE_CHANNEL=nightly
[00:49:48] S=/checkout
[00:49:48] SCCACHE_BUCKET=rust-lang-ci-sccache2
[00:49:48] SCCACHE_REGION=us-west-1
[00:49:48] SCRIPT=python2.7 ../x.py test --target thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf src/test/run-make && python2.7 ../x.py dist --target asmjs-unknown-emscripten,wasm32-unknown-emscripten,x86_64-rumprun-netbsd,mips-unknown-linux-musl,mipsel-unknown-linux-musl,arm-unknown-linux-musleabi,arm-unknown-linux-musleabihf,armv5te-unknown-linux-gnueabi,armv5te-unknown-linux-musleabi,armv7-unknown-linux-musleabihf,aarch64-unknown-linux-musl,sparc64-unknown-linux-gnu,x86_64-unknown-redox,thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf,riscv32imc-unknown-none-elf,riscv32imac-unknown-none-elf,armebv7r-none-eabi,armebv7r-none-eabihf,armv7r-none-eabi,armv7r-none-eabihf
[00:49:48] SHLVL=3
[00:49:48] SRC=/checkout
[00:49:48] STAGING_DIR=/tmp
[00:49:48] TARGET=thumbv6m-none-eabi
[00:49:48] TARGETS=asmjs-unknown-emscripten,wasm32-unknown-emscripten,x86_64-rumprun-netbsd,mips-unknown-linux-musl,mipsel-unknown-linux-musl,arm-unknown-linux-musleabi,arm-unknown-linux-musleabihf,armv5te-unknown-linux-gnueabi,armv5te-unknown-linux-musleabi,armv7-unknown-linux-musleabihf,aarch64-unknown-linux-musl,sparc64-unknown-linux-gnu,x86_64-unknown-redox,thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf,riscv32imc-unknown-none-elf,riscv32imac-unknown-none-elf,armebv7r-none-eabi,armebv7r-none-eabihf,armv7r-none-eabi,armv7r-none-eabihf
[00:49:48] TARGET_RPATH_DIR=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/thumbv6m-none-eabi/lib
[00:49:48] TERM=xterm
[00:49:48] TMPDIR=/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-qemu/thumb-none-qemu
[00:49:48] TRAVIS=true
[00:49:48] TRAVIS_BRANCH=auto
[00:49:48] TRAVIS_BRANCH=auto
[00:49:48] WORK_DIR=/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-qemu/thumb-none-qemu
[00:49:48] _=/usr/bin/env
[00:49:48] __COMPAT_LAYER=RunAsInvoker
[00:49:48] /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-qemu/thumb-none-qemu /checkout/src/test/run-make/thumb-none-qemu
[00:49:48] /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-qemu/thumb-none-qemu/example /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-qemu/thumb-none-qemu /checkout/src/test/run-make/thumb-none-qemu
[00:49:48] Makefile:27: recipe for target 'all' failed
[00:49:48] ------------------------------------------
[00:49:48] stderr:
[00:49:48] ------------------------------------------
[00:49:48] ------------------------------------------
[00:49:48] + CRATE=example
[00:49:48] + env
[00:49:48] + sort
[00:49:48] + mkdir -p /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-qemu/thumb-none-qemu
[00:49:48] + pushd /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-qemu/thumb-none-qemu
[00:49:48] + rm -rf example
[00:49:48] + cp -a /checkout/src/test/run-make/thumb-none-qemu/example .
[00:49:48] + pushd example
[00:49:48] + env RUSTC_BOOTSTRAP=1 'RUSTFLAGS=-C linker=arm-none-eabi-ld -C link-arg=-Tlink.x' /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo run --target thumbv6m-none-eabi
[00:49:48] + grep 'x = 42'
[00:49:48] error: current package believes it's in a workspace when it's not:
[00:49:48] current: /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-qemu/thumb-none-qemu/example/Cargo.toml
[00:49:48] [00:49:48] [00:49:48] this may be fixable by adding `obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-qemu/thumb-none-qemu/example` to the `workspace.members` array of the manifest located at: /checkout/Cargo.toml
[00:49:48] make: *** [all] Error 1
[00:49:48] ------------------------------------------
[00:49:48] [00:49:48] thread '[run-make] run-make/thumb-none-qemu' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3282:9
[00:49:48] note: Run with `RUST_BACKTRACE=1` for a backtrace.
---
[00:49:48] CC_armebv7r_none_eabi=arm-none-eabi-gcc
[00:49:48] S=/checkout
[00:49:48] _=/bin/sh
[00:49:48] TOOLSTATE_REPO_ACCESS_TOKEN=[secure]
[00:49:48] TRAVIS=true
[00:49:48] RUST_RELEASE_CHANNEL=nightly
[00:49:48] PATH=/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
[00:49:48] RUN_MAKE_TARGETS=thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf
[00:49:48] RUSTC=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc
[00:49:48] RUST_BUILD_STAGE=stage2-thumbv6m-none-eabi
[00:49:48] BOOTSTRAP_PYTHON=/usr/bin/python2.7
[00:49:48] SCRIPT=python2.7 ../x.py test --target thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf src/test/run-make && python2.7 ../x.py dist --target asmjs-unknown-emscripten,wasm32-unknown-emscripten,x86_64-rumprun-netbsd,mips-unknown-linux-musl,mipsel-unknown-linux-musl,arm-unknown-linux-musleabi,arm-unknown-linux-musleabihf,armv5te-unknown-linux-gnueabi,armv5te-unknown-linux-musleabi,armv7-unknown-linux-musleabihf,aarch64-unknown-linux-musl,sparc64-unknown-linux-gnu,x86_64-unknown-redox,thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf,riscv32imc-unknown-none-elf,riscv32imac-unknown-none-elf,armebv7r-none-eabi,armebv7r-none-eabihf,armv7r-none-eabi,armv7r-none-eabihf
[00:49:48] AR=ar
[00:49:48] TRAVIS_BRANCH=auto
[00:49:48] RUSTC_BOOTSTRAP=1
[00:49:48] HOST_RPATH_DIR=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib
[00:49:48] SCCACHE_BUCKET=rust-lang-ci-sccache2
[00:49:48] PWD=/checkout/obj
[00:49:48] CI_JOB_NAME=dist-various-1
[00:49:48] TARGET_RPATH_DIR=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/thumbv6m-none-eabi/lib
[00:49:48] LD_LIB_PATH_ENVVAR=LD_LIBRARY_PATH
[00:49:48] PYTHON=/usr/bin/python2.7
[00:49:48] HOME=/home/user
[00:49:48] LD_LIBRARY_PATH=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib
[00:49:48] HOSTNAME=d3c327f7e28e
[00:49:48] CC_mipsel_unknown_linux_musl=mipsel-openwrt-linux-gcc
[00:49:48] SHLVL=2
[00:49:48] CC= [00:49:48] BUILD_DIR=/checkout/obj/build
[00:49:48] BUILD_DIR=/checkout/obj/build
[00:49:48] RUST_TEST_TMPDIR=/checkout/obj/build/tmp
[00:49:48] LLVM_CXXFLAGS=
[00:49:48] RUSTFLAGS=--cap-lints=allow
[00:49:48] STAGING_DIR=/tmp
[00:49:48] TMPDIR=/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-cortex-m/thumb-none-cortex-m
[00:49:48] TARGETS=asmjs-unknown-emscripten,wasm32-unknown-emscripten,x86_64-rumprun-netbsd,mips-unknown-linux-musl,mipsel-unknown-linux-musl,arm-unknown-linux-musleabi,arm-unknown-linux-musleabihf,armv5te-unknown-linux-gnueabi,armv5te-unknown-linux-musleabi,armv7-unknown-linux-musleabihf,aarch64-unknown-linux-musl,sparc64-unknown-linux-gnu,x86_64-unknown-redox,thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf,riscv32imc-unknown-none-elf,riscv32imac-unknown-none-elf,armebv7r-none-eabi,armebv7r-none-eabihf,armv7r-none-eabi,armv7r-none-eabihf
[00:49:48] RUST_CONFIGURE_ARGS=--musl-root-armv5te=/musl-armv5te --musl-root-arm=/musl-arm --musl-root-armhf=/musl-armhf --musl-root-armv7=/musl-armv7 --musl-root-aarch64=/musl-aarch64 --musl-root-mips=/musl-mips --musl-root-mipsel=/musl-mipsel --enable-emscripten --disable-docs --set build.print-step-timings --enable-verbose-tests --enable-sccache --disable-manage-submodules --enable-locked-deps --enable-cargo-native-static --set rust.codegen-units-std=1 --disable-dist-src --release-channel=nightly --enable-llvm-static-stdcpp --set rust.remap-debuginfo --enable-missing-tools
[00:49:48] MAKEFLAGS=
[00:49:48] MFLAGS=
[00:49:48] BOOTSTRAP_PARENT_ID=1059
[00:49:48] BOOTSTRAP_PARENT_ID=1059
[00:49:48] __COMPAT_LAYER=RunAsInvoker
[00:49:48] CC_x86_64_unknown_redox=x86_64-unknown-redox-gcc
[00:49:48] BUILD=x86_64-unknown-linux-gnu
[00:49:48] CXX= [00:49:48] AWS_ACCESS_KEY_ID=[secure]
[00:49:48] CC_sparc64_unknown_linux_gnu=sparc64-linux-gnu-gcc
[00:49:48] CC_sparc64_unknown_linux_gnu=sparc64-linux-gnu-gcc
[00:49:48] CARGO_HOME=/cargo
[00:49:48] RUSTC_LINKER=arm-none-eabi-gcc
[00:49:48] SCCACHE_REGION=us-west-1
[00:49:48] CC_mips_unknown_linux_musl=mips-openwrt-linux-gcc
[00:49:48] LLVM_COMPONENTS=
[00:49:48] TERM=xterm
[00:49:48] MAKELEVEL=1
[00:49:48] mkdir -p /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-cortex-m/thumb-none-cortex-m
[00:49:48] cd /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-cortex-m/thumb-none-cortex-m && rm -rf cortex-m
[00:49:48] cd /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-cortex-m/thumb-none-cortex-m && bash -x /checkout/src/test/run-make/thumb-none-cortex-m/../git_clone_sha1.sh cortex-m https://github.com/rust-embedded/cortex-m a448e9156e2cb1e556e5441fd65426952ef4b927 [00:49:48] HEAD is now at a448e91 v0.5.0
[00:49:48] # HACK(eddyb) sets `RUSTC_BOOTSTRAP=1` so Cargo can accept nightly features.
[00:49:48] # These come from the top-level Rust workspace, that this crate is not a
[00:49:48] # member of, but Cargo tries to load the workspace `Cargo.toml` anyway.
[00:49:48] cd /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-cortex-m/thumb-none-cortex-m && cd cortex-m && env RUSTC_BOOTSTRAP=1 /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --target thumbv6m-none-eabi -v
[00:49:48] Makefile:31: recipe for target 'all' failed
[00:49:48] ------------------------------------------
[00:49:48] stderr:
[00:49:48] ------------------------------------------
[00:49:48] ------------------------------------------
[00:49:48] + PROJECT_NAME=cortex-m
[00:49:48] + URL=https://github.com/rust-embedded/cortex-m
[00:49:48] + SHA1=a448e9156e2cb1e556e5441fd65426952ef4b927
[00:49:48] + git clone https://github.com/rust-embedded/cortex-m cortex-m
[00:49:48] Cloning into 'cortex-m'...
[00:49:48] + cd cortex-m
[00:49:48] + git reset --hard a448e9156e2cb1e556e5441fd65426952ef4b927
[00:49:48] error: current package believes it's in a workspace when it's not:
[00:49:48] current: /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-cortex-m/thumb-none-cortex-m/cortex-m/Cargo.toml
[00:49:48] [00:49:48] [00:49:48] this may be fixable by adding `obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-cortex-m/thumb-none-cortex-m/cortex-m` to the `workspace.members` array of the manifest located at: /checkout/Cargo.toml
[00:49:48] make: *** [all] Error 101
[00:49:48] ------------------------------------------
[00:49:48] [00:49:48] thread '[run-make] run-make/thumb-none-cortex-m' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3282:9
[00:49:48] ---
[00:49:48] test result: FAILED. 7 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out
[00:49:48] [00:49:48] [00:49:48] [00:49:48] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/thumbv6m-none-eabi/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/run-make" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make" "--stage-id" "stage2-thumbv6m-none-eabi" "--mode" "run-make" "--target" "thumbv6m-none-eabi" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" "--linker" "arm-none-eabi-gcc" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options -Lnative=/checkout/obj/build/thumbv6m-none-eabi/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--llvm-version" "8.0.0svn\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[00:49:48] [00:49:48] [00:49:48] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --target thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf src/test/run-make
[00:49:48] Build completed unsuccessfully in 0:45:44
---
travis_time:end:0dc94f96:start=1543052405760130489,finish=1543052405767017452,duration=6886963
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0027a191
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:08faa58a
travis_time:start:08faa58a
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:04821802
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

eddyb · 2018-11-24T10:40:37Z

error: current package believes it's in a workspace when it's not

So it is indeed an error, not just a warning.

alexcrichton · 2018-11-25T09:34:54Z

r=me if this strategy passes tests!

eddyb · 2018-11-25T11:47:25Z

@alexcrichton It doesn't ("error: current package believes it's in a workspace when it's not").

What we need is to either have the default be not treating a package as being in a workspace just because it's nested directory-wise (and only e.g. produce a warning), or have some opt-out mechanism (like __CARGO_TEST_ROOT but less hacky).

Maybe a way to say that the build directory is excluded from the workspace, in Cargo.toml?

alexcrichton · 2018-11-25T12:53:55Z

I believe as of recently cargo supports an exclude key in workspace manifests, perhaps that could work?

eddyb · 2018-11-25T13:00:40Z

Oh, heh, it was already used for something else, I just didn't notice!

@bors r=alexcrichton

bors · 2018-11-25T13:00:41Z

📌 Commit 20461a22b1276da654fd4909847ee94ec459128f has been approved by alexcrichton

bors · 2018-11-25T15:10:08Z

⌛ Testing commit 20461a22b1276da654fd4909847ee94ec459128f with merge dbce8625f9d6a9528e14c6f0972f589dd39e63c2...

bors · 2018-11-25T16:02:11Z

💔 Test failed - status-travis

rust-highfive · 2018-11-25T16:02:13Z

The job dist-various-1 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:48:42] status: exit code: 2
[00:48:42] command: "make"
[00:48:42] stdout:
[00:48:42] ------------------------------------------
[00:48:42] bash script.sh
[00:48:42] AWS_ACCESS_KEY_ID=[secure]
[00:48:42] AWS_SECRET_ACCESS_KEY=[secure]
[00:48:42] BOOTSTRAP_PARENT_ID=1059
[00:48:42] BOOTSTRAP_PYTHON=/usr/bin/python2.7
[00:48:42] BUILD_DIR=/checkout/obj/build
[00:48:42] CARGO=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo
[00:48:42] CARGO_HOME=/cargo
[00:48:42] CC_armebv7r_none_eabi=arm-none-eabi-gcc
[00:48:42] CC_armebv7r_none_eabi=arm-none-eabi-gcc
[00:48:42] CC_mips_unknown_linux_musl=mips-openwrt-linux-gcc
[00:48:42] CC_mipsel_unknown_linux_musl=mipsel-openwrt-linux-gcc
[00:48:42] CC_sparc64_unknown_linux_gnu=sparc64-linux-gnu-gcc
[00:48:42] CC_x86_64_unknown_redox=x86_64-unknown-redox-gcc
[00:48:42] CI_JOB_NAME=dist-various-1
[00:48:42] DEPLOY=1
[00:48:42] HERE=/checkout/src/test/run-make/thumb-none-qemu
[00:48:42] HOME=/home/user
[00:48:42] HOSTNAME=9c635bf737ce
[00:48:42] HOST_RPATH_DIR=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib
[00:48:42] LD_LIBRARY_PATH=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib
[00:48:42] LD_LIB_PATH_ENVVAR=LD_LIBRARY_PATH
[00:48:42] LLVM_COMPONENTS=
[00:48:42] LLVM_CXXFLAGS=
[00:48:42] MAKEFLAGS=
[00:48:42] MAKELEVEL=1
[00:48:42] MFLAGS=
[00:48:42] PWD=/checkout/src/test/run-make/thumb-none-qemu
[00:48:42] PYTHON=/usr/bin/python2.7
[00:48:42] PYTHON=/usr/bin/python2.7
[00:48:42] RUN_MAKE_TARGETS=thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf
[00:48:42] RUSTC=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc
[00:48:42] RUST_CONFIGURE_ARGS=--musl-root-armv5te=/musl-armv5te --musl-root-arm=/musl-arm --musl-root-armhf=/musl-armhf --musl-root-armv7=/musl-armv7 --musl-root-aarch64=/musl-aarch64 --musl-root-mips=/musl-mips --musl-root-mipsel=/musl-mipsel --enable-emscripten --disable-docs --set build.print-step-timings --enable-verbose-tests --enable-sccache --disable-manage-submodules --enable-locked-deps --enable-cargo-native-static --set rust.codegen-units-std=1 --disable-dist-src --release-channel=nightly --enable-llvm-static-stdcpp --set rust.remap-debuginfo --enable-missing-tools
[00:48:42] RUST_RELEASE_CHANNEL=nightly
[00:48:42] S=/checkout
[00:48:42] SCCACHE_BUCKET=rust-lang-ci-sccache2
[00:48:42] SCCACHE_REGION=us-west-1
[00:48:42] SCRIPT=python2.7 ../x.py test --target thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf src/test/run-make && python2.7 ../x.py dist --target asmjs-unknown-emscripten,wasm32-unknown-emscripten,x86_64-rumprun-netbsd,mips-unknown-linux-musl,mipsel-unknown-linux-musl,arm-unknown-linux-musleabi,arm-unknown-linux-musleabihf,armv5te-unknown-linux-gnueabi,armv5te-unknown-linux-musleabi,armv7-unknown-linux-musleabihf,aarch64-unknown-linux-musl,sparc64-unknown-linux-gnu,x86_64-unknown-redox,thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf,riscv32imc-unknown-none-elf,riscv32imac-unknown-none-elf,armebv7r-none-eabi,armebv7r-none-eabihf,armv7r-none-eabi,armv7r-none-eabihf
[00:48:42] SHLVL=3
[00:48:42] SRC=/checkout
[00:48:42] STAGING_DIR=/tmp
[00:48:42] TARGET=thumbv6m-none-eabi
[00:48:42] TARGETS=asmjs-unknown-emscripten,wasm32-unknown-emscripten,x86_64-rumprun-netbsd,mips-unknown-linux-musl,mipsel-unknown-linux-musl,arm-unknown-linux-musleabi,arm-unknown-linux-musleabihf,armv5te-unknown-linux-gnueabi,armv5te-unknown-linux-musleabi,armv7-unknown-linux-musleabihf,aarch64-unknown-linux-musl,sparc64-unknown-linux-gnu,x86_64-unknown-redox,thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf,riscv32imc-unknown-none-elf,riscv32imac-unknown-none-elf,armebv7r-none-eabi,armebv7r-none-eabihf,armv7r-none-eabi,armv7r-none-eabihf
[00:48:42] TARGET_RPATH_DIR=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/thumbv6m-none-eabi/lib
[00:48:42] TERM=xterm
[00:48:42] TMPDIR=/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-qemu/thumb-none-qemu
[00:48:42] TRAVIS=true
[00:48:42] TRAVIS_BRANCH=auto
[00:48:42] TRAVIS_BRANCH=auto
[00:48:42] WORK_DIR=/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-qemu/thumb-none-qemu
[00:48:42] _=/usr/bin/env
[00:48:42] __COMPAT_LAYER=RunAsInvoker
[00:48:42] /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-qemu/thumb-none-qemu /checkout/src/test/run-make/thumb-none-qemu
[00:48:42] /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-qemu/thumb-none-qemu/example /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-qemu/thumb-none-qemu /checkout/src/test/run-make/thumb-none-qemu
[00:48:42] Makefile:27: recipe for target 'all' failed
[00:48:42] ------------------------------------------
[00:48:42] stderr:
[00:48:42] ------------------------------------------
[00:48:42] ------------------------------------------
[00:48:42] + CRATE=example
[00:48:42] + env
[00:48:42] + sort
[00:48:42] + mkdir -p /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-qemu/thumb-none-qemu
[00:48:42] + pushd /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-qemu/thumb-none-qemu
[00:48:42] + rm -rf example
[00:48:42] + cp -a /checkout/src/test/run-make/thumb-none-qemu/example .
[00:48:42] + pushd example
[00:48:42] + env RUSTC_BOOTSTRAP=1 'RUSTFLAGS=-C linker=arm-none-eabi-ld -C link-arg=-Tlink.x' /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo run --target thumbv6m-none-eabi
[00:48:42] + grep 'x = 42'
[00:48:42] error: current package believes it's in a workspace when it's not:
[00:48:42] current: /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-qemu/thumb-none-qemu/example/Cargo.toml
[00:48:42] [00:48:42] [00:48:42] this may be fixable by adding `obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-qemu/thumb-none-qemu/example` to the `workspace.members` array of the manifest located at: /checkout/Cargo.toml
[00:48:42] make: *** [all] Error 1
[00:48:42] ------------------------------------------
[00:48:42] [00:48:42] thread '[run-make] run-make/thumb-none-qemu' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3282:9
[00:48:42] note: Run with `RUST_BACKTRACE=1` for a backtrace.
---
[00:48:42] CC_armebv7r_none_eabi=arm-none-eabi-gcc
[00:48:42] S=/checkout
[00:48:42] _=/bin/sh
[00:48:42] TOOLSTATE_REPO_ACCESS_TOKEN=[secure]
[00:48:42] TRAVIS=true
[00:48:42] RUST_RELEASE_CHANNEL=nightly
[00:48:42] PATH=/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
[00:48:42] RUN_MAKE_TARGETS=thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf
[00:48:42] RUSTC=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc
[00:48:42] RUST_BUILD_STAGE=stage2-thumbv6m-none-eabi
[00:48:42] BOOTSTRAP_PYTHON=/usr/bin/python2.7
[00:48:42] SCRIPT=python2.7 ../x.py test --target thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf src/test/run-make && python2.7 ../x.py dist --target asmjs-unknown-emscripten,wasm32-unknown-emscripten,x86_64-rumprun-netbsd,mips-unknown-linux-musl,mipsel-unknown-linux-musl,arm-unknown-linux-musleabi,arm-unknown-linux-musleabihf,armv5te-unknown-linux-gnueabi,armv5te-unknown-linux-musleabi,armv7-unknown-linux-musleabihf,aarch64-unknown-linux-musl,sparc64-unknown-linux-gnu,x86_64-unknown-redox,thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf,riscv32imc-unknown-none-elf,riscv32imac-unknown-none-elf,armebv7r-none-eabi,armebv7r-none-eabihf,armv7r-none-eabi,armv7r-none-eabihf
[00:48:42] AR=ar
[00:48:42] TRAVIS_BRANCH=auto
[00:48:42] RUSTC_BOOTSTRAP=1
[00:48:42] HOST_RPATH_DIR=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib
[00:48:42] SCCACHE_BUCKET=rust-lang-ci-sccache2
[00:48:42] PWD=/checkout/obj
[00:48:42] CI_JOB_NAME=dist-various-1
[00:48:42] TARGET_RPATH_DIR=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/thumbv6m-none-eabi/lib
[00:48:42] LD_LIB_PATH_ENVVAR=LD_LIBRARY_PATH
[00:48:42] PYTHON=/usr/bin/python2.7
[00:48:42] HOME=/home/user
[00:48:42] LD_LIBRARY_PATH=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib
[00:48:42] HOSTNAME=9c635bf737ce
[00:48:42] CC_mipsel_unknown_linux_musl=mipsel-openwrt-linux-gcc
[00:48:42] SHLVL=2
[00:48:42] CC= [00:48:42] BUILD_DIR=/checkout/obj/build
[00:48:42] BUILD_DIR=/checkout/obj/build
[00:48:42] RUST_TEST_TMPDIR=/checkout/obj/build/tmp
[00:48:42] LLVM_CXXFLAGS=
[00:48:42] RUSTFLAGS=--cap-lints=allow
[00:48:42] STAGING_DIR=/tmp
[00:48:42] TMPDIR=/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-cortex-m/thumb-none-cortex-m
[00:48:42] TARGETS=asmjs-unknown-emscripten,wasm32-unknown-emscripten,x86_64-rumprun-netbsd,mips-unknown-linux-musl,mipsel-unknown-linux-musl,arm-unknown-linux-musleabi,arm-unknown-linux-musleabihf,armv5te-unknown-linux-gnueabi,armv5te-unknown-linux-musleabi,armv7-unknown-linux-musleabihf,aarch64-unknown-linux-musl,sparc64-unknown-linux-gnu,x86_64-unknown-redox,thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf,riscv32imc-unknown-none-elf,riscv32imac-unknown-none-elf,armebv7r-none-eabi,armebv7r-none-eabihf,armv7r-none-eabi,armv7r-none-eabihf
[00:48:42] RUST_CONFIGURE_ARGS=--musl-root-armv5te=/musl-armv5te --musl-root-arm=/musl-arm --musl-root-armhf=/musl-armhf --musl-root-armv7=/musl-armv7 --musl-root-aarch64=/musl-aarch64 --musl-root-mips=/musl-mips --musl-root-mipsel=/musl-mipsel --enable-emscripten --disable-docs --set build.print-step-timings --enable-verbose-tests --enable-sccache --disable-manage-submodules --enable-locked-deps --enable-cargo-native-static --set rust.codegen-units-std=1 --disable-dist-src --release-channel=nightly --enable-llvm-static-stdcpp --set rust.remap-debuginfo --enable-missing-tools
[00:48:42] MAKEFLAGS=
[00:48:42] MFLAGS=
[00:48:42] BOOTSTRAP_PARENT_ID=1059
[00:48:42] BOOTSTRAP_PARENT_ID=1059
[00:48:42] __COMPAT_LAYER=RunAsInvoker
[00:48:42] CC_x86_64_unknown_redox=x86_64-unknown-redox-gcc
[00:48:42] BUILD=x86_64-unknown-linux-gnu
[00:48:42] CXX= [00:48:42] AWS_ACCESS_KEY_ID=[secure]
[00:48:42] CC_sparc64_unknown_linux_gnu=sparc64-linux-gnu-gcc
[00:48:42] CC_sparc64_unknown_linux_gnu=sparc64-linux-gnu-gcc
[00:48:42] CARGO_HOME=/cargo
[00:48:42] RUSTC_LINKER=arm-none-eabi-gcc
[00:48:42] SCCACHE_REGION=us-west-1
[00:48:42] CC_mips_unknown_linux_musl=mips-openwrt-linux-gcc
[00:48:42] LLVM_COMPONENTS=
[00:48:42] TERM=xterm
[00:48:42] MAKELEVEL=1
[00:48:42] mkdir -p /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-cortex-m/thumb-none-cortex-m
[00:48:42] cd /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-cortex-m/thumb-none-cortex-m && rm -rf cortex-m
[00:48:42] cd /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-cortex-m/thumb-none-cortex-m && bash -x /checkout/src/test/run-make/thumb-none-cortex-m/../git_clone_sha1.sh cortex-m https://github.com/rust-embedded/cortex-m a448e9156e2cb1e556e5441fd65426952ef4b927 [00:48:42] HEAD is now at a448e91 v0.5.0
[00:48:42] # HACK(eddyb) sets `RUSTC_BOOTSTRAP=1` so Cargo can accept nightly features.
[00:48:42] # These come from the top-level Rust workspace, that this crate is not a
[00:48:42] # member of, but Cargo tries to load the workspace `Cargo.toml` anyway.
[00:48:42] cd /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-cortex-m/thumb-none-cortex-m && cd cortex-m && env RUSTC_BOOTSTRAP=1 /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --target thumbv6m-none-eabi -v
[00:48:42] Makefile:31: recipe for target 'all' failed
[00:48:42] ------------------------------------------
[00:48:42] stderr:
[00:48:42] ------------------------------------------
[00:48:42] ------------------------------------------
[00:48:42] + PROJECT_NAME=cortex-m
[00:48:42] + URL=https://github.com/rust-embedded/cortex-m
[00:48:42] + SHA1=a448e9156e2cb1e556e5441fd65426952ef4b927
[00:48:42] + git clone https://github.com/rust-embedded/cortex-m cortex-m
[00:48:42] Cloning into 'cortex-m'...
[00:48:42] + cd cortex-m
[00:48:42] + git reset --hard a448e9156e2cb1e556e5441fd65426952ef4b927
[00:48:42] error: current package believes it's in a workspace when it's not:
[00:48:42] current: /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-cortex-m/thumb-none-cortex-m/cortex-m/Cargo.toml
[00:48:42] [00:48:42] [00:48:42] this may be fixable by adding `obj/build/x86_64-unknown-linux-gnu/test/run-make/thumb-none-cortex-m/thumb-none-cortex-m/cortex-m` to the `workspace.members` array of the manifest located at: /checkout/Cargo.toml
[00:48:42] make: *** [all] Error 101
[00:48:42] ------------------------------------------
[00:48:42] [00:48:42] thread '[run-make] run-make/thumb-none-cortex-m' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3282:9
[00:48:42] ---
[00:48:42] test result: FAILED. 7 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out
[00:48:42] [00:48:42] [00:48:42] [00:48:42] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/thumbv6m-none-eabi/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/run-make" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make" "--stage-id" "stage2-thumbv6m-none-eabi" "--mode" "run-make" "--target" "thumbv6m-none-eabi" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" "--linker" "arm-none-eabi-gcc" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options -Lnative=/checkout/obj/build/thumbv6m-none-eabi/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--llvm-version" "8.0.0svn\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[00:48:42] [00:48:42] [00:48:42] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --target thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf src/test/run-make
[00:48:42] Build completed unsuccessfully in 0:44:52
---
travis_time:end:0fd7e341:start=1543161640823235787,finish=1543161640831362640,duration=8126853
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:3e63b03a
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:03b66cc6
travis_time:start:03b66cc6
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:070d4302
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

eddyb · 2018-11-25T18:21:47Z

@alexcrichton Hmm, on the CI, the build dir is obj/build? Not build?
Can I generate any sort of file inside the build dir to detach it from its parent directory, Cargo-wise?

Alternatively, a tmp dir could be used for tescases that are also Cargo projects.

…kspace.

eddyb · 2018-11-25T21:15:42Z

@bors r=alexcrichton

bors · 2018-11-25T21:15:43Z

📌 Commit 6aa4eb9 has been approved by alexcrichton

bors · 2018-11-25T22:00:14Z

⌛ Testing commit 6aa4eb9 with merge c14ab13...

Try to make top-level Cargo.toml work without __CARGO_TEST_ROOT. The last failures I noticed before adding the `__CARGO_TEST_ROOT` hack were in `src/test/run-make/thumb-none-{cortex-m,qemu}`, and had to do with the fact that the top-level `Cargo.toml` uses nightly Cargo features. If that's the only problem, this PR should work, and we can figure out how to unbreak RLS.

bors · 2018-11-26T00:52:11Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing c14ab13 to master...

rust-highfive · 2018-11-26T00:53:33Z

📣 Toolstate changed by #56194!

Tested on commit c14ab13.
Direct link to PR: #56194

🎉 rls on windows: test-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).
🎉 rls on linux: test-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).

@nrc

Tested on commit rust-lang/rust@c14ab13. Direct link to PR: <rust-lang/rust#56194> 🎉 rls on windows: test-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra). 🎉 rls on linux: test-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).

rust-highfive assigned aturon Nov 24, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 24, 2018

rust-highfive assigned alexcrichton and unassigned aturon Nov 24, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2018

eddyb mentioned this pull request Nov 24, 2018
Update RLS to set __CARGO_TEST_ROOT when running its tests. #56177
Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 24, 2018

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2018

eddyb force-pushed the top-unhack branch from 894fd10 to 20461a2Compare November 25, 2018 13:00

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 25, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 25, 2018

eddyb added 3 commits November 25, 2018 23:13

Try to make top-level Cargo.toml work without __CARGO_TEST_ROOT.
e281446

Cargo.toml: exclude the build directory from the workspace.
d9ca24e

HACK(eddyb) Cargo.toml: also exclude the obj directory from the wor…
6aa4eb9
…kspace.

eddyb force-pushed the top-unhack branch from 20461a2 to 6aa4eb9Compare November 25, 2018 21:15

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 25, 2018

bors merged commit 6aa4eb9 into rust-lang:masterNov 26, 2018

eddyb deleted the top-unhack branch November 26, 2018 00:54

eddyb mentioned this pull request Nov 26, 2018
Revert "Set the __CARGO_TEST_ROOT env variable for during tests." rust-lang/rls#1147
Merged

nrc mentioned this pull request Dec 7, 2018
rust-src and rust-analysis components out of sync? rust-lang/rls#1171
Closed

Uh oh!

Uh oh!

Conversation

eddyb commented Nov 24, 2018

Uh oh!

rust-highfive commented Nov 24, 2018

Uh oh!

eddyb commented Nov 24, 2018

Uh oh!

bors commented Nov 24, 2018

Uh oh!

bors commented Nov 24, 2018

Uh oh!

bors commented Nov 24, 2018

Uh oh!

rust-highfive commented Nov 24, 2018

Uh oh!

eddyb commented Nov 24, 2018

Uh oh!

alexcrichton commented Nov 25, 2018

Uh oh!

eddyb commented Nov 25, 2018

Uh oh!

alexcrichton commented Nov 25, 2018

Uh oh!

eddyb commented Nov 25, 2018

Uh oh!

bors commented Nov 25, 2018

Uh oh!

bors commented Nov 25, 2018

Uh oh!

bors commented Nov 25, 2018

Uh oh!

rust-highfive commented Nov 25, 2018

Uh oh!

eddyb commented Nov 25, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eddyb commented Nov 25, 2018

Uh oh!

bors commented Nov 25, 2018

Uh oh!

bors commented Nov 25, 2018

Uh oh!

bors commented Nov 26, 2018

Uh oh!

rust-highfive commented Nov 26, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

eddyb commented Nov 25, 2018•
edited
Loading