Uh oh!
There was an error while loading. Please reload this page.
Suggest appropriate place for lifetime when declared after type arguments - #56220
Merged
Conversation
rust-highfive
commented
Nov 25, 2018
Contributor
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
eddyb
commented
Nov 25, 2018
Contributor
estebank
commented
Nov 26, 2018
ContributorAuthor
Note that before this change the parse error was fatal, stopping |
nikomatsakis
requested changes
Nov 26, 2018
nikomatsakis
left a comment
Contributor
There was a problem hiding this comment.
Nice! Can we make a rustfix test here?
nikomatsakis
commented
Nov 26, 2018
Contributor
cc @zackmdavis, seems like something that might interest you |
nikomatsakis
commented
Nov 26, 2018
Contributor
r=me with a rustfix test |
estebank
commented
Nov 26, 2018
ContributorAuthor
@nikomatsakis sadly, it seems like rustfix doesn't handle multipart suggestions at all at the moment :-/ |
estebank
commented
Nov 26, 2018
ContributorAuthor
Filed rust-lang/rustfix#152. In the meantime, @bors r=nikomatsakis with intent to come back and add |
bors
commented
Nov 26, 2018
Collaborator
📌 Commit 6f028fe has been approved by |
emilyalbini added a commit
to emilyalbini/rust
that referenced
this pull request
Nov 28, 2018
…ikomatsakis Suggest appropriate place for lifetime when declared after type arguments
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 29, 2018
…ikomatsakis Suggest appropriate place for lifetime when declared after type arguments
bors added a commit
that referenced
this pull request
Nov 29, 2018
Rollup of 22 pull requests Successful merges: - #55391 (bootstrap: clean up a few clippy findings) - #56021 (avoid features_untracked) - #56023 (atomic::Ordering: Get rid of misleading parts of intro) - #56080 (Reduce the amount of bold text at doc.rlo) - #56114 (Enclose type in backticks for "non-exhaustive patterns" error) - #56124 (Fix small doc mistake on std::io::read::read_to_end) - #56127 (Update an outdated comment in mir building) - #56148 (Add rustc-guide as a submodule) - #56149 (Make std::os::unix/linux::fs::MetadataExt::a/m/ctime* documentation clearer) - #56220 (Suggest appropriate place for lifetime when declared after type arguments) - #56223 (Make JSON output from -Zprofile-json valid) - #56236 (Remove unsafe `unsafe` inner function.) - #56255 (Update outdated code comments in StringReader) - #56257 (rustc-guide has moved to rust-lang/) - #56273 (Add missing doc link) - #56289 (Fix small typo in comment of thread::stack_size) - #56294 (Fix a typo in the documentation of std::ffi) - #56312 (Deduplicate literal -> constant lowering) - #56319 (fix futures creating aliasing mutable and shared ref) - #56321 (rustdoc: add bottom margin spacing to nested lists) - #56322 (resolve: Fix false-positives from lint `absolute_paths_not_starting_with_crate`) - #56330 (Clean up span in non-trailing `..` suggestion) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.