Uh oh!
There was an error while loading. Please reload this page.
Rollup of 22 pull requests - #56340
Merged
Merged
Conversation
Remove the parts of atomic::Ordering's intro that wrongly claimed that SeqCst prevents all reorderings around it. Closesrust-lang#55196
This makes the error style consistent with the convention in error messages.
The std::io::read main documentation can lead to error because the buffer is prefilled with 10 zeros that will pad the response. Using an empty vector is better. The `read_to_end` documentation is already correct though. This is my first rust PR, don't hesitate to tell me if I did something wrong.
…-dereferencing" error
Within this `Iterator` implementation, a function `unsafe_get` is defined which unsafely allows _unchecked_ indexing of any element in a slice. This should be marked as _unsafe_, but it is not. To address this issue, I removed that inner function.
set to zero meant that the nested list was squished up against subsequent list items/paragraphs this changes the bottom margin to .6em, same as for paragraphs an example demonstrating the difference with screenshots is given in the pull request
…imNN bootstrap: clean up a few clippy findings remove useless format!()s remove redundant field names in a few struct initializations pass slice instead of a vector to a function use is_empty() instead of comparisons to .len() No functional change intended.
…cramertj Remove unsafe `unsafe` inner function. Within this `Iterator` implementation, a function `unsafe_get` is defined which unsafely allows _unchecked_ indexing of any element in a slice. This should be marked as _unsafe_, but it is not. To address this issue, I removed that inner function.
…aelwoerister Update outdated code comments in StringReader For the detection of newlines in the lexer, this is now done in `analyze_source_file.rs`.
…atsakis rustc-guide has moved to rust-lang/ r? @nikomatsakis
…ng-link, r=steveklabnik Add missing doc link r? @steveklabnik
Fix small typo in comment of thread::stack_size
Fix a typo in the documentation of std::ffi
Deduplicate literal -> constant lowering
fix futures creating aliasing mutable and shared ref Fixes the problem described in rust-lang/miri#532 (comment): `set_task_waker` takes a shared reference and puts a copy into the TLS (in a `NonNull`), but `get_task_waker` gets it back out as a mutable reference. That violates "mutable references must not alias anything"!
…illaumeGomez rustdoc: add bottom margin spacing to nested lists the current CSS for nested lists sets margin-bottom to zero, which means that a nested list is squished up against subsequent list items/paragraphs this changes the bottom margin to .6em, same as for paragraphs before:  after: 
resolve: Fix false-positives from lint `absolute_paths_not_starting_with_crate` Fixesrust-lang#56311 (stable-to-beta regression)
Clean up span in non-trailing `..` suggestion
GuillaumeGomez
commented
Nov 29, 2018
MemberAuthor
@bors: r+ p=22 |
bors
commented
Nov 29, 2018
Collaborator
📌 Commit 3b64f86 has been approved by |
bors
commented
Nov 29, 2018
Collaborator
bors added a commit
that referenced
this pull request
Nov 29, 2018
Rollup of 22 pull requests Successful merges: - #55391 (bootstrap: clean up a few clippy findings) - #56021 (avoid features_untracked) - #56023 (atomic::Ordering: Get rid of misleading parts of intro) - #56080 (Reduce the amount of bold text at doc.rlo) - #56114 (Enclose type in backticks for "non-exhaustive patterns" error) - #56124 (Fix small doc mistake on std::io::read::read_to_end) - #56127 (Update an outdated comment in mir building) - #56148 (Add rustc-guide as a submodule) - #56149 (Make std::os::unix/linux::fs::MetadataExt::a/m/ctime* documentation clearer) - #56220 (Suggest appropriate place for lifetime when declared after type arguments) - #56223 (Make JSON output from -Zprofile-json valid) - #56236 (Remove unsafe `unsafe` inner function.) - #56255 (Update outdated code comments in StringReader) - #56257 (rustc-guide has moved to rust-lang/) - #56273 (Add missing doc link) - #56289 (Fix small typo in comment of thread::stack_size) - #56294 (Fix a typo in the documentation of std::ffi) - #56312 (Deduplicate literal -> constant lowering) - #56319 (fix futures creating aliasing mutable and shared ref) - #56321 (rustdoc: add bottom margin spacing to nested lists) - #56322 (resolve: Fix false-positives from lint `absolute_paths_not_starting_with_crate`) - #56330 (Clean up span in non-trailing `..` suggestion) Failed merges: r? @ghost
bors
commented
Nov 29, 2018
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This was referenced Nov 29, 2018
This was referenced Nov 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
unsafeinner function. #56236 (Remove unsafeunsafeinner function.)absolute_paths_not_starting_with_crate#56322 (resolve: Fix false-positives from lintabsolute_paths_not_starting_with_crate)..suggestion #56330 (Clean up span in non-trailing..suggestion)Failed merges:
r? @ghost