Uh oh!
There was an error while loading. Please reload this page.
check missing docs for reexported macros as well - #56407
Conversation
rust-highfive
commented
Dec 1, 2018
r? @zackmdavis (rust_highfive has picked a reviewer for you, use r? to override) |
Uh oh!
There was an error while loading. Please reload this page.
rust-highfive
commented
Dec 1, 2018
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bec43d8 to
4c0981bComparerust-highfive
commented
Dec 1, 2018
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
GuillaumeGomez
commented
Dec 1, 2018
I don't understand how the failure can be linked to this PR... |
ollie27
commented
Dec 2, 2018
The failure is because it's now checking for the However as can be seen from the added ui test this hasn't actually worked. It's only giving a |
GuillaumeGomez
commented
Dec 2, 2018
Thanks for the explanation @ollie27! I'll fix this in the next days. |
4c0981b to
8bb752fComparerust-highfive
commented
Dec 21, 2018
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
8bb752f to
801ebc5CompareGuillaumeGomez
commented
Dec 21, 2018
rust-highfive
commented
Dec 21, 2018
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
GuillaumeGomez
commented
Dec 22, 2018
Arf, I need to make a PR to |
e8ed50d to
68830a1CompareCentril
commented
Dec 24, 2018
Re-assigning: r? @varkor |
There was a problem hiding this comment.
Nit: copyright is no longer needed.
There was a problem hiding this comment.
The stdsimd update is adding documentation so that this error isn't raised, but why do you need this feature?
There was a problem hiding this comment.
Without it we get:
error[E0658]: the target feature `avx512f` is currently unstable (see issue #44839)e
--> src/libcore/../stdsimd/coresimd/x86/avx512f.rs:13:18
|
13 | #[target_feature(enable = "avx512f")]
| ^^^^^^^^^^^^^^^^^^
|
= help: add #![feature(avx512_target_feature)] to the crate attributes to enable
error[E0658]: the target feature `avx512f` is currently unstable (see issue #44839)
--> src/libcore/../stdsimd/coresimd/x86/avx512f.rs:30:18
|
30 | #[target_feature(enable = "avx512f")]
| ^^^^^^^^^^^^^^^^^^
|
= help: add #![feature(avx512_target_feature)] to the crate attributes to enable
error[E0658]: the target feature `avx512f` is currently unstable (see issue #44839)
--> src/libcore/../stdsimd/coresimd/x86/avx512f.rs:43:18
|
43 | #[target_feature(enable = "avx512f")]
| ^^^^^^^^^^^^^^^^^^
|
= help: add #![feature(avx512_target_feature)] to the crate attributes to enable
error[E0658]: the target feature `avx512f` is currently unstable (see issue #44839)
--> src/libcore/../stdsimd/coresimd/x86/avx512f.rs:55:18
|
55 | #[target_feature(enable = "avx512f")]
| ^^^^^^^^^^^^^^^^^^
|
= help: add #![feature(avx512_target_feature)] to the crate attributes to enable
error[E0658]: the target feature `avx512f` is currently unstable (see issue #44839)
--> src/libcore/../stdsimd/coresimd/x86/avx512f.rs:65:18
|
65 | #[target_feature(enable = "avx512f")]
| ^^^^^^^^^^^^^^^^^^
|
= help: add #![feature(avx512_target_feature)] to the crate attributes to enable
error: aborting due to 5 previous errors
bors
commented
Dec 25, 2018
☔ The latest upstream changes (presumably #56926) made this pull request unmergeable. Please resolve the merge conflicts. |
0e10b09 to
ed9cc00Compareed9cc00 to
47e294eCompareGuillaumeGomez
commented
Jan 6, 2019
@bors: r=varkor |
bors
commented
Jan 8, 2019
📌 Commit 6fb9e2f224b4a85490a33cd1e60c97ad9983b98e has been approved by |
bors
commented
Jan 8, 2019
⌛ Testing commit 6fb9e2f224b4a85490a33cd1e60c97ad9983b98e with merge 63c79e99dfa3cb80b47f1b5d000ab9c0b4ff9c1d... |
bors
commented
Jan 8, 2019
💔 Test failed - status-travis |
rust-highfive
commented
Jan 8, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
805ca68 to
ad525dbComparerust-highfive
commented
Jan 8, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
ad525db to
5576925Comparerust-highfive
commented
Jan 8, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
5576925 to
0b272e7CompareGuillaumeGomez
commented
Jan 8, 2019
Let's give it another try... @bors: r=varkor p=10 |
bors
commented
Jan 8, 2019
📌 Commit 0b272e7 has been approved by |
bors
commented
Jan 8, 2019
… r=varkor check missing docs for reexported macros as well Fixes#56334.
bors
commented
Jan 9, 2019
☀️ Test successful - status-appveyor, status-travis |
Fixes#56334.