Skip to content

Fix and optimize query profiling - #57095

Merged
bors merged 2 commits into
rust-lang:masterfrom
Zoxc:prof-fix
Jan 8, 2019
Merged

Fix and optimize query profiling#57095
bors merged 2 commits into
rust-lang:masterfrom
Zoxc:prof-fix

Conversation

@Zoxc

@ZoxcZoxc commented Dec 24, 2018

Copy link
Copy Markdown
Contributor

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 24, 2018
@Zoxc

Zoxc commented Dec 24, 2018

Copy link
Copy Markdown
ContributorAuthor

@bors try

@bors

bors commented Dec 24, 2018

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 7c985beec1d57f2bfe6890f47eeab641c879ece3 with merge e12bb21de0cda2992dd77eb54755b113dea148f5...

@bors

bors commented Dec 24, 2018

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-travis
State: approved= try=True

@Zoxc

Zoxc commented Dec 24, 2018

Copy link
Copy Markdown
ContributorAuthor

@rust-timer build e12bb21de0cda2992dd77eb54755b113dea148f5

@rust-timer

rust-timer commented Dec 24, 2018

Copy link
Copy Markdown
Collaborator

Success: Queued e12bb21de0cda2992dd77eb54755b113dea148f5 with parent 94bf2c1, comparison URL.

@rust-timer

rust-timer commented Dec 24, 2018

Copy link
Copy Markdown
Collaborator

Finished benchmarking try commit e12bb21de0cda2992dd77eb54755b113dea148f5

michaelwoerister
michaelwoerister reviewed Jan 7, 2019
View reviewed changes

@michaelwoeristermichaelwoerister left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Zoxc! Good idea to record query counts in bulk.
r=me with the functions renamed.

Comment threadsrc/librustc/ty/query/plumbing.rs Outdated

@michaelwoeristermichaelwoeristerJan 7, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be called something like record_queries_computed unless I'm misreading something.

Comment threadsrc/librustc/util/profiling.rs Outdated

@michaelwoeristermichaelwoeristerJan 7, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should renamed to record_queries_computed too then.

Comment threadsrc/librustc/ty/query/plumbing.rs Outdated

@michaelwoeristermichaelwoeristerJan 7, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a remark: There should probably be a third category here for things that could be re-used but are not stored in the cache. Not sure how to best handle this.

Comment threadsrc/librustc/util/profiling.rs Outdated

@michaelwoeristermichaelwoeristerJan 7, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An issue for another PR: This looks like we could get missed updates here (and below) with parallel queries.

@Zoxc

Zoxc commented Jan 7, 2019

Copy link
Copy Markdown
ContributorAuthor

@bors r=michaelwoerister

@bors

bors commented Jan 7, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 23c742c has been approved by michaelwoerister

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 7, 2019
@bors

bors commented Jan 8, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 23c742c with merge 9d54812...

bors added a commit that referenced this pull request Jan 8, 2019
@bors
Auto merge of#57095- Zoxc:prof-fix, r=michaelwoerister
9d54812
Fix and optimize query profiling
r? @michaelwoerister
cc @wesleywiser
@bors

bors commented Jan 8, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: michaelwoerister
Pushing 9d54812 to master...

@bors
bors merged commit 23c742c into rust-lang:masterJan 8, 2019
@borsbors mentioned this pull request Jan 8, 2019
Merged
@Zoxc
Zoxc deleted the prof-fix branch January 8, 2019 05:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@michaelwoeristermichaelwoeristermichaelwoerister left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@michaelwoeristermichaelwoerister

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Zoxc@bors@rust-timer@michaelwoerister@rust-highfive