Move diagnostics out from QueryJob and optimize for the case with no diagnostics by Zoxc · Pull Request #57113 · rust-lang/rust

Zoxc · 2018-12-25T03:34:21Z

r? @michaelwoerister

Zoxc · 2018-12-25T03:34:34Z

@bors try

bors · 2018-12-25T03:34:46Z

⌛ Trying commit a872c4f1ca4490a342beb6a569dffcac1aea57a4 with merge 203d99c0ed5ec7c17b4cab82a3995a30de4903ce...

bors · 2018-12-25T05:53:04Z

☀️ Test successful - status-travis
State: approved= try=True

Zoxc · 2018-12-25T06:19:45Z

@rust-timer build 203d99c0ed5ec7c17b4cab82a3995a30de4903ce

rust-timer · 2018-12-25T06:19:46Z

Success: Queued 203d99c0ed5ec7c17b4cab82a3995a30de4903ce with parent ad781a0, comparison URL.

rust-timer · 2018-12-25T09:49:29Z

Finished benchmarking try commit 203d99c0ed5ec7c17b4cab82a3995a30de4903ce

Zoxc · 2018-12-25T13:58:50Z

Note: Another lock gone here too.

michaelwoerister · 2019-01-07T14:25:23Z

Thanks, @Zoxc! r=me with the conflicts resolved.

Zoxc · 2019-01-07T19:34:17Z

@bors r=michaelwoerister

bors · 2019-01-07T19:34:18Z

📌 Commit a872c4f1ca4490a342beb6a569dffcac1aea57a4 has been approved by michaelwoerister

bors · 2019-01-08T04:58:02Z

☔ The latest upstream changes (presumably #57095) made this pull request unmergeable. Please resolve the merge conflicts.

rust-highfive · 2019-01-08T17:38:29Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

…diagnostics

Zoxc · 2019-01-08T19:39:10Z

@bors r=michaelwoerister

bors · 2019-01-08T19:39:11Z

📌 Commit f21c084 has been approved by michaelwoerister

bors · 2019-01-10T06:02:13Z

⌛ Testing commit f21c084 with merge 0ffb6b65c87e9c6b588512508bcab13a82c7da5f...

bors · 2019-01-10T06:02:23Z

💔 Test failed - status-appveyor

emilyalbini · 2019-01-10T08:18:35Z

@bors retry
AppVeyor... what's wrong with you today?

@michaelwoerister

Move diagnostics out from QueryJob and optimize for the case with no diagnostics r? @michaelwoerister

@ghost

Rollup of 4 pull requests Successful merges: - #56874 (Simplify foreign type rendering.) - #57113 (Move diagnostics out from QueryJob and optimize for the case with no diagnostics) - #57366 (Point at match discriminant on type error in match arm pattern) - #57538 (librustc_mir: Fix ICE with slice patterns) Failed merges: - #57381 (Tweak output of type mismatch between "then" and `else` `if` arms) r? @ghost

rust-highfive assigned michaelwoerister Dec 25, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 25, 2018

Zoxc commented Dec 25, 2018
View reviewed changes

Comment threadsrc/librustc/ty/query/plumbing.rs Outdated
ZoxcDec 25, 2018
Copy link
Copy Markdown
ContributorAuthor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: Another lock gone here too.

Zoxc force-pushed the query-perf10 branch from a872c4f to bcdcfaeCompare January 7, 2019 17:27

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 7, 2019

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 8, 2019

Zoxc force-pushed the query-perf10 branch from bcdcfae to 4fe9349Compare January 8, 2019 17:03

Move diagnostics out from QueryJob and optimize for the case with no …
f21c084
…diagnostics

Zoxc force-pushed the query-perf10 branch from 4fe9349 to f21c084Compare January 8, 2019 17:50

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 8, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 10, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2019

Centril added a commit to Centril/rust that referenced this pull request Jan 13, 2019
Rollup merge ofrust-lang#57113- Zoxc:query-perf10, r=michaelwoerister
45d3572
Move diagnostics out from QueryJob and optimize for the case with no diagnostics r? @michaelwoerister

Centril mentioned this pull request Jan 13, 2019
Rollup of 4 pull requests #57580
Merged

bors merged commit f21c084 into rust-lang:masterJan 14, 2019

Zoxc deleted the query-perf10 branch January 14, 2019 01:09

Uh oh!

Uh oh!

Conversation

Zoxc commented Dec 25, 2018

Uh oh!

Zoxc commented Dec 25, 2018

Uh oh!

bors commented Dec 25, 2018

Uh oh!

bors commented Dec 25, 2018

Uh oh!

Zoxc commented Dec 25, 2018

Uh oh!

rust-timer commented Dec 25, 2018

Uh oh!

rust-timer commented Dec 25, 2018

Uh oh!

ZoxcDec 25, 2018

Choose a reason for hiding this comment

Uh oh!

michaelwoerister commented Jan 7, 2019

Uh oh!

Zoxc commented Jan 7, 2019

Uh oh!

bors commented Jan 7, 2019

Uh oh!

bors commented Jan 8, 2019

Uh oh!

rust-highfive commented Jan 8, 2019

Uh oh!

Zoxc commented Jan 8, 2019

Uh oh!

bors commented Jan 8, 2019

Uh oh!

bors commented Jan 10, 2019

Uh oh!

bors commented Jan 10, 2019

Uh oh!

emilyalbini commented Jan 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants