use the correct supertrait substitution in `object_ty_for_trait` by arielb1 · Pull Request #57355 · rust-lang/rust

Discussed in the @rust-lang/compiler meeting. This is acccepted for backport, however we would like to see it land on nightly first and ideally have a bit of "airtime". Since this is next in the queue, this seems likely to happen.

@bors p=22 -- to help ensure it stays high in the queue =)

Xanewok · 2019-01-10T20:02:30Z

Just a heads up, I'm not sure bors accepts comments after p= (seems to still be p=1 according to https://buildbot2.rust-lang.org/homu/queue/rust)

varkor · 2019-01-10T20:15:18Z

@bors p=22

Mark-Simulacrum · 2019-01-11T00:02:23Z

Cc @rust-lang/release @pietroalbini - could we prepare a beta PR with this included?

bors · 2019-01-11T03:06:48Z

⌛ Testing commit 85c4b4c with merge 7a232f19bff4a3fdb2daaeac2fa95d1a0dfdf2ab...

bors · 2019-01-11T06:08:08Z

💔 Test failed - checks-travis

rust-highfive · 2019-01-11T06:08:10Z

The job dist-x86_64-apple of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:03:17] Memory: 8 GB
[00:03:17] Boot ROM Version: VMW71.00V.0.B64.1704110547
[00:03:17] Apple ROM Info: [MS_VM_CERT/SHA1/27d66596a61c48dd3dc7216fd715126e33f59ae7]Welcome to the Virtual Machine
[00:03:17] SMC Version (system): 2.8f0
[00:03:17] Serial Number (system): VMVK3nIN5xiN
[00:03:17] [00:03:17] hw.ncpu: 4
[00:03:17] hw.byteorder: 1234
[00:03:17] hw.memsize: 8589934592
---
[02:49:18] travis_time:end:stage2-cargo-miri:start=1547186792385658000,finish=1547186792990559000,duration=604901000
[02:49:18] [TIMING] ToolBuild { compiler: Compiler { stage: 2, host: "x86_64-apple-darwin" }, target: "x86_64-apple-darwin", tool: "cargo-miri", path: "src/tools/miri", mode: ToolRustc, is_optional_tool: true, source_type: Submodule, extra_features: [] } -- 0.634
[02:49:20] [TIMING] Miri { stage: 2, target: "x86_64-apple-darwin" } -- 1.507
The job exceeded the maximum time limit for jobs, and has been terminated.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Centril · 2019-01-11T06:10:52Z

Seems spurious...

@bors retry

bors · 2019-01-11T06:48:22Z

⌛ Testing commit 85c4b4c with merge d7e205a...

use the correct supertrait substitution in `object_ty_for_trait` beta-nominating because regression. Fixes#57156.

bors · 2019-01-11T09:49:53Z

💔 Test failed - checks-travis

rust-highfive · 2019-01-11T09:49:53Z

The job dist-x86_64-apple of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:03:24] Memory: 8 GB
[00:03:24] Boot ROM Version: VMW71.00V.0.B64.1704110547
[00:03:24] Apple ROM Info: [MS_VM_CERT/SHA1/27d66596a61c48dd3dc7216fd715126e33f59ae7]Welcome to the Virtual Machine
[00:03:24] SMC Version (system): 2.8f0
[00:03:24] Serial Number (system): VMC5JjdUGh9r
[00:03:24] [00:03:24] hw.ncpu: 4
[00:03:24] hw.byteorder: 1234
[00:03:24] hw.memsize: 8589934592
---
[02:50:57] travis_fold:start:stage2-cargo-fmt
travis_time:start:stage2-cargo-fmt
Building stage2 tool cargo-fmt (x86_64-apple-darwin)
[02:50:57] Compiling rustfmt-nightly v1.0.1 (/Users/travis/build/rust-lang/rust/src/tools/rustfmt)
The job exceeded the maximum time limit for jobs, and has been terminated.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · 2019-01-11T11:24:31Z

@bors retry

bors · 2019-01-11T12:04:31Z

⌛ Testing commit 85c4b4c with merge 88f19a7...

use the correct supertrait substitution in `object_ty_for_trait` beta-nominating because regression. Fixes#57156.

bors · 2019-01-11T14:52:39Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: nikomatsakis
Pushing 88f19a7 to master...

@ghost

[beta] Rollup backports Cherry-picked: * #57355: use the correct supertrait substitution in `object_ty_for_trait` * #57471: Updated RELEASES.md for 1.32.0 Rolled up: * #57483: [beta] Uniform path backports * c658d73: resolve: Avoid "self-confirming" resolutions in import validation * #57160: resolve: Fix an ICE in import validation * #56759: Stabilize `uniform_paths` r? @ghost

arielb1 added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 5, 2019

rust-highfive assigned michaelwoerister Jan 5, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 5, 2019

rust-highfive assigned nikomatsakis and unassigned michaelwoerister Jan 5, 2019

arielb1 force-pushed the correct-subst branch from c167021 to a81dcdcCompare January 5, 2019 17:32

use the correct supertrait substitution in object_ty_for_trait
85c4b4c
Fixesrust-lang#57156.

arielb1 force-pushed the correct-subst branch from a81dcdc to 85c4b4cCompare January 5, 2019 17:34

nikomatsakis approved these changes Jan 8, 2019
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2019

nikomatsakis added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 8, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 10, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2019

bors mentioned this pull request Jan 10, 2019
std: Render large exit codes as hex on Windows #57473
Merged

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 10, 2019

Centril added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jan 11, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 11, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 11, 2019

bors added a commit that referenced this pull request Jan 11, 2019
Auto merge of#57355- arielb1:correct-subst, r=nikomatsakis
d7e205a
use the correct supertrait substitution in `object_ty_for_trait` beta-nominating because regression. Fixes#57156.

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 11, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 11, 2019

bors added a commit that referenced this pull request Jan 11, 2019
Auto merge of#57355- arielb1:correct-subst, r=nikomatsakis
88f19a7
use the correct supertrait substitution in `object_ty_for_trait` beta-nominating because regression. Fixes#57156.

bors merged commit 85c4b4c into rust-lang:masterJan 11, 2019

emilyalbini mentioned this pull request Jan 11, 2019
[beta] Rollup backports #57516
Merged

emilyalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 11, 2019

Uh oh!

Uh oh!

Conversation

arielb1 commented Jan 5, 2019

Uh oh!

arielb1 commented Jan 5, 2019

Uh oh!

rust-highfive commented Jan 5, 2019

Uh oh!

nikomatsakis commented Jan 8, 2019

Uh oh!

bors commented Jan 8, 2019

Uh oh!

emilyalbini commented Jan 9, 2019

Uh oh!

bors commented Jan 10, 2019

Uh oh!

bors commented Jan 10, 2019

Uh oh!

emilyalbini commented Jan 10, 2019

Uh oh!

bors commented Jan 10, 2019

Uh oh!

bors commented Jan 10, 2019

Uh oh!

nikomatsakis commented Jan 10, 2019

Uh oh!

Xanewok commented Jan 10, 2019

Uh oh!

varkor commented Jan 10, 2019

Uh oh!

Mark-Simulacrum commented Jan 11, 2019

Uh oh!

bors commented Jan 11, 2019

Uh oh!

bors commented Jan 11, 2019

Uh oh!

rust-highfive commented Jan 11, 2019

Uh oh!

Centril commented Jan 11, 2019

Uh oh!

bors commented Jan 11, 2019

Uh oh!

bors commented Jan 11, 2019

Uh oh!

rust-highfive commented Jan 11, 2019

Uh oh!

kennytm commented Jan 11, 2019

Uh oh!

bors commented Jan 11, 2019

Uh oh!

bors commented Jan 11, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants