[beta] Uniform path backports by petrochenkov · Pull Request #57483 · rust-lang/rust

petrochenkov · 2019-01-10T00:12:35Z

What's included:

c658d73 ("resolve: Avoid "self-confirming" resolutions in import validation", prerequisite for the following items)
resolve: Fix an ICE in import validation #57160 ("resolve: Fix an ICE in import validation")
Stabilize uniform_paths #56759 ("Stabilize uniform_paths")

…items

…5 edition ...while still keeping ambiguity errors future-proofing for uniform paths. This corner case is not going to be stabilized for 1.32 and needs some more general experiments about retrofitting 2018 import rules to 2015 edition

Add some tests for buggy derive helpers

rust-highfive · 2019-01-10T00:12:46Z

⚠️Warning⚠️

Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

petrochenkov · 2019-01-10T00:12:55Z

@bors try

bors · 2019-01-10T00:13:32Z

⌛ Trying commit bc232d3 with merge 0d8b5d1...

@Mark-Simulacrum

[beta] Uniform path backports What's included: - c658d73 ("resolve: Avoid "self-confirming" resolutions in import validation", prerequisite for the following items) - #57160 ("resolve: Fix an ICE in import validation") - #56759 ("Stabilize `uniform_paths`") r? @Mark-Simulacrum

Mark-Simulacrum · 2019-01-10T00:13:56Z

cc @Aaronepower (for #57471) -- I think it's likely this will land and if necessary I can take on backing it out of stable last minute

petrochenkov · 2019-01-10T00:20:52Z

@ 💂‍♂️ craterbot run start=master#2bde39b8edce6463e1c37f8a8082a875e7b536b1 end=try#0d8b5d1f16bab9e975695518ff8705bdab9fe94c mode=check-only

bors · 2019-01-10T02:35:47Z

☀️ Test successful - checks-travis
State: approved= try=True

Mark-Simulacrum · 2019-01-10T03:27:35Z

@craterbot run start=master#2bde39b8edce6463e1c37f8a8082a875e7b536b1 end=try#0d8b5d1f16bab9e975695518ff8705bdab9fe94c mode=check-only

craterbot · 2019-01-10T03:27:36Z

👌 Experiment pr-57483 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2019-01-10T03:27:38Z

🚧 Experiment pr-57483 is now running on agent aws-2.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

nikomatsakis · 2019-01-10T15:38:53Z

Discussed in the @rust-lang/compiler meeting. We decided we're definitely ok with backporting the first two PRs. As for the third PR, we don't typically backport stabilizations, but in this case this would help close a source of active problems around migration (see this list of related bugs). Therefore, 👍 to backport if the crater run results look good.

emilyalbini · 2019-01-11T16:01:32Z

I included c658d73 and #57160 in the rollup (#57516), so we'll only need to backport the stabilization if crater is ok.

craterbot · 2019-01-11T16:59:42Z

🎉 Experiment pr-57483 is completed!
📊 0 regressed and 1 fixed (50551 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

emilyalbini · 2019-01-11T17:02:14Z

Crater results looks good!

@bors r+

bors · 2019-01-11T17:02:15Z

📌 Commit bc232d3 has been approved by pietroalbini

emilyalbini · 2019-01-11T17:05:55Z

Rolled up inside #57516.

@ghost

[beta] Rollup backports Cherry-picked: * #57355: use the correct supertrait substitution in `object_ty_for_trait` * #57471: Updated RELEASES.md for 1.32.0 Rolled up: * #57483: [beta] Uniform path backports * c658d73: resolve: Avoid "self-confirming" resolutions in import validation * #57160: resolve: Fix an ICE in import validation * #56759: Stabilize `uniform_paths` r? @ghost

petrochenkov added 9 commits January 10, 2019 01:58

resolve: Avoid "self-confirming" resolutions in import validation
063553f

resolve: Fix an ICE in import validation
98e435e

resolve: Assign pub and pub(crate) visibilities to macro_rules …
62956b5
…items

resolve: Prohibit use of imported non-macro attributes
bfb9b95

resolve: Prohibit use of imported tool modules
e412291

Stabilize uniform_paths
19836b2

Fix a hole in generic parameter import future-proofing
079f44f
Add some tests for buggy derive helpers

Fix rebase
bc232d3

rust-highfive assigned Mark-Simulacrum Jan 10, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 10, 2019

petrochenkov added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2019

This was referenced Jan 10, 2019
Delay gensym creation for "underscore items" (use foo as _/const _) until name resolution #56392
Merged
resolve: Fix an ICE in import validation #57160
Merged

petrochenkov mentioned this pull request Jan 10, 2019
Stabilize uniform_paths#56759
Merged

Centril added T-lang Relevant to the language team relnotes Marks issues that should be documented in the release notes of the next release. labels Jan 11, 2019

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jan 11, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 11, 2019

emilyalbini added a commit to emilyalbini/rust that referenced this pull request Jan 11, 2019
Rollup merge ofrust-lang#57483- petrochenkov:beta, r=pietroalbini
17f510b

emilyalbini mentioned this pull request Jan 11, 2019
[beta] Rollup backports #57516
Merged

bors merged commit bc232d3 into rust-lang:betaJan 11, 2019

Centril added this to the 1.32 milestone Apr 27, 2019

petrochenkov deleted the beta branch June 5, 2019 16:28

Uh oh!

Uh oh!

Conversation

petrochenkov commented Jan 10, 2019

Uh oh!

rust-highfive commented Jan 10, 2019

Uh oh!

petrochenkov commented Jan 10, 2019

Uh oh!

bors commented Jan 10, 2019

Uh oh!

Mark-Simulacrum commented Jan 10, 2019

Uh oh!

petrochenkov commented Jan 10, 2019

Uh oh!

bors commented Jan 10, 2019

Uh oh!

Mark-Simulacrum commented Jan 10, 2019

Uh oh!

craterbot commented Jan 10, 2019

Uh oh!

craterbot commented Jan 10, 2019

Uh oh!

nikomatsakis commented Jan 10, 2019

Uh oh!

emilyalbini commented Jan 11, 2019

Uh oh!

craterbot commented Jan 11, 2019

Uh oh!

emilyalbini commented Jan 11, 2019

Uh oh!

bors commented Jan 11, 2019

Uh oh!

emilyalbini commented Jan 11, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants