use ignore directives for run-make tests by euclio · Pull Request #57388 · rust-lang/rust

euclio · 2019-01-06T22:12:57Z

This makes the tests easier to read, and makes it possible to tell which
tests aren't being run on the host platform.

Fixes#56704.

Centril · 2019-01-07T05:40:53Z

r? @kennytm

kennytm · 2019-01-08T14:25:57Z

Thanks!

@bors r+

bors · 2019-01-08T14:25:58Z

📌 Commit 0f70c06 has been approved by kennytm

bors · 2019-01-10T06:05:32Z

⌛ Testing commit 0f70c06 with merge 3d7a20f7e9d6068b8194e366b6910bf6cf94abb7...

bors · 2019-01-10T06:05:43Z

💔 Test failed - status-appveyor

emilyalbini · 2019-01-10T08:19:29Z

@bors retry
AppVeyor... what's wrong with you today?

bors · 2019-01-14T15:46:22Z

⌛ Testing commit 0f70c06 with merge cc28392...

use ignore directives for run-make tests This makes the tests easier to read, and makes it possible to tell which tests aren't being run on the host platform. Fixes#56704.

bors · 2019-01-14T16:46:07Z

💔 Test failed - checks-travis

kennytm · 2019-02-04T14:19:25Z

Needs to assign an OS to target nvptx64-nvidia-cuda

euclio · 2019-02-06T14:16:45Z

I couldn't get the test-various image to run locally, but I wrote a test asserting that nvptx64-nvidia-cuda has the OS "cuda".

@bors r+

bors · 2019-02-06T14:16:45Z

📌 Commit 0032deb6199c011afba856e003273cc65b2bbc78 has been approved by euclio

bors · 2019-02-06T16:06:51Z

⌛ Testing commit 0032deb6199c011afba856e003273cc65b2bbc78 with merge d992d842da76fcdb854c79d99abc963a89337780...

bors · 2019-02-06T17:44:08Z

💔 Test failed - checks-travis

rust-highfive · 2019-02-06T17:44:09Z

The job test-various of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:30:43] [TIMING] ToolBuild { compiler: Compiler { stage: 0, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", tool: "compiletest", path: "src/tools/compiletest", mode: ToolBootstrap, is_optional_tool: false, source_type: InTree, extra_features: [] } -- 0.373
[01:30:43] travis_fold:start:test_run-make
travis_time:start:test_run-make
Check compiletest suite=run-make mode=run-make (x86_64-unknown-linux-gnu -> nvptx64-nvidia-cuda)
[01:30:43] thread 'main' panicked at 'Cannot determine Architecture from triple', src/tools/compiletest/src/util.rs:90:5
[01:30:43] [01:30:43] [01:30:43] [01:30:43] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/nvptx64-nvidia-cuda/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/run-make" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make" "--stage-id" "stage2-nvptx64-nvidia-cuda" "--mode" "run-make" "--target" "nvptx64-nvidia-cuda" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" "--nodejs" "/node-v9.2.0-linux-x64/bin/node" "--host-rustcflags" "-Crpath -O -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options -Lnative=/checkout/obj/build/nvptx64-nvidia-cuda/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--llvm-version" "8.0.0\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:30:43] [01:30:43] [01:30:43] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --target nvptx64-nvidia-cuda src/test/run-make
[01:30:43] Build completed unsuccessfully in 0:00:39
---
travis_time:end:00fc3a12:start=1549474963852691286,finish=1549474963879381614,duration=26690328
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0a8a3bd0
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:07d6fca7
travis_time:start:07d6fca7
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0f9f8cb0
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · 2019-02-07T04:52:17Z

Check compiletest suite=run-make mode=run-make (x86_64-unknown-linux-gnu -> nvptx64-nvidia-cuda)
[01:30:43] thread 'main' panicked at 'Cannot determine Architecture from triple', src/tools/compiletest/src/util.rs:90:5

This makes the tests easier to read, and makes it possible to tell which tests aren't being run on the host platform. Fixesrust-lang#56704.

euclio · 2019-02-11T23:59:27Z

Still having issues with running the docker images locally, but I've added an OS for "x86_64-fortanix-unknown-sgx" (sgx) and an architecture for "nvptx64-nvidia-cuda" (cuda).

kennytm · 2019-02-12T04:45:34Z

@bors r+

bors · 2019-02-12T04:45:35Z

📌 Commit f15d20c has been approved by kennytm

bors · 2019-02-12T08:19:42Z

⌛ Testing commit f15d20c with merge a54b5c7...

use ignore directives for run-make tests This makes the tests easier to read, and makes it possible to tell which tests aren't being run on the host platform. Fixes#56704.

bors · 2019-02-12T10:51:48Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: kennytm
Pushing a54b5c7 to master...

rust-highfive assigned nikomatsakis Jan 6, 2019

This comment has been minimized.
Sign in to view

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 6, 2019

rust-highfive assigned kennytm and unassigned nikomatsakis Jan 7, 2019

kennytm reviewed Jan 7, 2019
View reviewed changes

Comment threadsrc/test/run-make-fulldeps/use-extern-for-plugins/Makefile Outdated
Comment threadsrc/test/run-make-fulldeps/compiler-rt-works-on-mingw/Makefile Outdated

euclio force-pushed the runmake-explicit-ignore branch 4 times, most recently from 49d08d4 to 0f70c06Compare January 7, 2019 15:23

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 10, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2019

Centril mentioned this pull request Jan 14, 2019
Rollup of 5 pull requests #57590
Closed

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 14, 2019

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 4, 2019

euclio force-pushed the runmake-explicit-ignore branch from f6a59e9 to 0032debCompare February 6, 2019 03:12

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 6, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 6, 2019

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2019

use ignore directives for run-make tests
f15d20c
This makes the tests easier to read, and makes it possible to tell which tests aren't being run on the host platform. Fixesrust-lang#56704.

euclio force-pushed the runmake-explicit-ignore branch from 0032deb to f15d20cCompare February 11, 2019 22:02

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 12, 2019

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 12, 2019

bors merged commit f15d20c into rust-lang:masterFeb 12, 2019

euclio deleted the runmake-explicit-ignore branch February 12, 2019 17:39

Uh oh!

Uh oh!

Conversation

euclio commented Jan 6, 2019

Uh oh!

This comment has been minimized.

Centril commented Jan 7, 2019

Uh oh!

Uh oh!

Uh oh!

kennytm commented Jan 8, 2019

Uh oh!

bors commented Jan 8, 2019

Uh oh!

bors commented Jan 10, 2019

Uh oh!

bors commented Jan 10, 2019

Uh oh!

emilyalbini commented Jan 10, 2019

Uh oh!

bors commented Jan 14, 2019

Uh oh!

bors commented Jan 14, 2019

Uh oh!

kennytm commented Feb 4, 2019

Uh oh!

euclio commented Feb 6, 2019

Uh oh!

bors commented Feb 6, 2019

Uh oh!

bors commented Feb 6, 2019

Uh oh!

bors commented Feb 6, 2019

Uh oh!

rust-highfive commented Feb 6, 2019

Uh oh!

kennytm commented Feb 7, 2019

Uh oh!

euclio commented Feb 11, 2019

Uh oh!

kennytm commented Feb 12, 2019

Uh oh!

bors commented Feb 12, 2019

Uh oh!

bors commented Feb 12, 2019

Uh oh!

bors commented Feb 12, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants