Skip to content

Rollup of 5 pull requests - #57590

Closed
Centril wants to merge 14 commits into
rust-lang:masterfrom
Centril:rollup
Closed

Rollup of 5 pull requests#57590
Centril wants to merge 14 commits into
rust-lang:masterfrom
Centril:rollup

Conversation

@Centril

Copy link
Copy Markdown
Contributor

Successful merges:

Failed merges:

r? @ghost

lqdand others added 6 commits January 7, 2019 19:48
Use the `collect_and_partition_mono_items ` query to avoid calling the collector
This function has no side effects, and its result is ignored.
Include the kind of the binding that we're suggesting, and use a
structured suggestion.
It requires an unreachable IP address, but there is no such thing, and
this has caused it to fail for multiple people.
Fixesrust-lang#44698, fixesrust-lang#50065.
@Centril

Copy link
Copy Markdown
ContributorAuthor

@bors r+ p=5

@bors

bors commented Jan 14, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 77ef320eb1a48541286687ed0c795d1761c54683 has been approved by Centril

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 14, 2019
@bors

bors commented Jan 14, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 77ef320eb1a48541286687ed0c795d1761c54683 with merge fb9c5fd8d65413eb553e61f0485de479401a71ce...

@bors

bors commented Jan 14, 2019

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-travis

@borsbors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 14, 2019
@rust-highfive

Copy link
Copy Markdown
Contributor

The job dist-various-1 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:05:36] ---> f2d758482422
[00:05:36] Step 3/49 : WORKDIR /build
[00:05:36] ---> Using cache
[00:05:36] ---> ce0fba60179c
[00:05:36] Step 4/49 : RUN add-apt-repository ppa:team-gcc-arm-embedded/ppa && apt-get update && apt-get install -y --no-install-recommends gcc-arm-embedded
[00:05:36] ---> c97f3431e7cc
[00:05:36] Step 5/49 : COPY dist-various-1/build-rumprun.sh /build
[00:05:36] ---> Using cache
[00:05:36] ---> 948411f72c3d
---
[00:58:17] [TIMING] ToolBuild { compiler: Compiler { stage: 0, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu", tool: "compiletest", path: "src/tools/compiletest", mode: ToolBootstrap, is_optional_tool: false, source_type: InTree, extra_features: [] } -- 86.849
[00:58:17] travis_fold:start:test_run-make
travis_time:start:test_run-make
Check compiletest suite=run-make mode=run-make (x86_64-unknown-linux-gnu -> thumbv6m-none-eabi)
[00:58:17] thread 'main' panicked at 'Cannot determine OS from triple', src/tools/compiletest/src/util.rs:77:5
[00:58:17] [00:58:17] [00:58:17] [00:58:17] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/thumbv6m-none-eabi/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/run-make" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make" "--stage-id" "stage2-thumbv6m-none-eabi" "--mode" "run-make" "--target" "thumbv6m-none-eabi" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" "--linker" "arm-none-eabi-gcc" "--host-rustcflags" "-Crpath -O -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options -Lnative=/checkout/obj/build/thumbv6m-none-eabi/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--llvm-version" "8.0.0svn\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[00:58:17] [00:58:17] [00:58:17] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --target thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf src/test/run-make
[00:58:17] Build completed unsuccessfully in 0:50:57
---
travis_time:end:12ca00cd:start=1547461311891254181,finish=1547461311904412830,duration=13158649
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:17c52420
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:03e54c84
travis_time:start:03e54c84
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:02d54a80
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@borsbors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 14, 2019
@Centril
Centrilforce-pushed the rollup branch 2 times, most recently from 93857dc to 1d029c6CompareJanuary 14, 2019 10:29
…oerister
Parallelize and optimize parts of HIR map creation
r? @michaelwoerister
…ster
MetadataOnlyCodegenBackend: run the collector only once
Use the `collect_and_partition_mono_items` query to avoid calling the collector directly twice.
Fixesrust-lang#57406.
…dor, r=joshtriplett,Centril
Stabilize cfg_target_vendor
This stabilizes the use of `cfg(target_vendor = "...")` and removes the corresponding `cfg_target_vendor` feature. Other unstable cfgs remain behind their existing feature gates.
This functionality was added back in 2015 in rust-lang#28612 to complete the coverage of target tuples (`<arch><sub>-<vendor>-<os>-<env>`). [RFC 131](https://github.com/rust-lang/rfcs/blob/master/text/0131-target-specification.md) governs the target specification, not including `target_vendor` seems to have just been an oversight. `target_os`, `target_family`, and `target_arch` are stable as of 1.0.0. `target_env` was also not mentioned in RFC 131, was added in rust-lang#24777, never behind a feature_gate, and insta-stable at 1.1.0.
The functionality is tested in [test/run-pass/cfg/cfg-target-vendor.rs](https://github.com/rust-lang/rust/blob/master/src/test/run-pass/cfg/cfg-target-vendor.rs).
Closesrust-lang#29718
…ckmdavis
clarify resolve typo suggestion
Include the kind of the binding that we're suggesting, and use a
structured suggestion.
Fixesrust-lang#53445.
privacy: Fix private-in-public check for existential types
Fixesrust-lang#53546 (regression from rust-lang#56878)
r? @arielb1
…utable, r=sfackler
Remove the `connect_timeout_unroutable` test.
It requires an unreachable IP address, but there is no such thing, and
this has caused it to fail for multiple people.
Fixesrust-lang#44698, fixesrust-lang#50065.
r? @sfackler
@CentrilCentril closed this Jan 14, 2019
@Centril
Centril deleted the rollup branch January 14, 2019 10:31
@rust-highfive

Copy link
Copy Markdown
Contributor

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@CentrilCentril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rollupA PR which is a rollupS-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@Centril@bors@rust-highfive@lqd@euclio@petrochenkov@nnethercote@Zoxc