Skip to content

Add missing unpretty option help message - #57598

Merged
bors merged 1 commit into
rust-lang:masterfrom
h-michael:unpretty-help
Jan 19, 2019
Merged

Add missing unpretty option help message#57598
bors merged 1 commit into
rust-lang:masterfrom
h-michael:unpretty-help

Conversation

@h-michael

@h-michaelh-michael commented Jan 14, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

There are some missing help messages that is printed ructc -Zunpretty help and receiving invalid option.

related with #16419, #45721, #21085, #31916

@rust-highfive

rust-highfive commented Jan 14, 2019

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 14, 2019
oli-obk
oli-obk requested changes Jan 14, 2019
View reviewed changes

@oli-obkoli-obk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits, lgtm otherwise

Comment threadsrc/librustc/session/config.rs Outdated
Comment threadsrc/librustc/session/config.rs Outdated
Comment threadsrc/librustc/session/config.rs Outdated
@h-michael

h-michael commented Jan 14, 2019

Copy link
Copy Markdown
ContributorAuthor

@oli-obk Thanks for your so quick review.
I've fixed it.

@rust-highfive

This comment has been minimized.

Sign in to view
oli-obk
oli-obk reviewed Jan 14, 2019
View reviewed changes
Comment threadsrc/librustc/session/config.rs Outdated
@h-michael

h-michael commented Jan 15, 2019

Copy link
Copy Markdown
ContributorAuthor

@oli-obk Thanks for your review.
This is my first PR for rust.
So I don't know so match review process.
According to CONTRIBUTING.md, do I had you write @ bors +r?
Or is there anything which I should do?

@oli-obk

oli-obk commented Jan 15, 2019

Copy link
Copy Markdown
Contributor

According to CONTRIBUTING.md, do I had you write @ bors +r?

Once the PR is in a state where it can be merged, I will send it off to bors, yes. You don't need to worry about bors for now, I'll take care of that.

Or is there anything which I should do?

I left a few comments, you can click the Commit suggestion button to apply the changes (or you can manually change the code on your computer if you prefer).

oli-obk
oli-obk reviewed Jan 15, 2019
View reviewed changes
Comment threadsrc/librustc/session/config.rs Outdated
@h-michael

h-michael commented Jan 15, 2019

Copy link
Copy Markdown
ContributorAuthor

I left a few comments, you can click the Commit suggestion button to apply the changes (or you can manually change the code on your computer if you prefer).

Oh, I'm sorry, I overlooked that one. 🙇

@h-michael

h-michael commented Jan 15, 2019

Copy link
Copy Markdown
ContributorAuthor

@oli-obk sorry, I fixed it.

@oli-obk

oli-obk commented Jan 15, 2019

Copy link
Copy Markdown
Contributor

@bors r+

Thanks!

@bors

bors commented Jan 15, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 260fb31 has been approved by oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 15, 2019
Centril added a commit to Centril/rust that referenced this pull request Jan 15, 2019
@Centril
Rollup merge ofrust-lang#57598- h-michael:unpretty-help, r=oli-obk
c5dea61
Add missing unpretty option help message
There are some missing help messages that is printed `ructc -Zunpretty help` and receiving invalid option.
related with rust-lang#16419, rust-lang#45721, rust-lang#21085, rust-lang#31916
@CentrilCentril mentioned this pull request Jan 15, 2019
Closed
bors added a commit that referenced this pull request Jan 16, 2019
@bors
Auto merge of#57637- Centril:rollup, r=Centril
eedef01
Rollup of 6 pull requests
Successful merges:
- #56884 (rustdoc: overhaul code block lexing errors)
- #57065 (Optimize try_mark_green and eliminate the lock on dep node colors)
- #57107 (Add a regression test for mutating a non-mut #[thread_local])
- #57268 (Add a target option "merge-functions", and a corresponding -Z flag (works around #57356))
- #57551 (resolve: Add a test for issue #57539)
- #57598 (Add missing unpretty option help message)
Failed merges:
r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Jan 19, 2019
@Centril
Rollup merge ofrust-lang#57598- h-michael:unpretty-help, r=oli-obk
bce5688
Add missing unpretty option help message
There are some missing help messages that is printed `ructc -Zunpretty help` and receiving invalid option.
related with rust-lang#16419, rust-lang#45721, rust-lang#21085, rust-lang#31916
@CentrilCentril mentioned this pull request Jan 19, 2019
Merged
bors added a commit that referenced this pull request Jan 19, 2019
@bors
Auto merge of#57755- Centril:rollup, r=Centril
9323499
Rollup of 7 pull requests
Successful merges:
- #57486 (Simplify `TokenStream` some more)
- #57502 (make trait-aliases work across crates)
- #57598 (Add missing unpretty option help message)
- #57649 (privacy: Account for associated existential types)
- #57659 (Fix release manifest generation)
- #57699 (add applicability to remaining suggestions)
- #57719 (Tweak `expand_node`)
Failed merges:
r? @ghost
@bors
bors merged commit 260fb31 into rust-lang:masterJan 19, 2019
@h-michael
h-michael deleted the unpretty-help branch January 20, 2019 06:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oli-obkoli-obkoli-obk approved these changes

Assignees

@oli-obkoli-obk

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@h-michael@rust-highfive@oli-obk@bors