Uh oh!
There was an error while loading. Please reload this page.
privacy: Account for associated existential types - #57649
Merged
Conversation
Contributor
I hate this kind of patchwork! I suppose that's what happens when I have no idea on how existential types work. |
arielb1
reviewed
Jan 17, 2019
Uh oh!
There was an error while loading. Please reload this page.
arielb1
reviewed
Jan 17, 2019
Uh oh!
There was an error while loading. Please reload this page.
arielb1
commented
Jan 17, 2019
Contributor
r=me with using exhaustive matches, which should catch any sillinesss that might happen if someone refactors these enums. |
petrochenkov
commented
Jan 17, 2019
ContributorAuthor
Exhaustive matches are added and factored into a separate function. @bors r=arielb1 |
bors
commented
Jan 17, 2019
Collaborator
📌 Commit d34b3e9 has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
Jan 18, 2019
privacy: Account for associated existential types Turns out they *can* be associated (but only in impls, not traits). Fixesrust-lang#53546 (comment) r? @arielb1
Centril added a commit
to Centril/rust
that referenced
this pull request
Jan 19, 2019
privacy: Account for associated existential types Turns out they *can* be associated (but only in impls, not traits). Fixesrust-lang#53546 (comment) r? @arielb1
bors added a commit
that referenced
this pull request
Jan 19, 2019
Rollup of 7 pull requests Successful merges: - #57486 (Simplify `TokenStream` some more) - #57502 (make trait-aliases work across crates) - #57598 (Add missing unpretty option help message) - #57649 (privacy: Account for associated existential types) - #57659 (Fix release manifest generation) - #57699 (add applicability to remaining suggestions) - #57719 (Tweak `expand_node`) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out they can be associated (but only in impls, not traits).
Fixes#53546 (comment)
r? @arielb1