Skip to content

Rollup of 5 pull requests - #57599

Closed
Centril wants to merge 35 commits into
rust-lang:masterfrom
Centril:rollup
Closed

Rollup of 5 pull requests#57599
Centril wants to merge 35 commits into
rust-lang:masterfrom
Centril:rollup

Conversation

@Centril

Copy link
Copy Markdown
Contributor

Successful merges:

Failed merges:

r? @ghost

ssomersand others added 27 commits December 21, 2018 14:57
…hat) on asymmetrically sized sets and extend unit tests slightly beyond that
Also, don't suggest comparing to zero for non-numeric expressions.
It shouldn't matter, but hey - better safe than sorry!
@Centril

Copy link
Copy Markdown
ContributorAuthor

@bors r+ p=5

@bors

bors commented Jan 14, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 9654f5ed0b18ab1644fd27636cfbe5ec996ac910 has been approved by Centril

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 14, 2019
@bors

bors commented Jan 14, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9654f5ed0b18ab1644fd27636cfbe5ec996ac910 with merge 7e8317110fba18e6dd06223682dcb555a5d9664c...

@bors

bors commented Jan 14, 2019

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-travis

@rust-highfive

Copy link
Copy Markdown
Contributor

The job x86_64-gnu-tools of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:2d83c37c:start=1547490145779454166,finish=1547490145793304662,duration=13850496
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:105ec2b6
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:06fff8c1
travis_time:start:06fff8c1
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:099e4b70
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 14, 2019
@Xanewok

Copy link
Copy Markdown
Contributor
[01:34:00] The state of "clippy-driver" has changed from "test-pass" to "build-fail"
[01:34:00] The state of "rls" has changed from "test-pass" to "build-fail"
[01:34:00] The state of "clippy-driver" has regressed from "test-pass" to "build-fail"
[01:34:00] The state of "rls" has regressed from "test-pass" to "build-fail"
no variant named `ScalarPair` found for type `rustc::mir::interpret::ConstValue<'_>` in the current scope

Clippy build fails due to #57442.

@Xanewok

Copy link
Copy Markdown
Contributor

cc @oli-obk if we're supposed to land this before the release now

@oli-obk

Copy link
Copy Markdown
Contributor

I think just removing #57442 would be the most sensible choice. There's no harm in letting it bake another 6 weeks

Fix poor worst case performance of set intersection
Specifically, intersection of asymmetrically sized sets when the large set is on the left. See also the [latest answer on stackoverflow](https://stackoverflow.com/questions/35439376/python-set-intersection-is-faster-then-rust-hashset-intersection).
Also applied to the union member, where the effect is much less but still measurable.
Formatted the changed code only, does not increase the error count reported by tidy check, and tried to adhere to the spirit of the unit tests.
…bank
provide suggestion for invalid boolean cast
Also, don't suggest comparing to zero for non-numeric expressions.
Modify some parser diagnostics to continue evaluating beyond the parser
Continue evaluating further errors after parser errors on:
- trailing type argument attribute
- lifetime in incorrect location
- incorrect binary literal
- missing `for` in `impl Trait for Foo`
- type argument in `where` clause
- incorrect float literal
- incorrect `..` in pattern
- associated types
- incorrect discriminator value variant error
and others. All of these were found by making `continue-parse-after-error` `true` by default to identify errors that would need few changes. There are now only a handful of errors that have any change with `continue-parse-after-error` enabled.
These changes make it so `rust` _won't_ stop evaluation after finishing parsing, enabling type checking errors to be displayed on the existing code without having to fix the parse errors.
Each commit has an individual diagnostic change with their corresponding tests.
CC rust-lang#48724.
Querify local `plugin_registrar_fn` and `proc_macro_decls_static`
Instead of calculating them as part of the `Session`, we do that in the query system.
It's also nice that these queries are already defined for external crates - here, we provide the queries for the local crate.
r? @nikomatsakis
…petrochenkov
Unaccept `extern_in_paths`
Based on completed fcp-close in rust-lang#55600, this removes `extern_in_path` (e.g. `extern::foo::bar`) from the language. The changes are primarily reversing rust-lang@32db83b.
Closesrust-lang#55600
r? @petrochenkov
…r=alexcrichton
Add a debug_assert to Vec::set_len
Following the precedent of rust-lang#52972, which found llogiq/bytecount#42.
(This may well make a test fail; let's see what Travis says.)
@CentrilCentril closed this Jan 14, 2019
@Centril
Centril deleted the rollup branch January 14, 2019 19:31
@Centril

Copy link
Copy Markdown
ContributorAuthor

Removed in #57607.

@CentrilCentril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rollupA PR which is a rollupS-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants

@Centril@bors@rust-highfive@Xanewok@oli-obk@ssomers@Zoxc@euclio@estebank@scottmcm