Skip to content

Remove an unused function argument - #57634

Merged
bors merged 1 commit into
rust-lang:masterfrom
oli-obk:remove_unused_argument
Jan 19, 2019
Merged

Remove an unused function argument#57634
bors merged 1 commit into
rust-lang:masterfrom
oli-obk:remove_unused_argument

Conversation

@oli-obk

@oli-obkoli-obk commented Jan 15, 2019

Copy link
Copy Markdown
Contributor

The only use was a debug printing, which might help someone with debugging dataflow problems, but seems otherwise useless

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 15, 2019
@ljedrz

Copy link
Copy Markdown
Contributor

That section gave me a headache during HirId-ification; too bad I didn't notice it is basically obsolete ^^.

@davidtwco

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Jan 17, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 096ca87 has been approved by davidtwco

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 17, 2019
Centril added a commit to Centril/rust that referenced this pull request Jan 18, 2019
…avidtwco
Remove an unused function argument
The only use was a debug printing, which might help someone with debugging dataflow problems, but seems otherwise useless
@CentrilCentril mentioned this pull request Jan 18, 2019
Centril added a commit to Centril/rust that referenced this pull request Jan 18, 2019
…avidtwco
Remove an unused function argument
The only use was a debug printing, which might help someone with debugging dataflow problems, but seems otherwise useless
@CentrilCentril mentioned this pull request Jan 18, 2019
Centril added a commit to Centril/rust that referenced this pull request Jan 19, 2019
…avidtwco
Remove an unused function argument
The only use was a debug printing, which might help someone with debugging dataflow problems, but seems otherwise useless
@CentrilCentril mentioned this pull request Jan 19, 2019
bors added a commit that referenced this pull request Jan 19, 2019
Rollup of 10 pull requests
Successful merges:
- #57268 (Add a target option "merge-functions", and a corresponding -Z flag (works around #57356))
- #57476 (Move glob map use to query and get rid of CrateAnalysis)
- #57501 (High priority resolutions for associated variants)
- #57573 (Querify `entry_fn`)
- #57610 (Fix nested `?` matchers)
- #57634 (Remove an unused function argument)
- #57653 (Make the contribution doc reference the guide more)
- #57666 (Generalize `huge-enum.rs` test and expected stderr for more cross platform cases)
- #57698 (Fix typo bug in DepGraph::try_mark_green().)
- #57746 (Update README.md)
Failed merges:
r? @ghost
@bors
bors merged commit 096ca87 into rust-lang:masterJan 19, 2019
@oli-obk
oli-obk deleted the remove_unused_argument branch June 15, 2020 15:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@oli-obk@rust-highfive@ljedrz@davidtwco@bors