Uh oh!
There was an error while loading. Please reload this page.
Rollup of 21 pull requests - #57732
Closed
Centril wants to merge 55 commits into
Closed
Conversation
Using `!` for `c_void` would have the problem that pointers and potentially references to an uninhabited type would be created, and at least for references this is UB. Also document in addition that newtype wrappers around `c_void` are not recommended for representing opaque types (as a workaround for `extern type` not being stable) but instead refer to the Nomicon.
…rent implementation We need at least two variants of the enum as otherwise the compiler complains about the #[repr(u8)] attribute and we also need at least one variant as otherwise the enum would be uninhabitated and dereferencing pointers to it would be UB. As such, mark the variants not unstable because they should not actually exist but because they are temporary implementation details until `extern type` is stable and can be used instead.
- Cleanup the `impl PartialEq<BookFormat> for Book` implementation - Implement `impl PartialEq<Book> for BookFormat` so it’s symmetric - Fixesrust-lang#53844. - Removes the last example since it appears to be redundant with the previous two examples.
This may be needed with some host compilers.
A few items were referenced, but did not have links.
It's simpler and makes some benchmark run up to 1% faster. It also makes `hir::ExprKind` more like `ast::ExprKind` (which underwent the equivalent change in rust-lang#55777).
It's identical to `ast::Label`.
…erister use structured macro and path resolve suggestions
… r=QuietMisdreavus Fix sources sidebar not showing up Fixesrust-lang#57601. The order of imports made it so that the sidebar creation was called before the sidebar sources were created. Like this, when the sources are loaded, they create the sidebar as expected. r? @QuietMisdreavus
…reavus Fixes text becoming invisible when element targetted Fixesrust-lang#57628. r? @QuietMisdreavus
librustc_metadata: Pass a default value when unwrapping a span Fixesrust-lang#57323. When compiling with `static-nobundle` a-la `rustc -l static-nobundle=nonexistent main.rs` we now get a neat output in the form of: ``` error[E0658]: kind="static-nobundle" is feature gated (see issue rust-lang#37403) | = help: add #![feature(static_nobundle)] to the crate attributes to enable error: aborting due to previous error For more information about this error, try `rustc --explain E0658`. ``` The build and tests completed successfully on my machine. Should I be adding a new test?
Add some links in std::fs. A few items were referenced, but did not have links.
…woerister Two HIR tweaks Two HIR tweaks that make things slightly simpler and faster.
…xcrichton Fix release manifest generation r? @alexcrichton
Document Unpin in std::prelude documentation
…-applicability, r=withoutboats Enhance `Pin` impl applicability for `PartialEq` and `PartialOrd`. This allows for comparing for equality or ordering a `Pin<P>` and a `Pin<Q>` as long as `P` and `Q` are correspondingly comparable themselves *even when `P` and `Q` are different types*. An example might be comparing a `Pin<&mut OsString>` to a `Pin<&mut PathBuf>`, which might arise from pin projections from a pair of larger contexts that aren't `Unpin`.
Fix typo bug in DepGraph::try_mark_green(). r? @ZoxcFixesrust-lang#57692.
Fix suggestions given mulitple bad lifetimes When given multiple lifetimes prior to type parameters in generic parameters, do not ICE and print the correct suggestion. r? @estebank CC @pnkfelixFixes: rust-lang#57521
Use structured suggestion to surround struct literal with parenthesis
Centril
commented
Jan 18, 2019
ContributorAuthor
@bors r+ p=21 |
bors
commented
Jan 18, 2019
Collaborator
📌 Commit a775836 has been approved by |
bors
commented
Jan 18, 2019
Collaborator
⌛ Testing commit a775836 with merge cbcca85ced37c03009cf9af466eddad96740e60c... |
bors
commented
Jan 18, 2019
Collaborator
💔 Test failed - checks-travis |
rust-highfive
commented
Jan 18, 2019
Contributor
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
mark-i-m
commented
Jan 18, 2019
Contributor
Maybe just me, but I notice a pattern of rollups taking many tries to actually merge. Why is that? It seems wasteful. Is there something we can do about it? |
Centril
commented
Jan 18, 2019
ContributorAuthor
@mark-i-m The reasons why rollups fail are mainly a) timeouts b) travis being silly, c) something actually going wrong in PRs... I think rollups often fail due to a & b as any other PR does. When c) happens, the goal is to isolate the offending PR and |
Contributor
Would it reduce the likelihood of a failure to do many smaller rollups rather than one big one? On balance, if you bors r+ 5 times in a large rollup but only once in most small rollups then doing two half-sized rollups would be more efficient, and it would be easier to isolate failures. |
Centril
commented
Jan 18, 2019
ContributorAuthor
Sure, you'd reduce the risk but also the payoff. In this case there are also 17 PRs in the queue are in the "rollup" prio so people have indicated that these should be problem free to rollup together (tho that might not actualy be true...). I think the lionshare of the 5 times are actually CI failures so you'd probably need to r+ more times if you did smaller rollups. |
mark-i-m
commented
Jan 18, 2019
Contributor
By CI failures you mean timeouts or other bizarre occurrences that have nothing to do with the code? |
ContributorAuthor
@mark-i-m Yeah basically timeouts, time travel, travis fuckups, hisenbugs, etc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
!forc_void#56594 (Remove confusing comment about ideally using!forc_void)?matchers #57610 (Fix nested?matchers)Pinimpl applicability forPartialEqandPartialOrd. #57685 (EnhancePinimpl applicability forPartialEqandPartialOrd.)Failed merges:
r? @ghost