Skip to content

Fix non-clickable urls - #57710

Merged
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:non-clickable
Jan 18, 2019
Merged

Fix non-clickable urls#57710
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:non-clickable

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented Jan 17, 2019

Copy link
Copy Markdown
Member

Fixes#57695

I didn't find anywhere where this rule was useful. Why did you add it @JohnHeitmann?

r? @QuietMisdreavus

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 17, 2019
@QuietMisdreavus

QuietMisdreavus commented Jan 17, 2019

Copy link
Copy Markdown
Contributor

@bors rollup

r=me, but i want to hold off actually putting this into the queue until we hear back from @JohnHeitmann.

@JohnHeitmann

JohnHeitmann commented Jan 18, 2019 via email •
edited
Loading

Copy link
Copy Markdown
Contributor

@bors

bors commented Jan 18, 2019

Copy link
Copy Markdown
Collaborator

@JohnHeitmann: 🔑 Insufficient privileges: not in try users

@JohnHeitmann

JohnHeitmann commented Jan 18, 2019

Copy link
Copy Markdown
Contributor

+1 to your change. Thanks for handling that, and sorry for the breakage!

Here's what happened:

Prior to my changes that selector was setting the z-index to a positive number-- I'm not sure why. When I simplified the markup, for some reason that positive z-index caused the code headers to bleed into the "Important traits..." tooltip like this (I just repro'd this to be sure):

screen shot 2019-01-17 at 9 45 24 pm

I don't know why I set it to a negative value instead of deleting it. I'd guess it was just a quick 'n dirty fix I forgot to revisit before submission. I just tested your change in a few scenarios and don't see any problems with it.

For the future: another easy to miss z problem happens in the mobile overlay menus. I tested to be sure and your patch doesn't re-break those either.

@GuillaumeGomezGuillaumeGomez mentioned this pull request Jan 18, 2019
Closed
@GuillaumeGomez

GuillaumeGomez commented Jan 18, 2019

Copy link
Copy Markdown
MemberAuthor

Ok, so now I know where the issue is. :)

@GuillaumeGomez

GuillaumeGomez commented Jan 18, 2019

Copy link
Copy Markdown
MemberAuthor

@bors: r=QuietMisdreavus

@bors

bors commented Jan 18, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 2518987 has been approved by QuietMisdreavus

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 18, 2019
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 18, 2019
@GuillaumeGomez
Rollup merge ofrust-lang#57710- GuillaumeGomez:non-clickable, r=Qui…
6647f21
…etMisdreavus
Fix non-clickable urls
Fixesrust-lang#57695
I didn't find anywhere where this rule was useful. Why did you add it @JohnHeitmann?
r? @QuietMisdreavus
@GuillaumeGomezGuillaumeGomez mentioned this pull request Jan 18, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Jan 18, 2019
@Centril
Rollup merge ofrust-lang#57710- GuillaumeGomez:non-clickable, r=Qui…
ff583ac
…etMisdreavus
Fix non-clickable urls
Fixesrust-lang#57695
I didn't find anywhere where this rule was useful. Why did you add it @JohnHeitmann?
r? @QuietMisdreavus
@CentrilCentril mentioned this pull request Jan 18, 2019
Merged
bors added a commit that referenced this pull request Jan 18, 2019
@bors
Auto merge of#57737- Centril:rollup, r=Centril
c76f3c3
Rollup of 10 pull requests
Successful merges:
- #56594 (Remove confusing comment about ideally using `!` for `c_void`)
- #57340 (Use correct tracking issue for c_variadic)
- #57357 (Cleanup PartialEq docs.)
- #57551 (resolve: Add a test for issue #57539)
- #57636 (Fix sources sidebar not showing up)
- #57646 (Fixes text becoming invisible when element targetted)
- #57654 (Add some links in std::fs.)
- #57683 (Document Unpin in std::prelude documentation)
- #57685 (Enhance `Pin` impl applicability for `PartialEq` and `PartialOrd`.)
- #57710 (Fix non-clickable urls)
Failed merges:
r? @ghost
@bors
bors merged commit 2518987 into rust-lang:masterJan 18, 2019
@GuillaumeGomez
GuillaumeGomez deleted the non-clickable branch January 19, 2019 11:46
@tspiteri

tspiteri commented Feb 21, 2019

Copy link
Copy Markdown
Contributor

@GuillaumeGomez@QuietMisdreavus Should this be backported to beta? Currently the beta docs have non-clickable method names. (I guess the highlighting will be fixed when #57859 is eventually backported.)

@QuietMisdreavusQuietMisdreavus added beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. labels Feb 21, 2019
@QuietMisdreavus

QuietMisdreavus commented Feb 21, 2019

Copy link
Copy Markdown
Contributor

Oof, i didn't realize this issue was on beta. Nominating (and immediately accepting) backport.

@Mark-SimulacrumMark-Simulacrum mentioned this pull request Feb 22, 2019
Merged
@emilyalbiniemilyalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 22, 2019
bors added a commit that referenced this pull request Feb 23, 2019
@bors
Auto merge of#58656- Mark-Simulacrum:beta-rollups, r=pietroalbini
bb2d0ea
Beta rollups
- #58649
- #58592
- #58574
- #58227
- #58056
- #57859
- #57710
A few of these are via #58641.
r? @pietroalbini
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@QuietMisdreavusQuietMisdreavus

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@GuillaumeGomez@QuietMisdreavus@JohnHeitmann@bors@tspiteri@emilyalbini@rust-highfive