avoid ICE when region sneaks into impl trait by pnkfelix · Pull Request #58649 · rust-lang/rust

pnkfelix · 2019-02-22T15:22:34Z

Addresses non-NLL instances of #57464

…dence over an ICE.

Centril · 2019-02-22T15:52:53Z

r? @nikomatsakis

nikomatsakis · 2019-02-22T15:53:46Z

@bors r+

bors · 2019-02-22T15:53:47Z

📌 Commit 8a0a0dad79d460e4b5656777c782f172ce517ea0 has been approved by nikomatsakis

Centril · 2019-02-22T16:07:53Z

Possible backport candidate, @bors p=10

oli-obk · 2019-02-22T16:22:39Z

beta nominating and auto-accepting as per the discussion in https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/.2358649.20backport.3F/near/159168423 (in short: going from bug! to delay_span_bug has zero risks)

Mark-Simulacrum · 2019-02-22T21:47:43Z

We ended up backing the test out of the beta rollup (it failed).

pnkfelix · 2019-02-22T23:19:28Z

@bors r-

It won’t land because the test added here will break under compare-mode=nll. (Or at least that’s my best guess as to what has gone on with this PR and the beta backport)

Beta rollups - #58649 - #58592 - #58574 - #58227 - #58056 - #57859 - #57710 A few of these are via #58641. r? @pietroalbini

pnkfelix · 2019-02-25T12:15:43Z

I removed the test (which causes compare-mode=nll to break).

I'm going to r+ the partial fix mostly to bring master in parity with beta.

I'm leaving #57464 open because I want to figure out the more general fix before closing it.

pnkfelix · 2019-02-25T12:16:44Z

@bors r+ 4f89846

pnkfelix · 2019-02-25T13:45:17Z

@bors r+

bors · 2019-02-25T13:45:18Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: Rollup of 10 pull requests #58728

bors · 2019-02-25T13:45:18Z

📌 Commit 4f89846 has been approved by pnkfelix

bors · 2019-02-25T14:48:37Z

⌛ Testing commit 4f89846 with merge b57fe74...

…aks-into-impl-trait, r=pnkfelix avoid ICE when region sneaks into impl trait Addresses non-NLL instances of #57464

bors · 2019-02-25T17:44:56Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: pnkfelix
Pushing b57fe74 to master...

bors · 2019-02-25T17:45:06Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: pnkfelix
Pushing b57fe74 to master...

Fixrust-lang#57979by allowing a legitimate type error to take prece…
4f89846
…dence over an ICE.

rust-highfive assigned varkor Feb 22, 2019

This comment has been minimized.
Sign in to view

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 22, 2019

pnkfelix changed the title ~~avoid ice when region sneaks into impl trait~~avoid ICE when region sneaks into impl traitFeb 22, 2019

rust-highfive assigned nikomatsakis and unassigned varkor Feb 22, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 22, 2019

oli-obk added beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. labels Feb 22, 2019

Centril mentioned this pull request Feb 22, 2019
[BETA] Universe leak check #58641
Closed

Mark-Simulacrum mentioned this pull request Feb 22, 2019
Beta rollups #58656
Merged

emilyalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 22, 2019

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 22, 2019

bors added a commit that referenced this pull request Feb 23, 2019
Auto merge of#58656- Mark-Simulacrum:beta-rollups, r=pietroalbini
bb2d0ea
Beta rollups - #58649 - #58592 - #58574 - #58227 - #58056 - #57859 - #57710 A few of these are via #58641. r? @pietroalbini

pnkfelix force-pushed the issue-57464-avoid-ice-when-region-sneaks-into-impl-trait branch from 8a0a0da to 4f89846Compare February 25, 2019 12:14

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 25, 2019

bors added a commit that referenced this pull request Feb 25, 2019
Auto merge of#58649- pnkfelix:issue-57464-avoid-ice-when-region-sne…
b57fe74
…aks-into-impl-trait, r=pnkfelix avoid ICE when region sneaks into impl trait Addresses non-NLL instances of #57464

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 25, 2019

bors merged commit 4f89846 into rust-lang:masterFeb 25, 2019

pnkfelix mentioned this pull request Feb 26, 2019
Nightly rustc crashes with "unexpected region in query response" #57464
Closed

Uh oh!

Uh oh!

Conversation

pnkfelix commented Feb 22, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

Centril commented Feb 22, 2019

Uh oh!

nikomatsakis commented Feb 22, 2019

Uh oh!

bors commented Feb 22, 2019

Uh oh!

Centril commented Feb 22, 2019

Uh oh!

oli-obk commented Feb 22, 2019

Uh oh!

Mark-Simulacrum commented Feb 22, 2019

Uh oh!

pnkfelix commented Feb 22, 2019

Uh oh!

pnkfelix commented Feb 25, 2019

Uh oh!

pnkfelix commented Feb 25, 2019

Uh oh!

pnkfelix commented Feb 25, 2019

Uh oh!

bors commented Feb 25, 2019

Uh oh!

bors commented Feb 25, 2019

Uh oh!

bors commented Feb 25, 2019

Uh oh!

bors commented Feb 25, 2019

Uh oh!

bors commented Feb 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

pnkfelix commented Feb 22, 2019•
edited
Loading