Uh oh!
There was an error while loading. Please reload this page.
Combine all builtin early lints - #57726
Merged
Merged
Conversation
Zoxc
commented
Jan 18, 2019
ContributorAuthor
There was a problem hiding this comment.
This is not the same instance used to register the lints. I don't think that matters for the lints in rustc though.
Contributor
There was a problem hiding this comment.
Let's continue forward with this under the assumption that it will be ok.
Zoxcforce-pushed
the
combine-early-lints
branch
from
January 18, 2019 09:12
3041cf5 to
cc755b7Compare
This comment has been minimized.
This comment has been minimized.
Zoxcforce-pushed
the
combine-early-lints
branch
from
January 18, 2019 09:56
cc755b7 to
5d3ad6cCompareestebank
commented
Jan 18, 2019
Contributor
@Zoxc you'll need to fix your tests. |
Zoxcforce-pushed
the
combine-early-lints
branch
from
January 19, 2019 03:59
5d3ad6c to
72743e4Compare…nts. Add a -Z no-interleave-lints option to allow benchmarking lints
Zoxcforce-pushed
the
combine-early-lints
branch
from
January 19, 2019 04:01
72743e4 to
beb0c74Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Zoxcforce-pushed
the
combine-early-lints
branch
from
January 19, 2019 07:10
77ea610 to
9b5535aCompareestebank
commented
Jan 24, 2019
Contributor
I'll review this soon. |
| @@ -60,6 +60,10 @@ declare_lint! { | |||
| pub struct WhileTrue; | |||
| impl LintPass for WhileTrue { | |||
Contributor
There was a problem hiding this comment.
All of these look like they could use a macro.
estebank
commented
Jan 25, 2019
Contributor
This looks reasonable to me. @bors r+ |
bors
commented
Jan 25, 2019
Collaborator
📌 Commit 9b5535a has been approved by |
bors
commented
Jan 26, 2019
Collaborator
bors added a commit
that referenced
this pull request
Jan 26, 2019
Combine all builtin early lints This also adds a -Z no-interleave-lints option to allow benchmarking lints. r? @estebank
bors
commented
Jan 26, 2019
Collaborator
☀️ Test successful - checks-travis, status-appveyor |
rust-highfive
commented
Jan 26, 2019
Contributor
📣 Toolstate changed by #57726! Tested on commit ccd428b. 💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth@llogiq@mcarton@oli-obk, @rust-lang/infra). |
rust-highfive added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Jan 26, 2019
Tested on commit rust-lang/rust@ccd428b. Direct link to PR: <rust-lang/rust#57726> 💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth@llogiq@mcarton@oli-obk, @rust-lang/infra). 💔 clippy-driver on linux: test-pass → build-fail (cc @Manishearth@llogiq@mcarton@oli-obk, @rust-lang/infra). 💔 rls on windows: test-pass → build-fail (cc @nrc@Xanewok, @rust-lang/infra). 💔 rls on linux: test-pass → build-fail (cc @nrc@Xanewok, @rust-lang/infra).
This was referenced Jan 26, 2019
matthiaskrgr added a commit
to matthiaskrgr/rust-clippy
that referenced
this pull request
Jan 26, 2019
matthiaskrgr added a commit
to matthiaskrgr/rust-clippy
that referenced
this pull request
Jan 26, 2019
matthiaskrgr added a commit
to matthiaskrgr/rust-clippy
that referenced
this pull request
Jan 27, 2019
matthiaskrgr added a commit
to matthiaskrgr/rust-clippy
that referenced
this pull request
Jan 27, 2019
bors added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Jan 27, 2019
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 30, 2019
Changes: ```` wildcard_match_arm: Update lint count. wildcard_match_arm: add nesting issue to known. wildcard_match_arm: lint only enum matches. wildcard_match_arm: update ui test stderr wildcard_match_arm: format test. wilcard_match_arm: run rustfmt. wildcard_match_arm: add lint properly. wildcard_match_arm: rename function. wildcard_match_arm: add simple ui test. wildcard_match_arm: expand lint scope. Change match_wild lint name to WILDCARD_MATCH_ARM. Add match_wild lint (rust-lang#3649). fetch_prs_between: add .sh file ending cargo fmt Update various docs Use built-in entry_fn detection over self-built cargo fmt Reorganize conditionals: Run faster checks first Maybe fix ICE? Add initial version of const_fn lint Fix `unit_arg` false positive Rustfmt Check hypothetically failing conversion Remove tests for deprecated items Update more changed iterator paths Atomics constants are now handled by the deprecation lint Update changed iterator paths Update const slice processing update test stderr run cargo fmt rustup rust-lang#57907 Fix documentation for `slow_vector_initialization` rustup rust-lang#57726 Remove unsafe_vector_initialization from added lints Prevent incorrect cast_lossless suggestion in const_fn Incorporate review suggestions Fix dogfood tests on Appveyor test(versioncheck): Use .no_deps() test(versioncheck): Fix version equality check chore(cargo/dependencies/cargo-metadata): Upgrade to 0.7.1 dependencies: update itertools from 0.7 to 0.8 Add script to fetch GitHub PRs between two commits gitattributes: Treat .fixed files as rust files Update changelog with all changes since 0.0.212 Fix `expect_fun_call` lint suggestions ````
bors added a commit
that referenced
this pull request
Jan 30, 2019
submodules: update clippy from f175352 to 6ce78d1 Should fix clippy toolstate Changes: ```` wildcard_match_arm: Update lint count. wildcard_match_arm: add nesting issue to known. wildcard_match_arm: lint only enum matches. wildcard_match_arm: update ui test stderr wildcard_match_arm: format test. wilcard_match_arm: run rustfmt. wildcard_match_arm: add lint properly. wildcard_match_arm: rename function. wildcard_match_arm: add simple ui test. wildcard_match_arm: expand lint scope. Change match_wild lint name to WILDCARD_MATCH_ARM. Add match_wild lint (#3649). fetch_prs_between: add .sh file ending cargo fmt Update various docs Use built-in entry_fn detection over self-built cargo fmt Reorganize conditionals: Run faster checks first Maybe fix ICE? Add initial version of const_fn lint Fix `unit_arg` false positive Rustfmt Check hypothetically failing conversion Remove tests for deprecated items Update more changed iterator paths Atomics constants are now handled by the deprecation lint Update changed iterator paths Update const slice processing update test stderr run cargo fmt rustup #57907 Fix documentation for `slow_vector_initialization` rustup #57726 Remove unsafe_vector_initialization from added lints Prevent incorrect cast_lossless suggestion in const_fn Incorporate review suggestions Fix dogfood tests on Appveyor test(versioncheck): Use .no_deps() test(versioncheck): Fix version equality check chore(cargo/dependencies/cargo-metadata): Upgrade to 0.7.1 dependencies: update itertools from 0.7 to 0.8 Add script to fetch GitHub PRs between two commits gitattributes: Treat .fixed files as rust files Update changelog with all changes since 0.0.212 Fix `expect_fun_call` lint suggestions ```` r? @oli-obk
g-bartoszek pushed a commit
to g-bartoszek/rust-clippy
that referenced
this pull request
Feb 5, 2019
g-bartoszek pushed a commit
to g-bartoszek/rust-clippy
that referenced
this pull request
Feb 7, 2019
flip1995 pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
May 5, 2020
Changes: ```` wildcard_match_arm: Update lint count. wildcard_match_arm: add nesting issue to known. wildcard_match_arm: lint only enum matches. wildcard_match_arm: update ui test stderr wildcard_match_arm: format test. wilcard_match_arm: run rustfmt. wildcard_match_arm: add lint properly. wildcard_match_arm: rename function. wildcard_match_arm: add simple ui test. wildcard_match_arm: expand lint scope. Change match_wild lint name to WILDCARD_MATCH_ARM. Add match_wild lint (rust-lang#3649). fetch_prs_between: add .sh file ending cargo fmt Update various docs Use built-in entry_fn detection over self-built cargo fmt Reorganize conditionals: Run faster checks first Maybe fix ICE? Add initial version of const_fn lint Fix `unit_arg` false positive Rustfmt Check hypothetically failing conversion Remove tests for deprecated items Update more changed iterator paths Atomics constants are now handled by the deprecation lint Update changed iterator paths Update const slice processing update test stderr run cargo fmt rustup rust-lang/rust#57907 Fix documentation for `slow_vector_initialization` rustup rust-lang/rust#57726 Remove unsafe_vector_initialization from added lints Prevent incorrect cast_lossless suggestion in const_fn Incorporate review suggestions Fix dogfood tests on Appveyor test(versioncheck): Use .no_deps() test(versioncheck): Fix version equality check chore(cargo/dependencies/cargo-metadata): Upgrade to 0.7.1 dependencies: update itertools from 0.7 to 0.8 Add script to fetch GitHub PRs between two commits gitattributes: Treat .fixed files as rust files Update changelog with all changes since 0.0.212 Fix `expect_fun_call` lint suggestions ````
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 27, 2024
Clean up some comments on lint implementation This updates some doc comments that have gotten very out of date. Some of these macros were removed or renamed in rust-lang#57726 and rust-lang#104863 and others. Manual emitting of lints was significantly reworked when the `Diagnostic` infrastructure was added. Rather than try to replicate the high-level documentation, I added pointers to the rustc-dev-guide. I linkified some types so that if they are renamed/removed without updating the docs, it will break CI.
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 27, 2024
Clean up some comments on lint implementation This updates some doc comments that have gotten very out of date. Some of these macros were removed or renamed in rust-lang#57726 and rust-lang#104863 and others. Manual emitting of lints was significantly reworked when the `Diagnostic` infrastructure was added. Rather than try to replicate the high-level documentation, I added pointers to the rustc-dev-guide. I linkified some types so that if they are renamed/removed without updating the docs, it will break CI.
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 27, 2024
Rollup merge of rust-lang#132221 - ehuss:lint-docs, r=compiler-errors Clean up some comments on lint implementation This updates some doc comments that have gotten very out of date. Some of these macros were removed or renamed in rust-lang#57726 and rust-lang#104863 and others. Manual emitting of lints was significantly reworked when the `Diagnostic` infrastructure was added. Rather than try to replicate the high-level documentation, I added pointers to the rustc-dev-guide. I linkified some types so that if they are renamed/removed without updating the docs, it will break CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also adds a -Z no-interleave-lints option to allow benchmarking lints.
r? @estebank