remove deprecated suggestion functions by euclio · Pull Request #57907 · rust-lang/rust

euclio · 2019-01-25T21:08:30Z

This PR removes the (now unused) deprecated suggestion functions and removes _with_applicability from their replacements' names.

This PR will break clippy, but I'll open a clippy PR once this is merged.

estebank · 2019-01-25T21:41:53Z

r=me once it passes ci

DO NOT ROLLUP

Centril · 2019-01-25T21:42:36Z

r? @estebank

estebank · 2019-01-25T23:28:26Z

@bors r+

bors · 2019-01-25T23:28:27Z

📌 Commit 6086e370b0c18cfaa08ee4f148ccef8658f7f1cb has been approved by estebank

bors · 2019-01-26T02:22:41Z

☔ The latest upstream changes (presumably #57898) made this pull request unmergeable. Please resolve the merge conflicts.

estebank · 2019-01-26T03:01:14Z

After you fix, let's give this high prio

Centril · 2019-01-26T03:21:15Z

@bors p=1

euclio · 2019-01-26T19:06:15Z

@estebank Rebased, and travis looks good so far.

Centril · 2019-01-26T19:29:11Z

@bors r=estebank

bors · 2019-01-26T19:29:12Z

📌 Commit 58766595c7418eb3af006f8562a28a9394245d46 has been approved by estebank

Centril · 2019-01-26T21:08:43Z

@bors r- p=10

You'll need to rebase, but I'd wait until after #57899 is merged since that will likely mess with this PR as well.

bors · 2019-01-26T21:10:30Z

☔ The latest upstream changes (presumably #57918) made this pull request unmergeable. Please resolve the merge conflicts.

Centril · 2019-01-27T04:02:48Z

#57899 was r-ed so you might want to quickly rebase and get this in before that one while the bors queue is relatively small.

Centril · 2019-01-27T04:38:47Z

Let's hope travis goes green while waiting on the other PRs in the queue... meanwhile:

@bors r=estebank

bors · 2019-01-27T04:38:48Z

📌 Commit 0897ffc has been approved by estebank

bors · 2019-01-27T06:35:59Z

⌛ Testing commit 0897ffc with merge 1484d0d...

remove deprecated suggestion functions This PR removes the (now unused) deprecated suggestion functions and removes `_with_applicability` from their replacements' names. This PR will break clippy, but I'll open a clippy PR once this is merged.

bors · 2019-01-27T09:18:56Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: estebank
Pushing 1484d0d to master...

for file in `fd \.rs$` ; do sed -i s/span_suggestion_with_applicability/span_suggestion/g $file ; done for file in `fd \.rs$` ; do sed -i s/span_suggestion_short_with_applicability/span_suggestion_short/g $file ; done for file in `fd \.rs$` ; do sed -i s/span_suggestions_with_applicability/span_suggestions/g $file ; done

rustup rustup rust-lang/rust#57907 and rust-lang/rust#57726Fixes#3708

Changes: ```` wildcard_match_arm: Update lint count. wildcard_match_arm: add nesting issue to known. wildcard_match_arm: lint only enum matches. wildcard_match_arm: update ui test stderr wildcard_match_arm: format test. wilcard_match_arm: run rustfmt. wildcard_match_arm: add lint properly. wildcard_match_arm: rename function. wildcard_match_arm: add simple ui test. wildcard_match_arm: expand lint scope. Change match_wild lint name to WILDCARD_MATCH_ARM. Add match_wild lint (rust-lang#3649). fetch_prs_between: add .sh file ending cargo fmt Update various docs Use built-in entry_fn detection over self-built cargo fmt Reorganize conditionals: Run faster checks first Maybe fix ICE? Add initial version of const_fn lint Fix `unit_arg` false positive Rustfmt Check hypothetically failing conversion Remove tests for deprecated items Update more changed iterator paths Atomics constants are now handled by the deprecation lint Update changed iterator paths Update const slice processing update test stderr run cargo fmt rustup rust-lang#57907 Fix documentation for `slow_vector_initialization` rustup rust-lang#57726 Remove unsafe_vector_initialization from added lints Prevent incorrect cast_lossless suggestion in const_fn Incorporate review suggestions Fix dogfood tests on Appveyor test(versioncheck): Use .no_deps() test(versioncheck): Fix version equality check chore(cargo/dependencies/cargo-metadata): Upgrade to 0.7.1 dependencies: update itertools from 0.7 to 0.8 Add script to fetch GitHub PRs between two commits gitattributes: Treat .fixed files as rust files Update changelog with all changes since 0.0.212 Fix `expect_fun_call` lint suggestions ````

@oli-obk

submodules: update clippy from f175352 to 6ce78d1 Should fix clippy toolstate Changes: ```` wildcard_match_arm: Update lint count. wildcard_match_arm: add nesting issue to known. wildcard_match_arm: lint only enum matches. wildcard_match_arm: update ui test stderr wildcard_match_arm: format test. wilcard_match_arm: run rustfmt. wildcard_match_arm: add lint properly. wildcard_match_arm: rename function. wildcard_match_arm: add simple ui test. wildcard_match_arm: expand lint scope. Change match_wild lint name to WILDCARD_MATCH_ARM. Add match_wild lint (#3649). fetch_prs_between: add .sh file ending cargo fmt Update various docs Use built-in entry_fn detection over self-built cargo fmt Reorganize conditionals: Run faster checks first Maybe fix ICE? Add initial version of const_fn lint Fix `unit_arg` false positive Rustfmt Check hypothetically failing conversion Remove tests for deprecated items Update more changed iterator paths Atomics constants are now handled by the deprecation lint Update changed iterator paths Update const slice processing update test stderr run cargo fmt rustup #57907 Fix documentation for `slow_vector_initialization` rustup #57726 Remove unsafe_vector_initialization from added lints Prevent incorrect cast_lossless suggestion in const_fn Incorporate review suggestions Fix dogfood tests on Appveyor test(versioncheck): Use .no_deps() test(versioncheck): Fix version equality check chore(cargo/dependencies/cargo-metadata): Upgrade to 0.7.1 dependencies: update itertools from 0.7 to 0.8 Add script to fetch GitHub PRs between two commits gitattributes: Treat .fixed files as rust files Update changelog with all changes since 0.0.212 Fix `expect_fun_call` lint suggestions ```` r? @oli-obk

for file in `fd \.rs$` ; do sed -i s/span_suggestion_with_applicability/span_suggestion/g $file ; done for file in `fd \.rs$` ; do sed -i s/span_suggestion_short_with_applicability/span_suggestion_short/g $file ; done for file in `fd \.rs$` ; do sed -i s/span_suggestions_with_applicability/span_suggestions/g $file ; done

Changes: ```` wildcard_match_arm: Update lint count. wildcard_match_arm: add nesting issue to known. wildcard_match_arm: lint only enum matches. wildcard_match_arm: update ui test stderr wildcard_match_arm: format test. wilcard_match_arm: run rustfmt. wildcard_match_arm: add lint properly. wildcard_match_arm: rename function. wildcard_match_arm: add simple ui test. wildcard_match_arm: expand lint scope. Change match_wild lint name to WILDCARD_MATCH_ARM. Add match_wild lint (rust-lang#3649). fetch_prs_between: add .sh file ending cargo fmt Update various docs Use built-in entry_fn detection over self-built cargo fmt Reorganize conditionals: Run faster checks first Maybe fix ICE? Add initial version of const_fn lint Fix `unit_arg` false positive Rustfmt Check hypothetically failing conversion Remove tests for deprecated items Update more changed iterator paths Atomics constants are now handled by the deprecation lint Update changed iterator paths Update const slice processing update test stderr run cargo fmt rustup rust-lang/rust#57907 Fix documentation for `slow_vector_initialization` rustup rust-lang/rust#57726 Remove unsafe_vector_initialization from added lints Prevent incorrect cast_lossless suggestion in const_fn Incorporate review suggestions Fix dogfood tests on Appveyor test(versioncheck): Use .no_deps() test(versioncheck): Fix version equality check chore(cargo/dependencies/cargo-metadata): Upgrade to 0.7.1 dependencies: update itertools from 0.7 to 0.8 Add script to fetch GitHub PRs between two commits gitattributes: Treat .fixed files as rust files Update changelog with all changes since 0.0.212 Fix `expect_fun_call` lint suggestions ````

euclio force-pushed the applicability-rename branch from 9af59d6 to 6086e37Compare January 25, 2019 21:18

estebank added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 25, 2019

estebank self-requested a review January 25, 2019 21:42

rust-highfive assigned estebank Jan 25, 2019

estebank approved these changes Jan 25, 2019
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 25, 2019

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 26, 2019

euclio force-pushed the applicability-rename branch from 6086e37 to 5876659Compare January 26, 2019 18:03

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 26, 2019

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 26, 2019

euclio added 2 commits January 26, 2019 23:06

document Applicability
8eaa84c

remove _with_applicability from suggestion fns
0897ffc

euclio force-pushed the applicability-rename branch from 5876659 to 0897ffcCompare January 27, 2019 04:08

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 27, 2019

bors merged commit 0897ffc into rust-lang:masterJan 27, 2019

This was referenced Jan 27, 2019
suggest | when , founds in invalid match value #57008
Merged
Add information to higher-ranked lifetimes conflicts error messages #57901
Merged
Unused variable suggestions apply on all patterns. #57899
Merged

This was referenced Jan 27, 2019
Clippy nightly build broken rust-lang/rust-clippy#3708
Closed
rustup rust-lang/rust-clippy#3705
Merged

bors added a commit to rust-lang/rust-clippy that referenced this pull request Jan 27, 2019
Auto merge of#3705- matthiaskrgr:rustup, r=phansch
13421e3
rustup rustup rust-lang/rust#57907 and rust-lang/rust#57726Fixes#3708

euclio deleted the applicability-rename branch January 27, 2019 15:38

matthiaskrgr added a commit to matthiaskrgr/rls that referenced this pull request Jan 27, 2019
rustuprust-lang/rust#57907
40225f5

Uh oh!

Uh oh!

Conversation

euclio commented Jan 25, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

estebank commented Jan 25, 2019

Uh oh!

Centril commented Jan 25, 2019

Uh oh!

estebank commented Jan 25, 2019

Uh oh!

bors commented Jan 25, 2019

Uh oh!

bors commented Jan 26, 2019

Uh oh!

estebank commented Jan 26, 2019

Uh oh!

Centril commented Jan 26, 2019

Uh oh!

euclio commented Jan 26, 2019

Uh oh!

Centril commented Jan 26, 2019

Uh oh!

bors commented Jan 26, 2019

Uh oh!

Centril commented Jan 26, 2019

Uh oh!

bors commented Jan 26, 2019

Uh oh!

Centril commented Jan 27, 2019

Uh oh!

Centril commented Jan 27, 2019

Uh oh!

bors commented Jan 27, 2019

Uh oh!

bors commented Jan 27, 2019

Uh oh!

bors commented Jan 27, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

euclio commented Jan 25, 2019•
edited
Loading