Skip to content

Unused variable suggestions apply on all patterns. - #57899

Merged
bors merged 1 commit into
rust-lang:masterfrom
davidtwco:issue-56685
Jan 28, 2019
Merged

Unused variable suggestions apply on all patterns.#57899
bors merged 1 commit into
rust-lang:masterfrom
davidtwco:issue-56685

Conversation

@davidtwco

@davidtwcodavidtwco commented Jan 25, 2019

Copy link
Copy Markdown
Member

Fixes#56685.

This PR extends existing suggestions to prefix unused variable bindings in match arms with an underscore so that it applies to all patterns in a match arm.

r? @estebank
cc @alexcrichton (since you filed the issue)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 25, 2019
Centril
Centril suggested changes Jan 25, 2019
View reviewed changes
Comment threadsrc/test/ui/issues/issue-56685.rs Outdated
Comment threadsrc/librustc/middle/liveness.rs Outdated
estebank
estebank reviewed Jan 25, 2019
View reviewed changes
Comment threadsrc/test/ui/issues/issue-56685.stderr Outdated
@estebank

estebank commented Jan 25, 2019

Copy link
Copy Markdown
Contributor

@bors r+

1 similar comment
@estebank

estebank commented Jan 25, 2019

Copy link
Copy Markdown
Contributor

@bors r+

@estebank

estebank commented Jan 25, 2019

Copy link
Copy Markdown
Contributor

@bors are you still there?

@CentrilCentril closed this Jan 25, 2019
@CentrilCentril reopened this Jan 25, 2019
@Centril

Centril commented Jan 25, 2019

Copy link
Copy Markdown
Contributor

@bors r=estebank

@bors

bors commented Jan 25, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 12cdaec has been approved by estebank

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 25, 2019
@Centril

Centril commented Jan 25, 2019

Copy link
Copy Markdown
Contributor

@estebank Bors just likes me more =P

@Centril

Centril commented Jan 26, 2019

Copy link
Copy Markdown
Contributor

Rollup fairness, @bors p=1

@CentrilCentril mentioned this pull request Jan 26, 2019
Merged
Centril added a commit to Centril/rust that referenced this pull request Jan 27, 2019
@Centril
Rollup merge ofrust-lang#57899- davidtwco:issue-56685, r=estebank
93350f4
Unused variable suggestions apply on all patterns.
Fixesrust-lang#56685.
This PR extends existing suggestions to prefix unused variable bindings in match arms with an underscore so that it applies to all patterns in a match arm.
r? @estebank
cc @alexcrichton (since you filed the issue)
@CentrilCentril mentioned this pull request Jan 27, 2019
Closed
@bors

bors commented Jan 27, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 12cdaec with merge 22768ccab68d22ea475f136f1e127f56404ec297...

@Centril

Centril commented Jan 27, 2019

Copy link
Copy Markdown
Contributor

Failed in rollup, #57930 (comment)

@bors r- retry

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 27, 2019
@bors

This comment has been minimized.

Sign in to view
@estebank

estebank commented Jan 27, 2019

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Jan 27, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit cd6e1ce has been approved by estebank

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 27, 2019
Centril added a commit to Centril/rust that referenced this pull request Jan 27, 2019
@Centril
Rollup merge ofrust-lang#57899- davidtwco:issue-56685, r=estebank
843d50f
Unused variable suggestions apply on all patterns.
Fixesrust-lang#56685.
This PR extends existing suggestions to prefix unused variable bindings in match arms with an underscore so that it applies to all patterns in a match arm.
r? @estebank
cc @alexcrichton (since you filed the issue)
@CentrilCentril mentioned this pull request Jan 27, 2019
Closed
@bors

bors commented Jan 28, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit cd6e1ce with merge b9a301e3d36e874c739116af6e2e5550dbdb2787...

@Centril

Centril commented Jan 28, 2019

Copy link
Copy Markdown
Contributor

Failed in rollup, #57938 (comment).

@bors r- retry

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 28, 2019
@rust-langrust-lang deleted a comment from rust-highfiveJan 28, 2019
@estebank

This comment has been minimized.

Sign in to view
@Centril

Centril commented Jan 28, 2019

Copy link
Copy Markdown
Contributor

@estebank--bless your heart ;)

@davidtwco
Unused variable suggestions on all patterns.
5f021e0
This commit extends existing suggestions to prefix unused variable
bindings in match arms with an underscore so that it applies to all
patterns in a match arm.
@davidtwco

davidtwco commented Jan 28, 2019

Copy link
Copy Markdown
MemberAuthor

@bors r=estebank

@bors

bors commented Jan 28, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 5f021e0 has been approved by estebank

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 28, 2019
@bors

bors commented Jan 28, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 5f021e0 with merge a21bd75...

bors added a commit that referenced this pull request Jan 28, 2019
@bors
Auto merge of#57899- davidtwco:issue-56685, r=estebank
a21bd75
Unused variable suggestions apply on all patterns.
Fixes#56685.
This PR extends existing suggestions to prefix unused variable bindings in match arms with an underscore so that it applies to all patterns in a match arm.
r? @estebank
cc @alexcrichton (since you filed the issue)
@bors

bors commented Jan 28, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-travis, status-appveyor
Approved by: estebank
Pushing a21bd75 to master...

@bors

bors commented Jan 28, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-travis, status-appveyor
Approved by: estebank
Pushing a21bd75 to master...

@bors
bors merged commit 5f021e0 into rust-lang:masterJan 28, 2019
@davidtwco
davidtwco deleted the issue-56685 branch January 28, 2019 14:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estebankestebankestebank left review comments
+1 more reviewer
@CentrilCentrilCentril approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@estebankestebank

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Suggestion for unused variables can sometimes be incorrect

5 participants

@davidtwco@estebank@Centril@bors@rust-highfive