Skip to content

rustdoc: wrap stability tags in colored spans - #58033

Merged
bors merged 1 commit into
rust-lang:masterfrom
euclio:rustdoc-tags
Feb 7, 2019
Merged

rustdoc: wrap stability tags in colored spans#58033
bors merged 1 commit into
rust-lang:masterfrom
euclio:rustdoc-tags

Conversation

@euclio

Copy link
Copy Markdown
Contributor

A cosmetic change to make the stability tags stand out a bit against the docs. Opening for discussion.

Before:

screen shot 2019-01-31 at 3 29 36 pm
screen shot 2019-01-31 at 3 31 32 pm

After:
screen shot 2019-01-31 at 3 29 18 pm
screen shot 2019-01-31 at 3 29 46 pm

r? @QuietMisdreavus

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 31, 2019

@QuietMisdreavusQuietMisdreavus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot, thanks so much!

@QuietMisdreavus

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Feb 7, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit ea2b1b0 has been approved by QuietMisdreavus

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2019
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 7, 2019
rustdoc: wrap stability tags in colored spans
A cosmetic change to make the stability tags stand out a bit against the docs. Opening for discussion.
Before:
![screen shot 2019-01-31 at 3 29 36 pm](https://user-images.githubusercontent.com/1372438/52083406-54730d80-256d-11e9-8e61-b8caff569434.png)
![screen shot 2019-01-31 at 3 31 32 pm](https://user-images.githubusercontent.com/1372438/52083408-54730d80-256d-11e9-97b7-43e808448f65.png)
After:
![screen shot 2019-01-31 at 3 29 18 pm](https://user-images.githubusercontent.com/1372438/52083405-54730d80-256d-11e9-9983-19d9519b2ed8.png)
![screen shot 2019-01-31 at 3 29 46 pm](https://user-images.githubusercontent.com/1372438/52083407-54730d80-256d-11e9-8c32-11a1ad7d3f34.png)
r? @QuietMisdreavus
bors added a commit that referenced this pull request Feb 7, 2019
Rollup of 11 pull requests
Successful merges:
- #57504 (Re-enable history api on file:// protocol)
- #57848 (Generate a documentation page for core::mem::transmute.)
- #57884 (Update minifier version)
- #57954 (rustdoc: remove blank unstable spans)
- #58028 (Fix image link in the settings menu)
- #58033 (rustdoc: wrap stability tags in colored spans)
- #58086 ([rustdoc] Improve file list display)
- #58143 (Sort elements in the sidebar)
- #58146 (Prevent automatic collapse of methods impl blocks)
- #58150 (Don't apply impl block collapse rules to trait impls)
- #58185 (Remove images' url to make it work even without internet connection)
Failed merges:
r? @ghost
@bors
bors merged commit ea2b1b0 into rust-lang:masterFeb 7, 2019
@euclio
euclio deleted the rustdoc-tags branch February 7, 2019 17:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@euclio@QuietMisdreavus@bors@rust-highfive