Skip to content

Prevent automatic collapse of methods impl blocks - #58146

Merged
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:dont-collapse-everything
Feb 7, 2019
Merged

Prevent automatic collapse of methods impl blocks#58146
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:dont-collapse-everything

Conversation

@GuillaumeGomez

Copy link
Copy Markdown
Member

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 4, 2019
@QuietMisdreavus

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Feb 7, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit d0f88c4 has been approved by QuietMisdreavus

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2019
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 7, 2019
…hing, r=QuietMisdreavus
Prevent automatic collapse of methods impl blocks
Fixesrust-lang#57582.
r? @QuietMisdreavus
bors added a commit that referenced this pull request Feb 7, 2019
Rollup of 11 pull requests
Successful merges:
- #57504 (Re-enable history api on file:// protocol)
- #57848 (Generate a documentation page for core::mem::transmute.)
- #57884 (Update minifier version)
- #57954 (rustdoc: remove blank unstable spans)
- #58028 (Fix image link in the settings menu)
- #58033 (rustdoc: wrap stability tags in colored spans)
- #58086 ([rustdoc] Improve file list display)
- #58143 (Sort elements in the sidebar)
- #58146 (Prevent automatic collapse of methods impl blocks)
- #58150 (Don't apply impl block collapse rules to trait impls)
- #58185 (Remove images' url to make it work even without internet connection)
Failed merges:
r? @ghost
@bors
bors merged commit d0f88c4 into rust-lang:masterFeb 7, 2019
@GuillaumeGomez
GuillaumeGomez deleted the dont-collapse-everything branch February 8, 2019 00:35
@ghost

Copy link
Copy Markdown

@GuillaumeGomez Does this option work for you on nightly Rust?

It doesn't for me here: https://doc.rust-lang.org/nightly/std
I have enabled the "Auto-hide item methods' documentation" option.

@GuillaumeGomez

GuillaumeGomez commented Mar 1, 2019

Copy link
Copy Markdown
MemberAuthor

The "Auto-hide item methods' documentation" option doesn't seem to work. Opening an issue.

EDIT: #58825

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@GuillaumeGomez@QuietMisdreavus@bors@rust-highfive