Uh oh!
There was an error while loading. Please reload this page.
HirId-ify hir::BodyId - #58167
Conversation
rust-highfive
commented
Feb 4, 2019
(rust_highfive has picked a reviewer for you, use r? to override) |
ljedrz
commented
Feb 4, 2019
r? @Zoxc |
rust-highfive
commented
Feb 4, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
ljedrz
commented
Feb 5, 2019
@Zoxc I've looked at stack traces, but I'm not too savvy with codegen; any suggestions on how I could tackle this? |
Zoxc
commented
Feb 5, 2019
Mind posting a stack trace? =P |
Uh oh!
There was an error while loading. Please reload this page.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Maybe you should add a Display impl for HirId?
There was a problem hiding this comment.
I'd probably prefer to do it in a separate PR, but sure, why not; how would you suggest it should look like?
There was a problem hiding this comment.
You can probably just call the Debug impl for now, and then just revert the changes to use {:?}
Zoxc
commented
Feb 5, 2019
I've looked over this and didn't spot anything else that is wrong. |
ljedrz
commented
Feb 5, 2019
@Zoxc Since now the extra |
Zoxc
commented
Feb 5, 2019
@ljedrz Just rebase them to remove the commit. I like to use |
ljedrz
commented
Feb 5, 2019
Rebased. |
Zoxc
commented
Feb 7, 2019
@bors r+ |
bors
commented
Feb 7, 2019
📌 Commit 07cc606574052298394f41387a18d3912fc4599b has been approved by |
bors
commented
Feb 7, 2019
☔ The latest upstream changes (presumably #58254) made this pull request unmergeable. Please resolve the merge conflicts. |
ljedrz
commented
Feb 7, 2019
Rebased. |
Zoxc
commented
Feb 7, 2019
@bors r+ |
bors
commented
Feb 7, 2019
📌 Commit 221b1c3 has been approved by |
bors
commented
Feb 12, 2019
📌 Commit 932d7e40f7b54d302dd3695f8324663912654d11 has been approved by |
bors
commented
Feb 12, 2019
☔ The latest upstream changes (presumably #58341) made this pull request unmergeable. Please resolve the merge conflicts. |
932d7e4 to
eac43ccCompareljedrz
commented
Feb 13, 2019
Rebased. |
Zoxc
commented
Feb 13, 2019
@bors r+ |
bors
commented
Feb 13, 2019
📌 Commit eac43cc has been approved by |
HirId-ify hir::BodyId Another step towards rust-lang#57578.
HirId-ify hir::BodyId Another step towards rust-lang#57578.
HirId-ify hir::BodyId Another step towards rust-lang#57578.
Rollup of 10 pull requests Successful merges: - #58110 (libpanic_unwind => 2018) - #58167 (HirId-ify hir::BodyId) - #58202 (Ignore future deprecations in #[deprecated]) - #58272 (Cut down on number formating code size) - #58276 (Improve the error messages for missing stability attributes) - #58354 (Fix ICE and invalid filenames in MIR printing code) - #58381 (Only suggest imports if not imported.) - #58386 (Fix#54242) - #58400 (Fix rustc_driver swallowing errors when compilation is stopped) - #58420 (target/uefi: clarify documentation) Failed merges: r? @ghost
It is now a newtype'd HirId, not NodeId. See rust-lang/rust#58167.
It is now a newtype'd HirId, not NodeId. See rust-lang/rust#58167.
It is now a newtype'd HirId, not NodeId. See rust-lang/rust#58167.
Another step towards #57578.