Skip to content

Fix ICE and invalid filenames in MIR printing code - #58354

Merged
bors merged 2 commits into
rust-lang:masterfrom
matthewjasper:mir-dump-fixes
Feb 14, 2019
Merged

Fix ICE and invalid filenames in MIR printing code#58354
bors merged 2 commits into
rust-lang:masterfrom
matthewjasper:mir-dump-fixes

Conversation

@matthewjasper

@matthewjaspermatthewjasper commented Feb 10, 2019

Copy link
Copy Markdown
Contributor
  • Don't panic when printing MIR for associated constants
  • Don't use < and > in filenames, since they aren't allowed on Windows.

r? @eddyb

cc @RalfJung

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 10, 2019
@RalfJung

RalfJung commented Feb 10, 2019

Copy link
Copy Markdown
Member
* Don't panic when printing MIR for associated constants

Maybe one of the mir-opt tests should get an associated const, just as a regression test for this?

wesleywiser
wesleywiser approved these changes Feb 13, 2019
View reviewed changes

@wesleywiserwesleywiser left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wesleywiser

wesleywiser commented Feb 13, 2019

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Feb 13, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit d7afd3e has been approved by wesleywiser

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 13, 2019
Centril added a commit to Centril/rust that referenced this pull request Feb 13, 2019
@Centril
Rollup merge ofrust-lang#58354- matthewjasper:mir-dump-fixes, r=wes…
e35e9ee
…leywiser
Fix ICE and invalid filenames in MIR printing code
* Don't panic when printing MIR for associated constants
* Don't use `<` and `>` in filenames, since they aren't allowed on Windows.
r? @eddyb
cc @RalfJung
@CentrilCentril mentioned this pull request Feb 13, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Feb 13, 2019
@Centril
Rollup merge ofrust-lang#58354- matthewjasper:mir-dump-fixes, r=wes…
9d46076
…leywiser
Fix ICE and invalid filenames in MIR printing code
* Don't panic when printing MIR for associated constants
* Don't use `<` and `>` in filenames, since they aren't allowed on Windows.
r? @eddyb
cc @RalfJung
@CentrilCentril mentioned this pull request Feb 13, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Feb 13, 2019
@Centril
Rollup merge ofrust-lang#58354- matthewjasper:mir-dump-fixes, r=wes…
b39b625
…leywiser
Fix ICE and invalid filenames in MIR printing code
* Don't panic when printing MIR for associated constants
* Don't use `<` and `>` in filenames, since they aren't allowed on Windows.
r? @eddyb
cc @RalfJung
@CentrilCentril mentioned this pull request Feb 13, 2019
Merged
bors added a commit that referenced this pull request Feb 13, 2019
@bors
Auto merge of#58432- Centril:rollup, r=Centril
4772dc8
Rollup of 10 pull requests
Successful merges:
- #58110 (libpanic_unwind => 2018)
- #58167 (HirId-ify hir::BodyId)
- #58202 (Ignore future deprecations in #[deprecated])
- #58272 (Cut down on number formating code size)
- #58276 (Improve the error messages for missing stability attributes)
- #58354 (Fix ICE and invalid filenames in MIR printing code)
- #58381 (Only suggest imports if not imported.)
- #58386 (Fix#54242)
- #58400 (Fix rustc_driver swallowing errors when compilation is stopped)
- #58420 (target/uefi: clarify documentation)
Failed merges:
r? @ghost
@bors
bors merged commit d7afd3e into rust-lang:masterFeb 14, 2019
@matthewjasper
matthewjasper deleted the mir-dump-fixes branch February 23, 2019 18:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesleywiserwesleywiserwesleywiser approved these changes

Assignees

@eddybeddyb

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@matthewjasper@RalfJung@wesleywiser@bors@eddyb@rust-highfive