Uh oh!
There was an error while loading. Please reload this page.
Only insert nodes which changes lint levels in the LintLevelMap - #58176
Conversation
rust-highfive
commented
Feb 5, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Zoxc
commented
Feb 5, 2019
@bors try |
bors
commented
Feb 5, 2019
⌛ Trying commit 76b688633cd55ff5ee282a70fc1790d229f539b1 with merge 0677dc2b768296023b6cb338d6afbdc5ab0be878... |
bors
commented
Feb 5, 2019
☀️ Test successful - checks-travis |
Zoxc
commented
Feb 5, 2019
@rust-timer build 0677dc2b768296023b6cb338d6afbdc5ab0be878 |
rust-timer
commented
Feb 5, 2019
Success: Queued 0677dc2b768296023b6cb338d6afbdc5ab0be878 with parent b2c6b8c, comparison URL. |
rust-timer
commented
Feb 5, 2019
Finished benchmarking try commit 0677dc2b768296023b6cb338d6afbdc5ab0be878 |
1d97ce4 to
59c6c5aCompareZoxc
commented
Feb 6, 2019
@bors try |
bors
commented
Feb 6, 2019
[WIP] Only insert nodes which changes lint levels in the LintLevelMap r? @eddyb
rust-highfive
commented
Feb 6, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Zoxc
commented
Feb 6, 2019
@bors try |
bors
commented
Feb 6, 2019
Only insert nodes which changes lint levels in the LintLevelMap r? @eddyb
bors
commented
Feb 6, 2019
☀️ Test successful - checks-travis |
Zoxc
commented
Feb 6, 2019
@rust-timer build f94acd0 |
rust-timer
commented
Feb 6, 2019
Success: Queued f94acd0 with parent 65e647c, comparison URL. |
rust-timer
commented
Feb 6, 2019
Finished benchmarking try commit f94acd0 |
Zoxc
commented
Feb 6, 2019
@bors try |
bors
commented
Feb 6, 2019
⌛ Trying commit 776e2eacdd50eae29db3d72949bada4ea43659fe with merge 74c0b1340d42de21d4d37f561338cbab04a9e6e2... |
Zoxc
commented
Mar 5, 2019
@oli-obk I don't know how to run clippy locally. I just get |
Zoxc
commented
Mar 5, 2019
@bors try |
bors
commented
Mar 5, 2019
Only insert nodes which changes lint levels in the LintLevelMap r? @eddyb
oli-obk
commented
Mar 5, 2019
How did you run it? |
Zoxc
commented
Mar 5, 2019
I set the |
bors
commented
Mar 5, 2019
☀️ Try build successful - checks-travis |
Zoxc
commented
Mar 5, 2019
@rust-timer build f2f65c8 |
rust-timer
commented
Mar 5, 2019
Success: Queued f2f65c8 with parent f22dca0, comparison URL. |
rust-timer
commented
Mar 7, 2019
Finished benchmarking try commit f2f65c8 |
oli-obk
commented
Mar 7, 2019
perf is mixed, but max-rss seems mostly positive |
Manishearth
commented
Mar 8, 2019
Btw, one change I'd like to eventually make is to allow lints to declare that they're pure, i.e. they don't cache any state between
|
Manishearth
commented
Mar 8, 2019
filed #59024 |
Zoxc
commented
Mar 9, 2019
cc @estebank in case you know stuff about lints |
Zoxc
commented
Mar 14, 2019
@oli-obk Are you comfortable approving this? |
oli-obk
commented
Mar 14, 2019
Implementation wise yes, but I'm not happy with the perf regressions. Since this enables actually making lints incremental, which again will be a perf bonus outstripping most of the regressions, I'm going to r+ @bors r+ |
bors
commented
Mar 14, 2019
📌 Commit f07ce55 has been approved by |
Zoxc
commented
Mar 14, 2019
@oli-obk We might be able to get rid of the regressions by storing |
oli-obk
commented
Mar 14, 2019
In order to do that properly we'd need to have different diagnostic systems for early lint passes and late lint passes (as early lint passes don't have |
Zoxc
commented
Mar 14, 2019
I meant to say storing the HIR lint location in the serialized lints, so emitting a lint won't depend on the lint level map. |
Only insert nodes which changes lint levels in the LintLevelMap r? @eddyb
bors
commented
Mar 14, 2019
bors
commented
Mar 14, 2019
☀️ Test successful - checks-travis, status-appveyor |
r? @eddyb