Check the Self-type of inherent associated constants

[matthewjasper]

r? @arielb1

[matthewjasper]

Removed the overlap with #58371

[arielb1]

~~Is there some justification for why these checks are enough?~~Found it

If there is, could you write it in a comment?

[arielb1]

Even if these checks are enough, shouldn't they be run on the pair (substs, ty)? i.e.

let types = (substs, ty);// yes there are TypeFoldable impls for pairs and optionsif types.has_free_regions() || types.has_projections() || types.has_infer_types(){// ...}

[arielb1]

Nah I've seen a comment at https://github.com/rust-lang/rust/blob/a7ae7a21624952f5bfc6aaf88e53351385b89dd4/src/librustc_typeck/check/mod.rs#L2436-L2444

Maybe move the check there it to a separate function (needs_user_type_annotation), while still doing the types trick (where T: TypeFoldable<'tcx> on that function, and then call it)?

[arielb1]

r=me with the needs_user_type_annotation function

[arielb1]

@bors r+

[bors]

📌 Commit 283ffcf has been approved by arielb1

[bors]

⌛ Testing commit 283ffcf with merge df4ed96c920c6fe2ae1b95fac48321e46808be0b...

[emilyalbini]

@bors treeclosed=1000

[bors]

💔 Test failed - checks-travis

[rust-highfive]

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[emilyalbini]

@bors retry -- apparently we can't clone the repo anymore on macOS