Skip to content

Add expected/provided byte alignments to validation error message - #58658

Merged
bors merged 4 commits into
rust-lang:masterfrom
pmccarter:align_msg
Feb 23, 2019
Merged

Add expected/provided byte alignments to validation error message#58658
bors merged 4 commits into
rust-lang:masterfrom
pmccarter:align_msg

Conversation

@pmccarter

Copy link
Copy Markdown
Contributor

Fixes#58617

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 22, 2019
Comment threadsrc/librustc_mir/interpret/validity.rs Outdated
@matthewjasper

Copy link
Copy Markdown
Contributor

r=me with comment addressed

cc @oli-obk

@rust-highfive

This comment has been minimized.

@rust-highfive

This comment has been minimized.

@Centril

Copy link
Copy Markdown
Contributor

@bors r=matthewjasper

@bors

bors commented Feb 23, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit d0c110f has been approved by matthewjasper

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2019
Centril added a commit to Centril/rust that referenced this pull request Feb 23, 2019
Add expected/provided byte alignments to validation error message
Fixesrust-lang#58617
@CentrilCentril mentioned this pull request Feb 23, 2019
Centril added a commit to Centril/rust that referenced this pull request Feb 23, 2019
Add expected/provided byte alignments to validation error message
Fixesrust-lang#58617
@CentrilCentril mentioned this pull request Feb 23, 2019
bors added a commit that referenced this pull request Feb 23, 2019
Rollup of 16 pull requests
Successful merges:
- #58100 (Transition librustdoc to Rust 2018)
- #58122 (RangeInclusive internal iteration performance improvement.)
- #58199 (Add better error message for partial move)
- #58227 (Updated RELEASES.md for 1.33.0)
- #58353 (Check the Self-type of inherent associated constants)
- #58453 (SGX target: fix panic = abort)
- #58476 (Remove `LazyTokenStream`.)
- #58526 (Special suggestion for illegal unicode curly quote pairs)
- #58595 (Turn duration consts into associated consts)
- #58609 (Allow Self::Module to be mutated.)
- #58628 (Optimise vec![false; N] to zero-alloc)
- #58643 (Don't generate minification variables if minification disabled)
- #58648 (Update tests to account for cross-platform testing and miri.)
- #58654 (Do not underflow after resetting unmatched braces count)
- #58658 (Add expected/provided byte alignments to validation error message)
- #58667 (Reduce Miri-related Code Repetition `like (n << amt) >> amt`)
Failed merges:
r? @ghost
@bors
bors merged commit d0c110f into rust-lang:masterFeb 23, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@pmccarter@rust-highfive@matthewjasper@Centril@bors