Skip to content

Parse lifetimes that start with a number and give specific error - #58876

Merged
bors merged 2 commits into
rust-lang:masterfrom
estebank:numeric-lifetime
Mar 13, 2019
Merged

Parse lifetimes that start with a number and give specific error#58876
bors merged 2 commits into
rust-lang:masterfrom
estebank:numeric-lifetime

Conversation

@estebank

Copy link
Copy Markdown
Contributor

Fix#58786.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 2, 2019
Comment threadsrc/libsyntax/parse/lexer/mod.rs Outdated
@estebank

Copy link
Copy Markdown
ContributorAuthor

r? @petrochenkov

Comment threadsrc/libsyntax/parse/lexer/mod.rs Outdated
Comment threadsrc/libsyntax/parse/lexer/mod.rs Outdated
@petrochenkov

Copy link
Copy Markdown
Contributor

r=me with comments addressed

@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 8, 2019
@estebank
estebankforce-pushed the numeric-lifetime branch 2 times, most recently from c7b3433 to cd61edaCompareMarch 8, 2019 21:29
@rust-highfive

This comment has been minimized.

@rust-highfive

This comment has been minimized.

@rust-highfive

This comment has been minimized.

@estebank
estebankforce-pushed the numeric-lifetime branch 2 times, most recently from 63e071d to 61596bbCompareMarch 9, 2019 01:55
@estebank

Copy link
Copy Markdown
ContributorAuthor

@bors r=petrochenkov rollup

@bors

bors commented Mar 9, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 61596bbd4744b43d390ec2bd0ea1afe8f26dccaf has been approved by petrochenkov

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 9, 2019
Comment threadsrc/libsyntax/parse/lexer/mod.rs Outdated
@petrochenkov

Copy link
Copy Markdown
Contributor

@bors r-

@borsbors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 9, 2019
@estebank

Copy link
Copy Markdown
ContributorAuthor

@bors r=petrochenkov

@bors

bors commented Mar 9, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit f690821 has been approved by petrochenkov

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 9, 2019
Centril added a commit to Centril/rust that referenced this pull request Mar 10, 2019
…henkov
Parse lifetimes that start with a number and give specific error
Fixrust-lang#58786.
@CentrilCentril mentioned this pull request Mar 10, 2019
Centril added a commit to Centril/rust that referenced this pull request Mar 10, 2019
…henkov
Parse lifetimes that start with a number and give specific error
Fixrust-lang#58786.
@CentrilCentril mentioned this pull request Mar 10, 2019
Centril added a commit to Centril/rust that referenced this pull request Mar 10, 2019
…henkov
Parse lifetimes that start with a number and give specific error
Fixrust-lang#58786.
@CentrilCentril mentioned this pull request Mar 10, 2019
Centril added a commit to Centril/rust that referenced this pull request Mar 10, 2019
…henkov
Parse lifetimes that start with a number and give specific error
Fixrust-lang#58786.
@CentrilCentril mentioned this pull request Mar 10, 2019
Centril added a commit to Centril/rust that referenced this pull request Mar 11, 2019
…henkov
Parse lifetimes that start with a number and give specific error
Fixrust-lang#58786.
@CentrilCentril mentioned this pull request Mar 11, 2019
kennytm added a commit to kennytm/rust that referenced this pull request Mar 11, 2019
…henkov
Parse lifetimes that start with a number and give specific error
Fixrust-lang#58786.
@kennytmkennytm mentioned this pull request Mar 11, 2019
emilyalbini added a commit to emilyalbini/rust that referenced this pull request Mar 12, 2019
…henkov
Parse lifetimes that start with a number and give specific error
Fixrust-lang#58786.
Centril added a commit to Centril/rust that referenced this pull request Mar 13, 2019
…henkov
Parse lifetimes that start with a number and give specific error
Fixrust-lang#58786.
@CentrilCentril mentioned this pull request Mar 13, 2019
bors added a commit that referenced this pull request Mar 13, 2019
Rollup of 16 pull requests
Successful merges:
- #58829 (librustc_interface: Update scoped-tls to 1.0)
- #58876 (Parse lifetimes that start with a number and give specific error)
- #58908 (Update rand version)
- #58998 (Fix documentation of from_ne_bytes and from_le_bytes)
- #59056 (Use lifetime contravariance to elide more lifetimes in core+alloc+std)
- #59057 (Standardize `Range*` documentation)
- #59080 (Fix incorrect links in librustc_codegen_llvm documentation)
- #59083 (Fix#54822 and associated faulty tests)
- #59093 (Remove precompute_in_scope_traits_hashes)
- #59101 (Reduces Code Repetitions like `!n >> amt`)
- #59121 (impl FromIterator for Result: Use assert_eq! instead of assert!)
- #59124 (Replace assert with assert_eq)
- #59129 (Visit impl Trait for dead_code lint)
- #59130 (Note that NonNull does not launder shared references for mutation)
- #59132 (ignore higher-ranked object bound conditions created by WF)
- #59138 (Simplify Iterator::{min, max})
Failed merges:
r? @ghost
@bors
bors merged commit f690821 into rust-lang:masterMar 13, 2019
@matkladmatklad mentioned this pull request Apr 29, 2019
5 tasks
@estebank
estebank deleted the numeric-lifetime branch November 9, 2023 05:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@estebank@rust-highfive@petrochenkov@bors@VirrageS@bjorn3@michaelwoerister