Skip to content

Replace assert with assert_eq - #59124

Closed
ohsayan wants to merge 1 commit into
rust-lang:masterfrom
ohsayan:master
Closed

Replace assert with assert_eq#59124
ohsayan wants to merge 1 commit into
rust-lang:masterfrom
ohsayan:master

Conversation

@ohsayan

@ohsayanohsayan commented Mar 12, 2019

Copy link
Copy Markdown
Contributor

Use assert_eq! instead of assert! for the tests

@rust-highfive

rust-highfive commented Mar 12, 2019

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cramertj (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 12, 2019
@ohsayanohsayan changed the title Replace assert with assert_eq for better debuggingReplace assert with assert_eqMar 12, 2019
@ohsayan

ohsayan commented Mar 12, 2019

Copy link
Copy Markdown
ContributorAuthor

r? @Centril

@Centril

Centril commented Mar 12, 2019

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Mar 12, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 365d918 has been approved by Centril

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2019
@ohsayan

ohsayan commented Mar 12, 2019

Copy link
Copy Markdown
ContributorAuthor

@Centril Checks complete

emilyalbini added a commit to emilyalbini/rust that referenced this pull request Mar 12, 2019
@emilyalbini
Rollup merge ofrust-lang#59124- sntdevco:master, r=Centril
247aa67
Replace assert with assert_eq
Use `assert_eq!` instead of `assert!` for the tests
@emilyalbiniemilyalbini mentioned this pull request Mar 12, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Mar 13, 2019
@Centril
Rollup merge ofrust-lang#59124- sntdevco:master, r=Centril
f3dc046
Replace assert with assert_eq
Use `assert_eq!` instead of `assert!` for the tests
@CentrilCentril mentioned this pull request Mar 13, 2019
Merged
bors added a commit that referenced this pull request Mar 13, 2019
@bors
Auto merge of#59151- Centril:rollup, r=Centril
aa97448
Rollup of 16 pull requests
Successful merges:
- #58829 (librustc_interface: Update scoped-tls to 1.0)
- #58876 (Parse lifetimes that start with a number and give specific error)
- #58908 (Update rand version)
- #58998 (Fix documentation of from_ne_bytes and from_le_bytes)
- #59056 (Use lifetime contravariance to elide more lifetimes in core+alloc+std)
- #59057 (Standardize `Range*` documentation)
- #59080 (Fix incorrect links in librustc_codegen_llvm documentation)
- #59083 (Fix#54822 and associated faulty tests)
- #59093 (Remove precompute_in_scope_traits_hashes)
- #59101 (Reduces Code Repetitions like `!n >> amt`)
- #59121 (impl FromIterator for Result: Use assert_eq! instead of assert!)
- #59124 (Replace assert with assert_eq)
- #59129 (Visit impl Trait for dead_code lint)
- #59130 (Note that NonNull does not launder shared references for mutation)
- #59132 (ignore higher-ranked object bound conditions created by WF)
- #59138 (Simplify Iterator::{min, max})
Failed merges:
r? @ghost
@tesuji

tesuji commented Mar 13, 2019

Copy link
Copy Markdown
Contributor

@sntdevco You should use git revert to revert commit rather then re-adding deleted lines.

@ohsayan

ohsayan commented Mar 13, 2019

Copy link
Copy Markdown
ContributorAuthor

@sntdevco You should use git revert to revert commit rather then re-adding deleted lines.

Was in a hurry. Will revert straight away!

@Centril

Centril commented Mar 13, 2019

Copy link
Copy Markdown
Contributor

I believe the first commit of this PR, before changes to it, was merged in #59151 so I'll close this as done.

@CentrilCentril closed this Mar 13, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@CentrilCentril

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ohsayan@rust-highfive@Centril@bors@tesuji@cramertj