Skip to content

libcore: vec::windowed iterates, not allocates. - #5904

Merged
bors merged 1 commit into
rust-lang:incomingfrom
huonw:core-vec-windowed
Apr 16, 2013
Merged

libcore: vec::windowed iterates, not allocates.#5904
bors merged 1 commit into
rust-lang:incomingfrom
huonw:core-vec-windowed

Conversation

@huonw

Copy link
Copy Markdown
Contributor

And add some documentation.

bors added a commit that referenced this pull request Apr 16, 2013
@borsbors closed this Apr 16, 2013
@bors
bors merged commit 21723d5 into rust-lang:incomingApr 16, 2013
@huonw
huonw deleted the core-vec-windowed branch April 19, 2013 07:26
U007D pushed a commit to U007D/rust-mos that referenced this pull request Aug 21, 2026
8774: feat: Honor `.cargo/config.toml` r=matklad a=Veykril
![f1Gup1aiAn](https://user-images.githubusercontent.com/3757771/117545448-1dcaae00-b026-11eb-977a-0f35a5e3f2e0.gif)
Implements `cargo/.config` build target and cfg access by using unstable cargo options:
- `cargo config get` to read the target triple out of the config to pass to `cargo metadata` --filter-platform
- `cargo rustc --print` to read out the `rustc_cfgs`, this causes us to honor `rustflags` and the like.
If those commands fail, due to not having a nightly toolchain present for example, they will fall back to invoking rustc directly as we currently do.
I personally think it should be fine to use these unstable options as they are unlikely to change(even if they did it shouldn't be a problem due to the fallback) and don't burden the user if they do not have a nightly toolchain at hand since we fall back to the previous behaviour.
cc rust-lang#8741Closesrust-lang#6604, Closesrust-lang#5904, Closesrust-lang#8430, Closesrust-lang#8480
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@huonw@thestinger@bors