Uh oh!
There was an error while loading. Please reload this page.
Remove unnecessary return - #8480
Closed
emberian wants to merge 1 commit into
Closed
Conversation
emberian
commented
Aug 14, 2013
ContributorAuthor
rollup candidate |
bors added a commit
that referenced
this pull request
Aug 15, 2013
flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
May 5, 2022
…r=xFrednet wrong_self_convention allows `is_*` to take `&mut self` fixrust-lang#8480 and rust-lang#8513 Allowing `is_*` to take `&self` or none is too restrictive. changelog: FPs: [`wrong_self_convention`] now allows `&mut self` and no self as arguments for `is_*` methods
U007D pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
8774: feat: Honor `.cargo/config.toml` r=matklad a=Veykril  Implements `cargo/.config` build target and cfg access by using unstable cargo options: - `cargo config get` to read the target triple out of the config to pass to `cargo metadata` --filter-platform - `cargo rustc --print` to read out the `rustc_cfgs`, this causes us to honor `rustflags` and the like. If those commands fail, due to not having a nightly toolchain present for example, they will fall back to invoking rustc directly as we currently do. I personally think it should be fine to use these unstable options as they are unlikely to change(even if they did it shouldn't be a problem due to the fallback) and don't burden the user if they do not have a nightly toolchain at hand since we fall back to the previous behaviour. cc rust-lang#8741Closesrust-lang#6604, Closesrust-lang#5904, Closesrust-lang#8430, Closesrust-lang#8480 Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.