Skip to content

Turn HIR lowering into a query - #59205

Closed
Zoxc wants to merge 4 commits into
rust-lang:masterfrom
Zoxc:query-hir-lowering
Closed

Turn HIR lowering into a query#59205
Zoxc wants to merge 4 commits into
rust-lang:masterfrom
Zoxc:query-hir-lowering

Conversation

@Zoxc

@ZoxcZoxc commented Mar 15, 2019

Copy link
Copy Markdown
Contributor

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 15, 2019
@Zoxc
Zoxc marked this pull request as ready for review March 15, 2019 10:41
@ZoxcZoxc changed the title Turn HIR lowering into a query[WIP] Turn HIR lowering into a queryMar 15, 2019
@rust-highfive

This comment has been minimized.

@Zoxc
Zoxcforce-pushed the query-hir-lowering branch from ba4c7ea to 7c39053CompareMarch 15, 2019 12:16
@rust-highfive

This comment has been minimized.

@Zoxc
Zoxcforce-pushed the query-hir-lowering branch from 7c39053 to 74b1b48CompareMarch 15, 2019 12:38
@ZoxcZoxc mentioned this pull request Mar 15, 2019
@rust-highfive

This comment has been minimized.

@bors

bors commented Mar 15, 2019

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #58140) made this pull request unmergeable. Please resolve the merge conflicts.

@Zoxc
Zoxcforce-pushed the query-hir-lowering branch from 74b1b48 to fa6e22eCompareMarch 18, 2019 12:48
@rust-highfive

This comment has been minimized.

@Zoxc
Zoxcforce-pushed the query-hir-lowering branch 2 times, most recently from 128a05b to 333d1acCompareMarch 18, 2019 16:46
@rust-highfive

This comment has been minimized.

@rust-highfive

This comment has been minimized.

@bors

This comment has been minimized.

@Zoxc
Zoxcforce-pushed the query-hir-lowering branch from f021021 to a05ed38CompareMarch 19, 2019 10:09
@rust-highfive

This comment has been minimized.

@Zoxc
Zoxcforce-pushed the query-hir-lowering branch from a05ed38 to 29ae535CompareMarch 19, 2019 12:52
@rust-highfive

This comment has been minimized.

@Zoxc
Zoxcforce-pushed the query-hir-lowering branch from 29ae535 to fae8407CompareMarch 19, 2019 16:19
@rust-highfive

This comment has been minimized.

@Zoxc
Zoxcforce-pushed the query-hir-lowering branch from fae8407 to a029f64CompareMarch 19, 2019 17:25
@rust-highfive

This comment has been minimized.

@Zoxc
Zoxcforce-pushed the query-hir-lowering branch from a029f64 to 14dc3c6CompareMarch 19, 2019 21:03
@Zoxc
Zoxcforce-pushed the query-hir-lowering branch from feab4e7 to a3dd75dCompareApril 9, 2019 09:36
@bors

This comment has been minimized.

@Zoxc
Zoxcforce-pushed the query-hir-lowering branch from a3dd75d to 0ca3a92CompareApril 13, 2019 12:26
@bors

This comment has been minimized.

@Zoxc
Zoxcforce-pushed the query-hir-lowering branch from 0ca3a92 to 9626842CompareApril 24, 2019 15:37
@bors

This comment has been minimized.

@Zoxc
Zoxcforce-pushed the query-hir-lowering branch from 9626842 to 7099d33CompareMay 5, 2019 09:18
@bors

bors commented May 6, 2019

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #60567) made this pull request unmergeable. Please resolve the merge conflicts.

This was referenced May 18, 2019
@Mark-SimulacrumMark-Simulacrum added S-blocked-closed and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 18, 2019
@Mark-Simulacrum

Copy link
Copy Markdown
Member

Visiting from triage, I'm closing the series of PRs here other than the first one since they will likely only make progress sequentially and it doesn't help to have all of them open. For reference, this is blocked on #59064.

Feel free to reopen as that PR merges and/or makes progress.

@ZoxcZoxc reopened this Jun 18, 2019
@Zoxc
Zoxcforce-pushed the query-hir-lowering branch 2 times, most recently from be56785 to 744ed04CompareJune 18, 2019 22:27
@jonas-schievinkjonas-schievink added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked-closed labels Jun 22, 2019
@Zoxc
Zoxcforce-pushed the query-hir-lowering branch from 744ed04 to 9504524CompareJune 27, 2019 11:40
@Zoxc
Zoxcforce-pushed the query-hir-lowering branch from 9504524 to a7c010dCompareJuly 8, 2019 14:21
@Mark-SimulacrumMark-Simulacrum added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2019
@ZoxcZoxc closed this Dec 22, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-blockedStatus: Blocked on something else such as an RFC or other implementation work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@Zoxc@rust-highfive@bors@rust-timer@Mark-Simulacrum@jonas-schievink@michaelwoerister