Skip to content

Make ongoing_codegen a query - #59404

Closed
Zoxc wants to merge 9 commits into
rust-lang:masterfrom
Zoxc:query-codegen
Closed

Make ongoing_codegen a query#59404
Zoxc wants to merge 9 commits into
rust-lang:masterfrom
Zoxc:query-codegen

Conversation

@Zoxc

@ZoxcZoxc commented Mar 24, 2019

Copy link
Copy Markdown
Contributor

Builds on #59338.

@rust-highfive

rust-highfive commented Mar 24, 2019

Copy link
Copy Markdown
Contributor

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 24, 2019
@petrochenkov

petrochenkov commented Mar 24, 2019

Copy link
Copy Markdown
Contributor

r? @michaelwoerister

@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@ZoxcZoxc changed the title [WIP] Make ongoing_codegen a queryMake ongoing_codegen a queryMar 26, 2019
@bors

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@ZoxcZoxc mentioned this pull request Apr 12, 2019
Closed
@bors

bors commented Apr 12, 2019

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #59536) made this pull request unmergeable. Please resolve the merge conflicts.

@bors

bors commented Apr 13, 2019

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #59515) made this pull request unmergeable. Please resolve the merge conflicts.

@Dylan-DPC-zz

Dylan-DPC-zz commented Apr 22, 2019

Copy link
Copy Markdown

ping from triage @michaelwoerister waiting for your review on this

@Mark-SimulacrumMark-Simulacrum added S-blocked-closed and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 18, 2019
@Mark-Simulacrum

Mark-Simulacrum commented May 18, 2019

Copy link
Copy Markdown
Member

Visiting from triage, I'm closing the series of PRs here other than the first one since they will likely only make progress sequentially and it doesn't help to have all of them open. For reference, this is #59404, #59338, #59282, and #59205 which are (in that order) blocked on each other and eventually #59064.

Feel free to reopen as those PRs merge and/or make progress.

@Mark-SimulacrumMark-Simulacrum mentioned this pull request May 18, 2019
Closed
@ZoxcZoxc reopened this Jun 18, 2019
@bors

bors commented Jun 22, 2019

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #62041) made this pull request unmergeable. Please resolve the merge conflicts.

@borsbors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 22, 2019
@hdhoang

hdhoang commented Aug 2, 2019

Copy link
Copy Markdown
Contributor

ping from triage @Zoxc, any update on this PR and its series?

@JohnCSimon

JohnCSimon commented Aug 10, 2019

Copy link
Copy Markdown

Ping from triage again @michaelwoerister@Mark-Simulacrum this has sat idle for months. Can you please resolve the merge conflicts?
Thank you!

@JohnCSimon

JohnCSimon commented Aug 17, 2019

Copy link
Copy Markdown

@Zoxc@michaelwoerister@Mark-Simulacrum
Unfortunately I'm going to have to close this PR. I'm not sure what else can be done with this.

@JohnCSimonJohnCSimon added the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Aug 17, 2019
@nnethercotennethercote mentioned this pull request Sep 6, 2019
Merged
@pnkfelixpnkfelix mentioned this pull request Sep 17, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@michaelwoeristermichaelwoerister

Labels

S-inactiveStatus: Inactive and waiting on the author. This is often applied to closed PRs.S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Zoxc@rust-highfive@petrochenkov@bors@Dylan-DPC-zz@Mark-Simulacrum@hdhoang@JohnCSimon@michaelwoerister