Uh oh!
There was an error while loading. Please reload this page.
Rollup of 9 pull requests - #59244
Closed
Centril wants to merge 31 commits into
Closed
Conversation
Co-Authored-By: kennytm <kennytm@gmail.com>
…);` and potentially instantiated at different types. (Updated to reflect changes in diagnostic output and compiletest infrastructure.)
…constraints-on-bindings-too, r=nikomatsakis extra testing of how NLL handles wildcard type `_` test that wildcard type `_` is not duplicated by `type Foo<X> = (X, X);` and potentially instantiated at different types when used in type ascriptions in let bindings. (NLL's handling of this for the type ascription *expression form* is currently broken, or at least differs from what AST-borrowck does. I'll file a separate bug about that. Its not something critical to address since that expression is guarded by `#![feature(type_ascription)]`.) cc rust-lang#55748
…alexcrichton Refactor tools/build-mainfest I saw some duplication in rust-lang#58990 and got an itch... Will likely need to be rebased when that lands. Hopefully the PR should have zero semantic changes... r? @alexcrichton
…twco
When encountetring `||{}()`, suggest the likely intended `(||{})()`
Fixrust-lang#55851.Track embedded-book in the toolstate The embedded book was tested in the tools job but the test result was never published. This PR adds maintainer information of embedded-book. This PR also requires the next update to embedded-book to pass the all tests, currently its state is test-fail. rust-lang-nursery/rust-toolstate#10 should be merged before this PR.
resolve: Account for new importable entities Fixes the ICE encountered in rust-lang#58837 r? @Centril
…r=Zoxc HirIdification: kill off NodeId stragglers The final stages of HirIdification (rust-lang#57578). This PR, along with rust-lang#59042, should finalize the HirIdification process (at least the more straightforward bits). - replace `NodeId` with `HirId` in `trait_impls` - remove all `NodeId`s from `borrowck` - remove all `NodeId`s from `typeck` - remove all `NodeId`s from `mir` - remove `trait_auto_impl` (unused) I would be cool to also remove `NodeId` from `hir::def::Def`, `middle::privacy::AccessLevel` and `hir::ItemId`, but I don't know if this is feasible. I'll be happy to do more if I've missed anything.
middle: replace NodeId with HirId in AccessLevels Pushing the limits of HirIdification (rust-lang#57578). Replaces `NodeId` with `HirId` in `middle::privacy::AccessLevels`. Actually this time I was more successful and cracked it; I probably tried to HirIdify too much at once when I attempted it last time ^^. r? @Zoxc
Add peer_addr function to UdpSocket Fixesrust-lang#59104 This is my first pull request to Rust, so opening early for some feedback. My biggest question is: where do I add tests? Any comments very much appreciated!
bors
commented
Mar 17, 2019
Collaborator
⌛ Testing commit 1729852 with merge 265ee58b4e3a32f3df5bac5bb586ad93541d1d5b... |
bors
commented
Mar 17, 2019
Collaborator
💔 Test failed - checks-travis |
rust-highfive
commented
Mar 17, 2019
Contributor
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
kennytm
commented
Mar 17, 2019
Member
bors
commented
Mar 17, 2019
Collaborator
⌛ Testing commit 1729852 with merge a8950e119b9727ffce42e49d04b1902455b7d763... |
bors
commented
Mar 17, 2019
Collaborator
💔 Test failed - checks-travis |
rust-highfive
commented
Mar 17, 2019
Contributor
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Centril
commented
Mar 17, 2019
ContributorAuthor
@bors retry |
bors
commented
Mar 17, 2019
Collaborator
⌛ Testing commit 1729852 with merge 955c98366aa4dfe9d5e169871efa0b7f6749c11f... |
bors
commented
Mar 17, 2019
Collaborator
💔 Test failed - checks-travis |
rust-highfive
commented
Mar 17, 2019
Contributor
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
kennytm
commented
Mar 17, 2019
Member
Perhaps exclude #59038 from the rollup? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
_#57729 (extra testing of how NLL handles wildcard type_)||{}(), suggest the likely intended(||{})()#59035 (When encountetring||{}(), suggest the likely intended(||{})())Failed merges:
r? @ghost