Skip to content

Account for short-hand field syntax when suggesting borrow - #59455

Merged
bors merged 4 commits into
rust-lang:masterfrom
estebank:borrow-sugg-shorthand-field
Mar 30, 2019
Merged

Account for short-hand field syntax when suggesting borrow#59455
bors merged 4 commits into
rust-lang:masterfrom
estebank:borrow-sugg-shorthand-field

Conversation

@estebank

@estebankestebank commented Mar 27, 2019

Copy link
Copy Markdown
Contributor

Fix#52965.

@rust-highfive

rust-highfive commented Mar 27, 2019

Copy link
Copy Markdown
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 27, 2019
@estebank

estebank commented Mar 27, 2019

Copy link
Copy Markdown
ContributorAuthor

r? @davidtwco

@rust-highfiverust-highfive assigned davidtwco and unassigned eddybMar 27, 2019
@zackmdaviszackmdavis mentioned this pull request Mar 27, 2019
Closed
Centril
Centril reviewed Mar 27, 2019
View reviewed changes
Comment threadsrc/librustc_typeck/check/demand.rs Outdated
Comment threadsrc/librustc_typeck/check/demand.rs Outdated
davidtwco
davidtwco approved these changes Mar 27, 2019
View reviewed changes

@davidtwcodavidtwco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once @Centril's comments are resolved, r=me.

@estebank
estebankforce-pushed the borrow-sugg-shorthand-field branch from 6bafb91 to b67af6aCompareMarch 29, 2019 03:11
@estebank
estebankforce-pushed the borrow-sugg-shorthand-field branch from b67af6a to 07857f7CompareMarch 29, 2019 03:13
@rust-highfive

This comment has been minimized.

Sign in to view
Centril
Centril reviewed Mar 29, 2019
View reviewed changes
Comment threadsrc/librustc_typeck/check/demand.rs Outdated
Comment threadsrc/librustc_typeck/check/demand.rs Outdated
Comment threadsrc/librustc_typeck/check/demand.rs Outdated
Comment threadsrc/librustc_typeck/check/demand.rs Outdated
@rust-highfive

This comment has been minimized.

Sign in to view
@estebank
estebankforce-pushed the borrow-sugg-shorthand-field branch from 2420173 to 9cbc640CompareMarch 29, 2019 17:44
@rust-highfive

This comment has been minimized.

Sign in to view
@estebank
estebankforce-pushed the borrow-sugg-shorthand-field branch from 9cbc640 to ddfa47fCompareMarch 29, 2019 18:13
@estebank

estebank commented Mar 29, 2019

Copy link
Copy Markdown
ContributorAuthor

@bors r=davidtwco

@bors

bors commented Mar 29, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit ddfa47f has been approved by davidtwco

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 29, 2019
Centril added a commit to Centril/rust that referenced this pull request Mar 29, 2019
@Centril
Rollup merge ofrust-lang#59455- estebank:borrow-sugg-shorthand-fiel…
22c267d
…d, r=davidtwco
Account for short-hand field syntax when suggesting borrow
Fixrust-lang#52965.
@CentrilCentril mentioned this pull request Mar 29, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Mar 30, 2019
@Centril
Rollup merge ofrust-lang#59455- estebank:borrow-sugg-shorthand-fiel…
41e64b6
…d, r=davidtwco
Account for short-hand field syntax when suggesting borrow
Fixrust-lang#52965.
@CentrilCentril mentioned this pull request Mar 30, 2019
Merged
bors added a commit that referenced this pull request Mar 30, 2019
@bors
Auto merge of#59550- Centril:rollup, r=Centril
6c49da4
Rollup of 10 pull requests
Successful merges:
- #59376 (RFC 2008: Enum Variants)
- #59453 (Recover from parse error in tuple syntax)
- #59455 (Account for short-hand field syntax when suggesting borrow)
- #59499 (Fix broken download link in the armhf-gnu image)
- #59512 (implement `AsRawFd` for stdio locks)
- #59525 (Whitelist some rustc attrs)
- #59528 (Improve the dbg! macro docs )
- #59532 (In doc examples, don't ignore read/write results)
- #59534 (rustdoc: collapse blanket impls in the same way as normal impls)
- #59537 (Fix OnceWith docstring.)
Failed merges:
r? @ghost
@bors
bors merged commit ddfa47f into rust-lang:masterMar 30, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidtwcodavidtwcodavidtwco approved these changes
+1 more reviewer
@CentrilCentrilCentril left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@davidtwcodavidtwco

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@estebank@rust-highfive@bors@Centril@davidtwco@eddyb