Uh oh!
There was an error while loading. Please reload this page.
Whitelist some rustc attrs - #59525
Merged
Merged
Conversation
…es not flag them as unused.
rust-highfive
commented
Mar 29, 2019
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
petrochenkov
commented
Mar 29, 2019
Contributor
@bors r+ |
bors
commented
Mar 29, 2019
Collaborator
📌 Commit cbbd4d5 has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
Mar 29, 2019
…, r=petrochenkov Whitelist some rustc attrs These rustc attrs are used within libcore, and were causing failures when one mixed incremental compilation with bootstrapping (due to a default of `-D warnings` when bootstrapping). Fixrust-lang#59523Fixrust-lang#59524 Cc rust-lang#58633
Centril added a commit
to Centril/rust
that referenced
this pull request
Mar 30, 2019
…, r=petrochenkov Whitelist some rustc attrs These rustc attrs are used within libcore, and were causing failures when one mixed incremental compilation with bootstrapping (due to a default of `-D warnings` when bootstrapping). Fixrust-lang#59523Fixrust-lang#59524 Cc rust-lang#58633
bors added a commit
that referenced
this pull request
Mar 30, 2019
Rollup of 10 pull requests Successful merges: - #59376 (RFC 2008: Enum Variants) - #59453 (Recover from parse error in tuple syntax) - #59455 (Account for short-hand field syntax when suggesting borrow) - #59499 (Fix broken download link in the armhf-gnu image) - #59512 (implement `AsRawFd` for stdio locks) - #59525 (Whitelist some rustc attrs) - #59528 (Improve the dbg! macro docs ) - #59532 (In doc examples, don't ignore read/write results) - #59534 (rustdoc: collapse blanket impls in the same way as normal impls) - #59537 (Fix OnceWith docstring.) Failed merges: r? @ghost
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These rustc attrs are used within libcore, and were causing failures when one mixed incremental compilation with bootstrapping (due to a default of
-D warningswhen bootstrapping).Fix#59523
Fix#59524
Cc #58633