Skip to content

Document std::fs::File close behavior ignoring errors - #59470

Merged
bors merged 4 commits into
rust-lang:masterfrom
czipperz:document-fs-file-close
Apr 4, 2019
Merged

Document std::fs::File close behavior ignoring errors#59470
bors merged 4 commits into
rust-lang:masterfrom
czipperz:document-fs-file-close

Conversation

@czipperz

@czipperzczipperz commented Mar 27, 2019

Copy link
Copy Markdown
Contributor

Resolves#52685

@rust-highfive

rust-highfive commented Mar 27, 2019

Copy link
Copy Markdown
Contributor

r? @dtolnay

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 27, 2019
@czipperz

czipperz commented Mar 27, 2019

Copy link
Copy Markdown
ContributorAuthor

As an aside, is there a close method that allows the user to get a std::io::Result for closing a card? That seems like it would be a nice feature.

@Centril

Centril commented Mar 30, 2019

Copy link
Copy Markdown
Contributor

Ping from triage, @dtolnay :)

@czipperz

czipperz commented Mar 30, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@Centril What do you think about adding a close method to File?

fn close(self) -> io::Result<()>

@Centril

Centril commented Mar 30, 2019

Copy link
Copy Markdown
Contributor

@czipperz I have no opinion. :)

@pnkfelixpnkfelix added the T-libs-api [DEPRECATED; DO NOT USE] label Apr 1, 2019
@pnkfelix

pnkfelix commented Apr 1, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

@Centril What do you think about adding a close method to File?

fn close(self) -> io::Result<()>

@dtolnay has previously stated that such a change requires going through the RFC process. See discussion at #32255

Update: and I see the PR author has actually opened an issue dedicated to this question, at #59567

dtolnay
dtolnay requested changes Apr 2, 2019
View reviewed changes

@dtolnaydtolnay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment threadsrc/libstd/fs.rs Outdated
Comment threadsrc/libstd/fs.rs Outdated
Comment threadsrc/libstd/fs.rs Outdated
Comment threadsrc/libstd/fs.rs Outdated
@czipperz

czipperz commented Apr 2, 2019

Copy link
Copy Markdown
ContributorAuthor

@dtolnay Redid the documentation based on comments I've read in other threads.

dtolnay
dtolnay approved these changes Apr 2, 2019
View reviewed changes
Comment threadsrc/libstd/fs.rs Outdated
dtolnay
dtolnay approved these changes Apr 4, 2019
View reviewed changes

@dtolnaydtolnay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.

@dtolnay

dtolnay commented Apr 4, 2019

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Apr 4, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit a969d40 has been approved by dtolnay

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2019
Centril added a commit to Centril/rust that referenced this pull request Apr 4, 2019
@Centril
Rollup merge ofrust-lang#59470- czipperz:document-fs-file-close, r=…
a3a0b7f
…dtolnay
Document std::fs::File close behavior ignoring errors
Resolvesrust-lang#52685
@CentrilCentril mentioned this pull request Apr 4, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Apr 4, 2019
@Centril
Rollup merge ofrust-lang#59470- czipperz:document-fs-file-close, r=…
2e83edc
…dtolnay
Document std::fs::File close behavior ignoring errors
Resolvesrust-lang#52685
@CentrilCentril mentioned this pull request Apr 4, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Apr 4, 2019
@Centril
Rollup merge ofrust-lang#59470- czipperz:document-fs-file-close, r=…
bfb7f34
…dtolnay
Document std::fs::File close behavior ignoring errors
Resolvesrust-lang#52685
@CentrilCentril mentioned this pull request Apr 4, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Apr 4, 2019
@Centril
Rollup merge ofrust-lang#59470- czipperz:document-fs-file-close, r=…
02de76e
…dtolnay
Document std::fs::File close behavior ignoring errors
Resolvesrust-lang#52685
@CentrilCentril mentioned this pull request Apr 4, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Apr 4, 2019
@Centril
Rollup merge ofrust-lang#59470- czipperz:document-fs-file-close, r=…
886456d
…dtolnay
Document std::fs::File close behavior ignoring errors
Resolvesrust-lang#52685
@CentrilCentril mentioned this pull request Apr 4, 2019
Merged
bors added a commit that referenced this pull request Apr 4, 2019
@bors
Auto merge of#59695- Centril:rollup-88qffc2, r=Centril
52980d0
Rollup of 8 pull requests
Successful merges:
- #59470 (Document std::fs::File close behavior ignoring errors)
- #59555 (update miri)
- #59556 (update stdsimd)
- #59596 (Forward formatter settings to bounds of `Range<T>` in `fmt::Debug` impl)
- #59639 (Never return uninhabited values at all)
- #59671 (Make some of lexer's API private)
- #59685 (Add description for -Os and -Oz in rustc.1)
- #59686 (Temporarily disable stack probing for gnux32.)
Failed merges:
r? @ghost
@bors
bors merged commit a969d40 into rust-lang:masterApr 4, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtolnaydtolnaydtolnay approved these changes

Assignees

@dtolnaydtolnay

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@czipperz@rust-highfive@Centril@pnkfelix@dtolnay@bors