Skip to content

Temporarily disable stack probing for gnux32. - #59686

Merged
bors merged 1 commit into
rust-lang:masterfrom
crlf0710:disable_gnux32_stackprobe
Apr 4, 2019
Merged

Temporarily disable stack probing for gnux32.#59686
bors merged 1 commit into
rust-lang:masterfrom
crlf0710:disable_gnux32_stackprobe

Conversation

@crlf0710

Copy link
Copy Markdown
Member

No description provided.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 4, 2019
@crlf0710

Copy link
Copy Markdown
MemberAuthor

This is a temporary workaround for #59674
This (hopefully) unblocks #59500.

@crlf0710crlf0710 mentioned this pull request Apr 4, 2019
Comment threadsrc/librustc_target/spec/x86_64_unknown_linux_gnux32.rs Outdated
@crlf0710

Copy link
Copy Markdown
MemberAuthor

r? @sanxiyn

@rust-highfiverust-highfive assigned sanxiyn and unassigned estebankApr 4, 2019
@crlf0710
crlf0710force-pushed the disable_gnux32_stackprobe branch from 9772daf to 42d652eCompareApril 4, 2019 06:40
@crlf0710

Copy link
Copy Markdown
MemberAuthor

Addressed the review comment above :)

@luqmana

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Apr 4, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 42d652e has been approved by luqmana

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2019
Centril added a commit to Centril/rust that referenced this pull request Apr 4, 2019
… r=luqmana
Temporarily disable stack probing for gnux32.
@CentrilCentril mentioned this pull request Apr 4, 2019
Centril added a commit to Centril/rust that referenced this pull request Apr 4, 2019
… r=luqmana
Temporarily disable stack probing for gnux32.
@CentrilCentril mentioned this pull request Apr 4, 2019
Centril added a commit to Centril/rust that referenced this pull request Apr 4, 2019
… r=luqmana
Temporarily disable stack probing for gnux32.
@CentrilCentril mentioned this pull request Apr 4, 2019
Centril added a commit to Centril/rust that referenced this pull request Apr 4, 2019
… r=luqmana
Temporarily disable stack probing for gnux32.
@CentrilCentril mentioned this pull request Apr 4, 2019
Centril added a commit to Centril/rust that referenced this pull request Apr 4, 2019
… r=luqmana
Temporarily disable stack probing for gnux32.
@CentrilCentril mentioned this pull request Apr 4, 2019
bors added a commit that referenced this pull request Apr 4, 2019
Rollup of 8 pull requests
Successful merges:
- #59470 (Document std::fs::File close behavior ignoring errors)
- #59555 (update miri)
- #59556 (update stdsimd)
- #59596 (Forward formatter settings to bounds of `Range<T>` in `fmt::Debug` impl)
- #59639 (Never return uninhabited values at all)
- #59671 (Make some of lexer's API private)
- #59685 (Add description for -Os and -Oz in rustc.1)
- #59686 (Temporarily disable stack probing for gnux32.)
Failed merges:
r? @ghost
@bors
bors merged commit 42d652e into rust-lang:masterApr 4, 2019
@crlf0710
crlf0710 deleted the disable_gnux32_stackprobe branch April 4, 2019 18:48
Centril added a commit to Centril/rust that referenced this pull request Jul 21, 2019
Revert "Disable stack probing for gnux32."
This reverts commit 42d652e. (rust-lang#59686)
Closesrust-lang#59674.
Centril added a commit to Centril/rust that referenced this pull request Jul 22, 2019
Revert "Disable stack probing for gnux32."
This reverts commit 42d652e. (rust-lang#59686)
Closesrust-lang#59674.
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 23, 2019
Revert "Disable stack probing for gnux32."
This reverts commit 42d652e. (rust-lang#59686)
Closesrust-lang#59674.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@crlf0710@rust-highfive@luqmana@bors@sanxiyn@estebank