Skip to content

Rollup of 2 pull requests - #59939

Closed
Centril wants to merge 82 commits into
rust-lang:masterfrom
Centril:rollup-j4h8pf3
Closed

Rollup of 2 pull requests#59939
Centril wants to merge 82 commits into
rust-lang:masterfrom
Centril:rollup-j4h8pf3

Conversation

@Centril

Copy link
Copy Markdown
Contributor

Successful merges:

Failed merges:

r? @ghost

matthewjasperand others added 30 commits April 1, 2019 19:38
It is now exactly equivalent to lookup_char_pos.
This commit adds a test demonstrating the current behaviour when a macro
defined in a module with the `#[macro_export]` is imported from the
module rather than the crate root.
Implicit promotion on the other hand has very strict rules on what may be done
- Make links relative.
- Adjust links from old 2018-edition book.
- Fix broken link in `let` docs.
This commit implements the `{read,write}_vectored` methods on more types
in the standard library, namely:
* `std::fs::File`
* `std::process::ChildStd{in,out,err}`
* `std::io::Std{in,out,err}`
* `std::io::Std{in,out,err}Lock`
* `std::io::Std{in,out,err}Raw`
Where supported the OS implementations hook up to native support,
otherwise it falls back to the already-defaulted implementation.
Centril added 27 commits April 13, 2019 16:10
…-mut, r=pnkfelix
Mark variables captured by reference as mutable correctly
Closesrust-lang#59620
r? @pnkfelix
remove lookup_char_pos_adj
It is now exactly equivalent to lookup_char_pos.
…k, r=ehuss
Copy book.toml unstable book generator
Solves rust-lang#59554 and adds a book title to the unstable book.
I assume that [copy_recursive](https://github.com/rust-lang/rust/blob/acd8dd6a50d505057a7d7ad8d0d7a4c2bd274200/src/tools/unstable-book-gen/src/main.rs#L105) will take files regardless of their type (`.md` or `.toml`).
Although I had a hard time time testing it. A second pair of eyes is definitely needed.
Retire `IsNotConst` naming
This naming scheme caused a lot of confusion lately (including ICEs) due to misrefactored code. Also clean up the initialization code for said flag.
r? @eddyb
previous discussions: rust-lang#58784 (comment)rust-lang#58403 (comment)
…cramertj
Eliminate `FnBox` usages from libstd.
Fix links on keyword docs.
- Make links relative.
- Adjust links from old 2018-edition book.
- Fix broken link in `let` docs.
…acrum
Re-export NonZero signed variant in std
Closesrust-lang#59834 .
std: Add `{read,write}_vectored` for more types
This commit implements the `{read,write}_vectored` methods on more types
in the standard library, namely:
* `std::fs::File`
* `std::process::ChildStd{in,out,err}`
* `std::io::Std{in,out,err}`
* `std::io::Std{in,out,err}Lock`
* `std::io::Std{in,out,err}Raw`
Where supported the OS implementations hook up to native support,
otherwise it falls back to the already-defaulted implementation.
…-type-decl, r=QuietMisdreavus
Fix attributes position in type declaration
Fixesrust-lang#59797.
r? @rust-lang/rustdoc
…Centril
Make duplicate matcher bindings a hard error
r? @CentrilClosesrust-lang#57742
Use SecRandomCopyBytes instead of /dev/urandom on MacOS
SecRandomCopyBytes is [available since MacOS 10.7](https://developer.apple.com/documentation/security/1399291-secrandomcopybytes?language=objc) which is the minimum supported version and which was suggested in rust-lang#58901 (comment) is the earliest version currently in use.
This matches the behaviour of other platforms which have a random number generator syscall available.
…ize, r=pnkfelix
In `-Zprint-type-size` output, sort enum variants by size.
It's useful to see the biggest variants first.
r? @pnkfelix
…x, r=Centril
Fix paste error in split_ascii_whitespace docs.
It was accidentally still testing the unicode version, `split_whitespace`.
…Gomez
Exclude some copies of old book editions from search engines
These are only stubs that confuse search engine users. There's no useful content in these locations.
Use a proc macro to declare preallocated symbols
r? @petrochenkov
… r=alexcrichton
compiletest normalization: preserve non-JSON lines such as ICEs
Currently, every non-JSON line from stderr gets normalized away when compiletest normalizes the output. In particular, ICEs get normalized to the empty output. That does not seem desirable, so this changes normalization to preserve non-JSON lines instead.
Also see Manishearth/compiletest-rs#169: because of that bug, Miri currently *looks* green in the toolstate, but some tests ICE. That same bug is likely no longer present in latest compiletest because the error code gets checked separately, but it still seems like a good idea to also make sure that ICEs are considered stderr output:
This change found an accidental user-visible `error!` in CTFE validation (fixed), and a non-deterministic panic when there are two `main` symbols (not fixed, no idea where this comes from). Both got missed before because non-JSON output got ignored.
…x, r=QuietMisdreavus
Apply resource-suffix to search-index and source-files scripts as well
Fixesrust-lang#59771.
r? @QuietMisdreavus
…mp, r=alexcrichton
Exclude profiler-generated symbols from MSVC __imp_-symbol workaround.
LLVM's profiling instrumentation adds a few symbols that are used by the profiler runtime. Since these show up as globals in the LLVM IR, the compiler generates `dllimport`-related `__imp_` stubs for them. This can lead to linker errors because the instrumentation symbols have weak linkage or are in a comdat section, but the `__imp_` stubs aren't.
Instead of trying to replicate the linkage/comdat setup for the stubs, this PR just excludes the profiler-related symbols from stub-generation since they aren't supposed to be referenced via `__declspec(dllimport)` anywhere anyway.
r? @alexcrichton
EDIT: I considered making this more general, i.e. inferring from the symbol name if it is a Rust symbol or not. But then I figured out that that would yield false negatives for `#[no_mangle]` et al, so I went with a blacklist approach.
update polonius-engine
This updates polonius-engine to [version 0.7.0](https://github.com/rust-lang/polonius/blob/master/RELEASES.md#v070), which adds a hybrid algorithm that starts off with performing a cheaper, location-insensitive analysis before proceeding with the full analysis.
r? @nikomatsakis
…ramertj
Clean up handling of `-Z pgo-gen` commandline option.
This PR adapts the `-Z pgo-gen` flag to how Clang and GCC handle the corresponding `-fprofile-generate` flag. In particular, the flag now optionally takes a directory to place the profiling data in and allows to omit the argument (instead of having to pass an empty string).
…, r=QuietMisdreavus
Don't generate empty json variables
r? @rust-lang/rustdoc
…t-stack-sizes-gc-sections-ld-gold-bug, r=alexcrichton
Revert "compile crates under test w/ -Zemit-stack-sizes"
Revert PR rust-lang#59401 to fix issue rust-lang#59652 (a stable-to-beta regression).
This is result of squashing two revert commits:
Revert "compile all crates under test w/ -Zemit-stack-sizes"
This reverts commit 7d365cf.
Revert "bootstrap: build compiler-builtins with -Z emit-stack-sizes"
This reverts commit 8b8488c.
----
(My intention is that someone can re-add this code again later, either after the `ld.gold` issue itself is fixed, or with safe-guards to check whether `ld.gold` is in use and then issuing warnings about the problems here when they arise.)
Rollup of 18 pull requests
Successful merges:
- rust-lang#59612 (Use normal newtype_index macro for MIR dataflows)
- rust-lang#59675 (Stabilize the `alloc` crate.)
- rust-lang#59708 (Mark variables captured by reference as mutable correctly)
- rust-lang#59735 (remove lookup_char_pos_adj)
- rust-lang#59747 (Copy book.toml unstable book generator)
- rust-lang#59796 (Retire `IsNotConst` naming)
- rust-lang#59804 (Clean up jobserver integration)
- rust-lang#59818 (Eliminate `FnBox` usages from libstd.)
- rust-lang#59830 (Fix links on keyword docs.)
- rust-lang#59835 (Re-export NonZero signed variant in std)
- rust-lang#59852 (std: Add `{read,write}_vectored` for more types)
- rust-lang#59855 (Fix attributes position in type declaration)
- rust-lang#59858 (Make duplicate matcher bindings a hard error)
- rust-lang#59879 (Use SecRandomCopyBytes instead of /dev/urandom on MacOS)
- rust-lang#59899 (In `-Zprint-type-size` output, sort enum variants by size.)
- rust-lang#59912 (MaybeUninit: remove deprecated functions)
- rust-lang#59925 (Fix paste error in split_ascii_whitespace docs.)
- rust-lang#59930 (Exclude some copies of old book editions from search engines)
Failed merges:
r? @ghost
Rollup of 9 pull requests
Successful merges:
- rust-lang#59655 (Use a proc macro to declare preallocated symbols)
- rust-lang#59769 (compiletest normalization: preserve non-JSON lines such as ICEs)
- rust-lang#59776 (Apply resource-suffix to search-index and source-files scripts as well)
- rust-lang#59784 (Suggest importing macros from the crate root)
- rust-lang#59812 (Exclude profiler-generated symbols from MSVC __imp_-symbol workaround.)
- rust-lang#59856 (update polonius-engine)
- rust-lang#59874 (Clean up handling of `-Z pgo-gen` commandline option.)
- rust-lang#59890 (Don't generate empty json variables)
- rust-lang#59911 (Revert "compile crates under test w/ -Zemit-stack-sizes")
Failed merges:
r? @ghost
@CentrilCentril closed this Apr 13, 2019
@Centril
Centril deleted the rollup-j4h8pf3 branch April 13, 2019 14:27
@CentrilCentril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rollupA PR which is a rollup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

20 participants

@Centril@matthewjasper@matklad@RalfJung@davidtwco@oli-obk@Zoxc@michaelwoerister@ehuss@crlf0710@tesuji@alexcrichton@GuillaumeGomez@mark-i-m@ebarnard@nnethercote@pnkfelix@SimonSapin@solson@kornelski